aprantl added inline comments.
================
Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:203
+ .Case(".debug_pubnames", eSectionTypeDWARFDebugPubNames)
+ .Case(".debug_pubtypes", eSectionTypeDWARFDebugPubTypes)
+ .Case(".debug_str", eSectionTypeDWARFDebugStr)
----------------
Can these be correct? They seem too long.
================
Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.h:16
+
+class ObjectFileCOFF : public lldb_private::ObjectFile {
+ std::unique_ptr<llvm::object::COFFObjectFile> m_object;
----------------
Can you add a short doxygen comment?
================
Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.h:86
+ bool IsStripped() override {
+ // FIXME(compnerd) see if there is a good way to identify a /Z7 v /Zi or
/ZI
+ // build.
----------------
We usually don't sign our FIXMEs :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149987/new/
https://reviews.llvm.org/D149987
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
