[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

jwnhy added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147370/new/ https://reviews.llvm.org/D147370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

jwnhy added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147606/new/ https://reviews.llvm.org/D147606 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added a comment. In D143347#4298613 , @kpdev42 wrote: > So what are next steps? Are we going for implementation of > `DW_AT_no_unique_address` (which is going to be a non-standard extension) ? > @dblaikie @aprantl @Michael137 in my opinion t

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/DW_OP_div-with-signed.s:3 + + # RUN: %clang --target=x86_64-pc-linux -o %t %s + # RUN: %lldb %t -o "b f" -o "r

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

jingham added a comment. This was added without a test. Can you add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace added a comment. Sure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

jingham added a comment. This also seems a bit Quixotic to me. Unless you are also planning to remove the `script` command, there's nothing you can do in the command line that you can't do with the SB API so you aren't actually removing any functionality, just making it slightly less convenien

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

jingham added a comment. In D149312#4302449 , @wallace wrote: > Sure You can probably just add something to TestCommandDelete.py. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

bulbazord added inline comments. Comment at: lldb/source/Expression/LLVMUserExpression.cpp:339 + if (stack_frame_size == 0) +stack_frame_size = arch == llvm::Triple::msp430 ? 512 : 512 * 1024; kuilpd wrote: > bulbazord wrote: > > jingham wrote: > >

[Lldb-commits] [PATCH] D149096: [lldb] Speed up looking for dSYM next to executable

mib added inline comments. Comment at: lldb/source/Symbol/LocateSymbolFile.cpp:89-91 + dsym_file.append(".dSYM"); + llvm::sys::path::append(dsym_file, path_style, "Contents", "Resources", + "DWARF", filename); Why do you need the first

[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

wallace created this revision. wallace added a reviewer: jingham. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds some tests for removing lldb commands, user command and aliases. I've done in

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace added a comment. -> https://reviews.llvm.org/D149379 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D149312 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D149096: [lldb] Speed up looking for dSYM next to executable

bulbazord added inline comments. Comment at: lldb/source/Symbol/LocateSymbolFile.cpp:89-91 + dsym_file.append(".dSYM"); + llvm::sys::path::append(dsym_file, path_style, "Contents", "Resources", + "DWARF", filename); mib wrote: > Why do

[Lldb-commits] [PATCH] D149096: [lldb] Speed up looking for dSYM next to executable

bulbazord updated this revision to Diff 517725. bulbazord added a comment. Address @mib's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149096/new/ https://reviews.llvm.org/D149096 Files: lldb/source/Symbol/LocateSymbolFile.cpp Index:

[Lldb-commits] [lldb] be5f35e - lldb: Fix usage of sve functions on arm64

Author: Manoj Gupta Date: 2023-04-27T14:59:49-07:00 New Revision: be5f35e24f4c15caf3c4aeccddc54c52560c28a0 URL: https://github.com/llvm/llvm-project/commit/be5f35e24f4c15caf3c4aeccddc54c52560c28a0 DIFF: https://github.com/llvm/llvm-project/commit/be5f35e24f4c15caf3c4aeccddc54c52560c28a0.diff L

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe5f35e24f4c: lldb: Fix usage of sve functions on arm64 (authored by manojgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148752/new/ https://reviews.

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

manojgupta added a comment. Thanks, regarding sve from Linux headers, LLVM currently supports building with GCC 7.1 or clang 5.0 and both were released in 2017. SVE support in Linux kernel believe was added in Linux kernel 4.19 timeframe iso maybe late 2018. If SVE needs to be built from rece

[Lldb-commits] [PATCH] D149096: [lldb] Speed up looking for dSYM next to executable

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Thanks! LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149096/new/ https://reviews.llvm.org/D149096

[Lldb-commits] [PATCH] D149096: [lldb] Speed up looking for dSYM next to executable

JDevlieghere added a comment. IMHO this is optimizing the wrong thing. If FileSpec is slow, then we should try to make that faster, instead of updating the different places it's used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149096/new/ https

[Lldb-commits] [PATCH] D149394: Finish the job of D145569

jingham created this revision. jingham added reviewers: Michael137, JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The InstrumentationRuntime's defined a data structure to gather report d

[Lldb-commits] [PATCH] D149394: Finish the job of D145569

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149394/new/ https://reviews.llvm.org/D149394 __

[Lldb-commits] [lldb] 47f72ae - Make the TSan report capture data structure anonymous.

Author: Jim Ingham Date: 2023-04-27T17:36:31-07:00 New Revision: 47f72aede163348ee474be4a3004dc0a9195fa9c URL: https://github.com/llvm/llvm-project/commit/47f72aede163348ee474be4a3004dc0a9195fa9c DIFF: https://github.com/llvm/llvm-project/commit/47f72aede163348ee474be4a3004dc0a9195fa9c.diff LO

[Lldb-commits] [PATCH] D149394: Finish the job of D145569

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47f72aede163: Make the TSan report capture data structure anonymous. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D149397: Host: generalise `GetXcodeSDKPath`

compnerd created this revision. compnerd added reviewers: JDevlieghere, kastiglione, aprantl. compnerd added a project: LLDB. Herald added a project: All. compnerd requested review of this revision. This generalises the `GetXcodeSDKPath` hook to a `GetSDKRoot` path which will be re-used for the Wi

[Lldb-commits] [PATCH] D149397: Host: generalise `GetXcodeSDKPath`

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks Saleem! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149397/new/ https://reviews.llvm.org/D149397 ___

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

jwnhy updated this revision to Diff 517784. jwnhy marked an inline comment as done. jwnhy added a comment. Updated the patch to include the original code. Could you please help me push it to the main codebase?, as I don't have the push right to the repo. CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

jwnhy marked an inline comment as done. jwnhy added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/DW_OP_div-with-signed.s:3 + + # RUN: %clang --target=x86_64-pc-linux -o %t %s + # RUN: %lldb %t -o "b f" -o "r" -o "c" -o "c" -o "expression -T -- i" \

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

wallace added a comment. @jingham, in my use case, I'm exposing a minified LLDB client remotely, so the user won't have access to script command nor the SB API. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149312/new/ https://reviews.llvm.org/D14