[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/UnixSignals.h:127 + struct SignalCode { +ConstString m_description; +SignalCodePrintOption m_print_option; labath wrote: > I think w

[Lldb-commits] [lldb] af38530 - [lldb] Refactor CrashReason

Author: David Spickett Date: 2023-03-15T09:44:02Z New Revision: af38530ee29c285f3827e33a41edf27c9c3a6767 URL: https://github.com/llvm/llvm-project/commit/af38530ee29c285f3827e33a41edf27c9c3a6767 DIFF: https://github.com/llvm/llvm-project/commit/af38530ee29c285f3827e33a41edf27c9c3a6767.diff LOG

[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf38530ee29c: [lldb] Refactor CrashReason (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146043/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett updated this revision to Diff 505413. DavidSpickett added a comment. Use ASSERT_EQ, change name of new function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146044/new/ https://reviews.llvm.org/D146044 Files: lldb/include/lldb/Ta

[Lldb-commits] [lldb] 71c4d18 - Revert "[lldb] Refactor CrashReason"

Author: David Spickett Date: 2023-03-15T09:54:47Z New Revision: 71c4d186f1cf247f1aa45f4fd1b38f350b68d123 URL: https://github.com/llvm/llvm-project/commit/71c4d186f1cf247f1aa45f4fd1b38f350b68d123 DIFF: https://github.com/llvm/llvm-project/commit/71c4d186f1cf247f1aa45f4fd1b38f350b68d123.diff LOG

[Lldb-commits] [lldb] 6db766a - Reland "[lldb] Refactor CrashReason"

Author: David Spickett Date: 2023-03-15T10:15:44Z New Revision: 6db766aa1a079085a3952f62c769cad16a1cbf3e URL: https://github.com/llvm/llvm-project/commit/6db766aa1a079085a3952f62c769cad16a1cbf3e DIFF: https://github.com/llvm/llvm-project/commit/6db766aa1a079085a3952f62c769cad16a1cbf3e.diff LOG

[Lldb-commits] [PATCH] D146124: [lldb] Fix a 32 bit warning in ScriptedProcessInterface

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ../llvm-project/lldb/include/lldb/Interpreter/ScriptedProcessInterface.h:61:12: warning: implicit conversion fro

[Lldb-commits] [PATCH] D146124: [lldb] Fix a 32 bit warning in ScriptedProcessInterface

DavidSpickett added a reviewer: mib. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. This is pretty trivial but asking for review since I have no experience using this (and am not using it on 32 bit, just want to silence the warning). Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

DavidSpickett added a comment. > Since this is my first commit to such a large repository(and project), can > you please guide me with this @DavidSpickett ! Sure, you'll want to make a commit that only has changes to warnings and errors. You can split up this one to do that, see part "A)" of th

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

arichardson added a comment. Minor suggestions, feel free to ignore. Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:14 FreeBSDSignals::FreeBSDSignals() : UnixSignals() { Reset(); } void FreeBSDSignals::Reset() { I wonder if it would make

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

DavidSpickett added a comment. > As a side-note: Could the AArch64 bot > https://lab.llvm.org/buildbot/#/builders/219 pass LLVM_LIT_ARGS="-v" as well > so the log tells us which tests actually ran? That would be great! Done in https://github.com/llvm/llvm-zorg/commit/571f67f111870c25699ca47cef

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:14 FreeBSDSignals::FreeBSDSignals() : UnixSignals() { Reset(); } void FreeBSDSignals::Reset() { arichardson

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

DavidSpickett added a comment. If I run the test on 32 bit Arm I get these run lines: : 'RUN: at line 4'; '/usr/bin/python3.8' /home/david.spickett/llvm-project/lldb/test/Shell/helper/build.py --compiler=any --arch=32 --tools-dir=/home/david.spickett/build-llvm-arm/./bin --libs-dir=/home/d

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

DavidSpickett added a comment. I tested this on 32 bit Arm Linux and after a few bodges (see comment), the test itself works fine. I see the CI for the library cross compiles for this, so it makes sense. Comment at: lldb/test/Shell/helper/build.py:256 +self.objc_g

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 505528. sgraenitz marked an inline comment as done. sgraenitz added a comment. Fix CMakeLists.txt and build.py for the case that GNUstep is not installed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/ne

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added a comment. In D146058#4196060 , @DavidSpickett wrote: > If I run the test without the runtime installed I get these run lines [...] Oh, excellent catch. Thanks! Now, with my last patch, given that: > grep GNUSTEP CMakeCache.txt LLDB

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz updated this revision to Diff 505529. sgraenitz added a comment. Make the test more extensible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146058/new/ https://reviews.llvm.org/D146058 Files: lldb/test/CMakeLists.txt lldb/test/Shell

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

sgraenitz added inline comments. Comment at: lldb/test/CMakeLists.txt:39 +if (LLDB_TEST_OBJC_GNUSTEP_DIR) + message(STATUS "Found GNUstep ObjC runtime: ${LLDB_TEST_OBJC_GNUSTEP_DIR}/${gnustep_info}") +endif() sgraenitz wrote: > theraven wrote: > > DavidSpickett

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1220-1221 +return m_interrupt_requested != 0; + } else +return GetCommandInterpreter().WasInterrupted(); +} Nit: else-after-return. Comment at: lldb/source/

[Lldb-commits] [PATCH] D146152: Add __lldb_init_module_with_target for use when sourcing modules for a target

jingham created this revision. jingham added reviewers: clayborg, JDevlieghere, jasonmolenda, bulbazord. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We load python modules in two main ways: through `

[Lldb-commits] [PATCH] D146152: Add __lldb_init_module_with_target for use when sourcing modules for a target

JDevlieghere added a comment. Thanks for adding this, Jim. This is one of those things that comes up one in a while when it confuses our users. It's great we'll be able to help them adopt this. Comment at: lldb/bindings/python/python-wrapper.swig:1031-1048 + // First call th

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz created this revision. sgraenitz added reviewers: DavidSpickett, theraven, teemperor, bulbazord, labath. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is the next patch after D146058

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

theraven added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:42 +LanguageType language) { + if (language != eLanguageTypeObjC) +return nullptr;

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.cpp:253 +} + ObjCLanguageRuntime::ObjCISA This was always declared in the header, but never implemented. Instead, AppleObjCRuntime had its own implementati

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz marked 3 inline comments as done. sgraenitz added a comment. Hi David, thanks for your notes. Please find responses inline. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:42 +

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

bulbazord added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1973-1977 +HostThread &Debugger::SetIOHandlerThread(HostThread &new_thread) { + HostThread &old_host = m_io_handler_thread; + m_io_handler_thread = new_thread; + return old_host; +} JDe

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1973-1977 +HostThread &Debugger::SetIOHandlerThread(HostThread &new_thread) { + HostThread &old_host = m_io_handler_thread; + m_io_handler_thread = new_thread; + return old_host; +}

[Lldb-commits] [PATCH] D146152: Add __lldb_init_module_with_target for use when sourcing modules for a target

bulbazord added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:1031-1048 + // First call the target initializer: + if (target) { +python_function_name_string += ".__lldb_init_module_with_target"; +python_function_name = python_function_name_string

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

bulbazord added inline comments. Comment at: lldb/test/Shell/helper/toolchain.py:46 +if config.objc_gnustep_dir: + build_script_args.append('--objc-gnustep-dir="{0}"'.format(config.objc_gnustep_dir)) sgraenitz wrote: > bulbazord wrote: > > Why does

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. In general I don't think I have a problem with adding this, especially since Clang also supports the runtime as a compilation target, and LLDB is tightly integrated with Clang. Repository:

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

aprantl requested changes to this revision. aprantl added a comment. This revision now requires changes to proceed. One thing I just realized — we need to make sure that we don't accidentally create a GNUstep ObjC runtime in a Swift process that was built without ObjC support on Linux. How can w

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

aprantl added a comment. I.e., can you detect based on the presence of a symbol or shared object that an GNUstep runtime is present? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ https://reviews.llvm.org/D146154 __

[Lldb-commits] [lldb] 8bad4ae - [lldb] Change dwim-print to default to disabled persistent results

Author: Dave Lee Date: 2023-03-15T13:34:19-07:00 New Revision: 8bad4ae679df6fc7dbd016dccbd3da34206e836b URL: https://github.com/llvm/llvm-project/commit/8bad4ae679df6fc7dbd016dccbd3da34206e836b DIFF: https://github.com/llvm/llvm-project/commit/8bad4ae679df6fc7dbd016dccbd3da34206e836b.diff LOG:

[Lldb-commits] [PATCH] D145609: [lldb] Change dwim-print to default to disabled persistent results

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bad4ae679df: [lldb] Change dwim-print to default to disabled persistent results (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145

[Lldb-commits] [lldb] 9e6a65f - Revert "[lldb] Change dwim-print to default to disabled persistent results"

Author: Dave Lee Date: 2023-03-15T14:00:00-07:00 New Revision: 9e6a65f52ca6263795d81bde220fb4c80b7b05ec URL: https://github.com/llvm/llvm-project/commit/9e6a65f52ca6263795d81bde220fb4c80b7b05ec DIFF: https://github.com/llvm/llvm-project/commit/9e6a65f52ca6263795d81bde220fb4c80b7b05ec.diff LOG:

[Lldb-commits] [lldb] 9dbce77 - [lldb] Update PythonDataObjectsTests for new exception formatting

Author: Jonas Devlieghere Date: 2023-03-15T15:53:18-07:00 New Revision: 9dbce774eea515e400954f1d0ffbd858c839b546 URL: https://github.com/llvm/llvm-project/commit/9dbce774eea515e400954f1d0ffbd858c839b546 DIFF: https://github.com/llvm/llvm-project/commit/9dbce774eea515e400954f1d0ffbd858c839b546.d

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

jingham updated this revision to Diff 505645. jingham added a comment. Address Jonas' review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145136/new/ https://reviews.llvm.org/D145136 Files: lldb/include/lldb/API/SBCommandInterpreter.h

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145136/new/ https://reviews.llvm.org/D145136 ___

[Lldb-commits] [lldb] fe61b38 - Add a Debugger interruption mechanism in conjunction with the

Author: Jim Ingham Date: 2023-03-15T16:45:14-07:00 New Revision: fe61b38258bf4c5f34c32de26f4ed11ef5c32ebc URL: https://github.com/llvm/llvm-project/commit/fe61b38258bf4c5f34c32de26f4ed11ef5c32ebc DIFF: https://github.com/llvm/llvm-project/commit/fe61b38258bf4c5f34c32de26f4ed11ef5c32ebc.diff LO

[Lldb-commits] [PATCH] D145136: Add a Debugger interruption mechanism in parallel to the Command Interpreter interruption

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe61b38258bf: Add a Debugger interruption mechanism in conjunction with the (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145136/new/

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

AryanGodara added a comment. In D146041#4195992 , @DavidSpickett wrote: >> Since this is my first commit to such a large repository(and project), can >> you please guide me with this @DavidSpickett ! > > Sure, you'll want to make a commit that only has

[Lldb-commits] [PATCH] D146152: Add __lldb_init_module_with_target for use when sourcing modules for a target

jingham added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:1031-1048 + // First call the target initializer: + if (target) { +python_function_name_string += ".__lldb_init_module_with_target"; +python_function_name = python_function_name_string.c