JDevlieghere added inline comments.
================
Comment at: lldb/source/Core/Debugger.cpp:1220-1221
+ return m_interrupt_requested != 0;
+ } else
+ return GetCommandInterpreter().WasInterrupted();
+}
----------------
Nit: else-after-return.
================
Comment at: lldb/source/Core/Debugger.cpp:1973-1977
+HostThread &Debugger::SetIOHandlerThread(HostThread &new_thread) {
+ HostThread &old_host = m_io_handler_thread;
+ m_io_handler_thread = new_thread;
+ return old_host;
+}
----------------
This doesn't look right. You're taking a reference to the old thread, and then
immediately change it below. If you want to return the old thread, old_host
should be a copy.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145136/new/
https://reviews.llvm.org/D145136
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
