[Lldb-commits] [PATCH] D144688: [lldb] Fix watchpoint command function stopping behavior

delcypher added inline comments. Comment at: lldb/source/Commands/CommandObjectWatchpointCommand.cpp:425 else if (!m_options.m_function_name.empty()) { -std::string oneliner(m_options.m_function_name); +std::string oneliner("return "); +

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman edited reviewers, added: erichkeane, royjacobson, clang-language-wg; removed: mizvekov. aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. In D140996#4125177 , @bolshakov-a wrote: > @aaron.ballman, @rsmith, @mizveko

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3036 if (!std::is_trivially_destructible::value) { - auto DestroyPtr = [](void *V) { static_cast(V)->~T(); }; - AddDeallocation(DestroyPtr, Ptr); + auto DestroyPtr = [](void *V)

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a subscriber: mizvekov. bolshakov-a added a comment. Thanks for the review! I definitely can try to answer questions and fix issues, but I just want to note that I'm not the original author, and these changes already were upstream. (Maybe, @rsmith will find some time for taking

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman added a comment. In D140996#4150848 , @bolshakov-a wrote: >> Should this also update the status in clang/www/cxx_status.html? > > I'm not sure. There still remains an issue with template parameters of > reference type, which was tried to b

[Lldb-commits] [PATCH] D144688: [lldb] Fix watchpoint command function stopping behavior

mib added a subscriber: jingham. mib added inline comments. Comment at: lldb/source/Commands/CommandObjectWatchpointCommand.cpp:425 else if (!m_options.m_function_name.empty()) { -std::string oneliner(m_options.m_function_name); +std::string one

[Lldb-commits] [PATCH] D144688: [lldb] Fix watchpoint command function stopping behavior

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I'm alright with this patch since it at least makes watchpoint commands consistent with breakpoint commands (w.r.t the `-F` flag). Comment at: lldb/source/Commands/Com

[Lldb-commits] [PATCH] D144688: [lldb] Fix watchpoint command function stopping behavior

mib added inline comments. Comment at: lldb/source/Commands/CommandObjectWatchpointCommand.cpp:425 else if (!m_options.m_function_name.empty()) { -std::string oneliner(m_options.m_function_name); +std::string oneliner("return "); +on

[Lldb-commits] [PATCH] D144688: [lldb] Fix watchpoint command function stopping behavior

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. IIUC, not removing elements from the internal dict will mean cross-contamination between the python states when you have multiple concurrent debuggers, which for instance Xcode doe

[Lldb-commits] [PATCH] D144688: [lldb] Fix watchpoint command function stopping behavior

mib added a comment. In D144688#4151164 , @jingham wrote: > IIUC, not removing elements from the internal dict will mean > cross-contamination between the python states when you have multiple > concurrent debuggers, which for instance Xcode does a lot.

[Lldb-commits] [lldb] 1c417da - Remove uses of ATOMIC_VAR_INIT

Author: Fangrui Song Date: 2023-02-24T13:43:12-08:00 New Revision: 1c417da0f0605e027eb02fb4108d08397b566c3b URL: https://github.com/llvm/llvm-project/commit/1c417da0f0605e027eb02fb4108d08397b566c3b DIFF: https://github.com/llvm/llvm-project/commit/1c417da0f0605e027eb02fb4108d08397b566c3b.diff

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

shafik added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.nontype/p1.cpp:204 +#if __cplusplus == 201703L + // cxx17-error@-3 {{non-type template argument refers to subobject '(int *)1'}} +#endif Shouldn't this be an error b/c it is a tempo

[Lldb-commits] [lldb] bcb8a94 - [lldb][test] Fix vCont-threads/main.cp for -std=c++11

Author: Fangrui Song Date: 2023-02-24T15:08:24-08:00 New Revision: bcb8a94503887250d3a818a6b631899e9233080c URL: https://github.com/llvm/llvm-project/commit/bcb8a94503887250d3a818a6b631899e9233080c DIFF: https://github.com/llvm/llvm-project/commit/bcb8a94503887250d3a818a6b631899e9233080c.diff

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behavior

mib updated this revision to Diff 500317. mib retitled this revision from "[lldb] Fix watchpoint command function stopping behavior" to "[lldb] Fix {break,watch}point command function stopping behavior". mib edited the summary of this revision. mib added a comment. Address @jingham & @delcypher

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

shafik added inline comments. Comment at: clang/test/CodeGenCXX/template-arguments.cpp:4 + +template CONSTEXPR T id(T v) { return v; } +template auto value = id(V); I don't see any tests covering unions or enums. Comment at: clang/test/SemaTemp

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behavior

bulbazord requested changes to this revision. bulbazord added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1314-1324 +if (line.startswith("return ")) { + llvm::String

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behavior

bulbazord added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1314-1324 +if (line.startswith("return ")) { + llvm::StringRef return_val = + line.substr(llvm::StringRef("return ").size()); + sstr.Print

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

shafik added inline comments. Comment at: clang/include/clang/AST/TemplateBase.h:88 +/// so cannot be dependent. +UncommonValue, + erichkeane wrote: > I definitely hate the name here... Just `Value` makes a bit more sense, but > isn't perfectly accurate.

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

mib updated this revision to Diff 500349. mib retitled this revision from "[lldb] Fix {break,watch}point command function stopping behavior" to "[lldb] Fix {break,watch}point command function stopping behaviour". mib edited the summary of this revision. mib added a comment. The third implementat