bolshakov-a added a subscriber: mizvekov.
bolshakov-a added a comment.

Thanks for the review! I definitely can try to answer questions and fix issues, 
but I just want to note that I'm not the original author, and these changes 
already were upstream. (Maybe, @rsmith will find some time for taking a look at 
this, after all?)

It would be nice if @mizvekov would check my changes regarding 
`SugaredConverted` vs `CanonicalConverted`.

> Should this also update the status in clang/www/cxx_status.html?

I'm not sure. There still remains an issue with template parameters of 
reference type, which was tried to be fixed in 5a391d38ac6c 
<https://reviews.llvm.org/rG5a391d38ac6c561ba908334d427f26124ed9132e>. (On the 
other hand, MSVC team claims that their compiler supports P1907R1, despite that 
it simply crashes on some of the test cases from 5a391d38ac6c 
<https://reviews.llvm.org/rG5a391d38ac6c561ba908334d427f26124ed9132e>)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140996/new/

https://reviews.llvm.org/D140996

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits] ... Andrey Ali Khan Bolshakov via Phabricator via lldb-commits
    • [Lldb-comm... Andrey Ali Khan Bolshakov via Phabricator via lldb-commits
    • [Lldb-comm... Aaron Ballman via Phabricator via lldb-commits
    • [Lldb-comm... Erich Keane via Phabricator via lldb-commits
    • [Lldb-comm... Andrey Ali Khan Bolshakov via Phabricator via lldb-commits
    • [Lldb-comm... Aaron Ballman via Phabricator via lldb-commits
    • [Lldb-comm... Shafik Yaghmour via Phabricator via lldb-commits
    • [Lldb-comm... Shafik Yaghmour via Phabricator via lldb-commits
    • [Lldb-comm... Shafik Yaghmour via Phabricator via lldb-commits
    • [Lldb-comm... Andrey Ali Khan Bolshakov via Phabricator via lldb-commits
    • [Lldb-comm... Roy Jacobson via Phabricator via lldb-commits
    • [Lldb-comm... Erich Keane via Phabricator via lldb-commits
    • [Lldb-comm... Andrey Ali Khan Bolshakov via Phabricator via lldb-commits
    • [Lldb-comm... Andrey Ali Khan Bolshakov via Phabricator via lldb-commits
    • [Lldb-comm... Andrey Ali Khan Bolshakov via Phabricator via lldb-commits

Reply via email to