[Lldb-commits] [lldb] 5e111eb - Migrate away from the soft-deprecated functions in APInt.h (NFC)

Author: Kazu Hirata Date: 2023-02-20T00:58:29-08:00 New Revision: 5e111eb275eee3bec1123b4b85606328017e5ee5 URL: https://github.com/llvm/llvm-project/commit/5e111eb275eee3bec1123b4b85606328017e5ee5 DIFF: https://github.com/llvm/llvm-project/commit/5e111eb275eee3bec1123b4b85606328017e5ee5.diff L

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

kpdev42 created this revision. kpdev42 added reviewers: clayborg, davide, k8stone, DavidSpickett. kpdev42 added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kpdev42 requested review of this revision. Herald added a subscriber: lldb-commits. Before this pat

[Lldb-commits] [PATCH] D144392: [lldb] Skip signal handlers for ignored signals on lldb-server's side when stepping

kpdev42 created this revision. kpdev42 added reviewers: DavidSpickett, clayborg, k8stone, davide. kpdev42 added a project: LLDB. Herald added subscribers: JDevlieghere, s.egerton, dmgreen, simoncook, emaste. Herald added a project: All. kpdev42 requested review of this revision. Herald added subscr

[Lldb-commits] [PATCH] D144392: [lldb] Skip signal handlers for ignored signals on lldb-server's side when stepping

kpdev42 added a comment. 1. There is a situation where the patch might go wrong. When stepping while inside: - a signal handler when `SA_NODEFER` flag is set (the same signal can be received while it is still being handled), and the signal is received again; - a handler that is set on multip

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

DavidSpickett added a comment. What is the practical impact of the bug you are fixing? I guess it is something like if you set signal handling info, then attach to something, that info is not used. Until you set it again, then it'll be sent and used. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

labath added a comment. There's one thing that's not clear to me about this patch. What is the relationship between `qGetTLSAddr`, as implemented here, and its implementation in GDB? I guess they're not compatible since we're not sending or using the offset and link map fields, but it's not cle

[Lldb-commits] [PATCH] D144392: [lldb] Skip signal handlers for ignored signals on lldb-server's side when stepping

labath added subscribers: jingham, labath. labath requested changes to this revision. labath added a reviewer: jingham. labath added a comment. This revision now requires changes to proceed. I'm afraid you're fixing this at the wrong end. This kind of complex thread control does not belong inside

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

labath added a comment. In D142926#4124297 , @bulbazord wrote: > In D142926#4123492 , @labath wrote: > >> Well... right now, there isn't anything else to do there. >> >> Anyway, I don't think this is particularly

[Lldb-commits] [PATCH] D144224: [lldb] Extend SWIG SBProcess interface with WriteMemoryAsCString method

labath added inline comments. Comment at: lldb/bindings/interface/SBProcessExtensions.i:11 +''' +if not str[-1] == '\0': +str += '\0' I think this will fail if the string is empty (`""`). Somewhat relatedly, what if this

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Nice catch. As discussed internally, it would be great if we could remove this android-specific code path (by removing support for OS versions which necessitated it). Repository: rG LLVM

[Lldb-commits] [lldb] bf874eb - [lldb] Use llvm::rotr (NFC)

Author: Kazu Hirata Date: 2023-02-20T10:38:18-08:00 New Revision: bf874eb09bf3fb9ff13b6a06ec653acc5c041af0 URL: https://github.com/llvm/llvm-project/commit/bf874eb09bf3fb9ff13b6a06ec653acc5c041af0 DIFF: https://github.com/llvm/llvm-project/commit/bf874eb09bf3fb9ff13b6a06ec653acc5c041af0.diff L

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3896 + if (D->hasAttrs()) +ToField->setAttrs(D->getAttrs()); ToField->setAccess(D->getAccess()); balazske wrote: > The import of attributes is handled in function `ASTImporter::Impor

[Lldb-commits] [PATCH] D144366: [RISCV]Add more pattern for fma ins

craig.topper added a comment. I posted https://reviews.llvm.org/D17 to get these in the frontend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144366/new/ https://reviews.llvm.org/D144366 ___ lldb-c