labath added inline comments.

================
Comment at: lldb/bindings/interface/SBProcessExtensions.i:11
+            '''
+            if not str[-1] == '\0':
+                str += '\0'
----------------
I think this will fail if the string is empty (`""`). 

Somewhat relatedly, what if this appended the nul byte unconditionally (so it 
kinda behaved like std::string, which is always nul-terminated, but the nul 
byte is not counted as the length of the string)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144224/new/

https://reviews.llvm.org/D144224

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to