[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan marked 6 inline comments as done. cimacmillan added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2188 + +static std::optional set_data_breakpoint(const llvm::json::Object *breakpoint) { + std::string breakpoint_id = GetString(breakpoint, "id")

[Lldb-commits] [PATCH] D143061: [lldb][Language] Add more language types

Michael137 created this revision. Michael137 added reviewers: aprantl, labath. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adds more languages to the `language_names` list in preparation for addin

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

Michael137 created this revision. Michael137 added reviewers: aprantl, labath. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch allows users to evaluate expressions using `expr -l c++20`. Cu

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

Michael137 updated this revision to Diff 493899. Michael137 added a comment. - Remove redundant change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143062/new/ https://reviews.llvm.org/D143062 Files: lldb/source/Plugins/ExpressionParser/Clang/C

[Lldb-commits] [PATCH] D143068: [lldb][SymbolFileDWARF] Support by-name lookup of global variables in inline namespaces

Michael137 created this revision. Michael137 added reviewers: aprantl, labath, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently evaluating an expression involving a global variable i

[Lldb-commits] [PATCH] D142824: [lldb][NFC] Use move instead of copy

Michael137 added a comment. In D142824#4095360 , @ccotter wrote: > Thanks! I don't have push access, so if you're good with this, could you > please land this for me? Sure, could you let me know which email and name you'd like me to use in the commit?

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan updated this revision to Diff 493936. cimacmillan added a comment. Refactored Watchpoint class and addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 Files: lldb/packages/Pyt

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan marked 12 inline comments as done. cimacmillan added a comment. @clayborg Thanks for your feedback. I've refactored the Watchpoint class slightly so that it encapsulates the parsing of the setDataBreakpoints request and be used to get the Breakpoint info to attach to the response. Th

[Lldb-commits] [PATCH] D143068: [lldb][SymbolFileDWARF] Support by-name lookup of global variables in inline namespaces

Michael137 updated this revision to Diff 493938. Michael137 added a comment. - Add test-case for nested inline namespaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143068/new/ https://reviews.llvm.org/D143068 Files: lldb/source/Plugins/Symbo

[Lldb-commits] [PATCH] D142824: [lldb][NFC] Use move instead of copy

ccotter added a comment. This should do: `Chris Cotter ` thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142824/new/ https://reviews.llvm.org/D142824 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [lldb] 6953dc9 - [lldb][NFC] Use move instead of copy

Author: Chris Cotter Date: 2023-02-01T15:51:24Z New Revision: 6953dc95a9761768cad3c329ebac35927df126ab URL: https://github.com/llvm/llvm-project/commit/6953dc95a9761768cad3c329ebac35927df126ab DIFF: https://github.com/llvm/llvm-project/commit/6953dc95a9761768cad3c329ebac35927df126ab.diff LOG:

[Lldb-commits] [PATCH] D142824: [lldb][NFC] Use move instead of copy

This revision was automatically updated to reflect the committed changes. Closed by commit rG6953dc95a976: [lldb][NFC] Use move instead of copy (authored by ccotter, committed by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142824/new/

[Lldb-commits] [lldb] 0803241 - [lldb] Enable TestFrameFormatNameWithArgs in case of cross compilation

Author: Ayush Sahay Date: 2023-02-01T23:05:28+05:30 New Revision: 08032411301e8996879c4b558b8bb3808d5dfe6f URL: https://github.com/llvm/llvm-project/commit/08032411301e8996879c4b558b8bb3808d5dfe6f DIFF: https://github.com/llvm/llvm-project/commit/08032411301e8996879c4b558b8bb3808d5dfe6f.diff L

[Lldb-commits] [PATCH] D140839: [lldb] Enable TestFrameFormatNameWithArgs in case of cross compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG08032411301e: [lldb] Enable TestFrameFormatNameWithArgs in case of cross compilation (authored by asahay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1408

[Lldb-commits] [PATCH] D143061: [lldb][Language] Add more language types

aprantl added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:492 + eLanguageTypeAda2005 = 0x002e, + eLanguageTypeAda2012 = 0x002f, + Would it make sense to generate this list from the macros in `llvm/include/llvm/BinaryFormat/Dwarf.def` wit

[Lldb-commits] [PATCH] D143061: [lldb][Language] Add more language types

Michael137 added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:492 + eLanguageTypeAda2005 = 0x002e, + eLanguageTypeAda2012 = 0x002f, + aprantl wrote: > Would it make sense to generate this list from the macros in > `llvm/include/llvm/Binar

[Lldb-commits] [PATCH] D143068: [lldb][SymbolFileDWARF] Support by-name lookup of global variables in inline namespaces

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2227 +(actual_parent_decl_ctx != parent_decl_ctx && + !parent_decl_ctx.IsContainedInLookup(actual_parent_decl_ctx))) return true; ---

[Lldb-commits] [PATCH] D143061: [lldb][Language] Add more language types

aprantl added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:492 + eLanguageTypeAda2005 = 0x002e, + eLanguageTypeAda2012 = 0x002f, + Michael137 wrote: > aprantl wrote: > > Would it make sense to generate this list from the macros in > > `ll

[Lldb-commits] [PATCH] D143061: [lldb][Language] Add more language types

aprantl added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:492 + eLanguageTypeAda2005 = 0x002e, + eLanguageTypeAda2012 = 0x002f, + aprantl wrote: > Michael137 wrote: > > aprantl wrote: > > > Would it make sense to generate this list from t

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds process attach capabilities to the ScriptedProcess plugin. This doesn't r

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

aprantl added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:548 +[[fallthrough]]; case lldb::eLanguageTypeC_plus_plus: case lldb::eLanguageTypeC_plus_plus_11: Why no case C++17? Com

[Lldb-commits] [PATCH] D143068: [lldb][SymbolFileDWARF] Support by-name lookup of global variables in inline namespaces

Michael137 updated this revision to Diff 494057. Michael137 added a comment. - Add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143068/new/ https://reviews.llvm.org/D143068 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

[Lldb-commits] [PATCH] D143068: [lldb][SymbolFileDWARF] Support by-name lookup of global variables in inline namespaces

Michael137 updated this revision to Diff 494058. Michael137 added a comment. - Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143068/new/ https://reviews.llvm.org/D143068 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFil

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Makes sense to me. It does seem a little weird that you can specify a name or a pid for attaching to a scripted process but I suppose that's just a part of the interface. Repository:

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

mib updated this revision to Diff 494107. mib added a comment. Small fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139252/new/ https://reviews.llvm.org/D139252 Files: lldb/bindings/python/python-swigsafecast.swig lldb/bindings/python/python-wrapper.swig lldb/examples/python

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

mib updated this revision to Diff 494110. mib added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139945/new/ https://reviews.llvm.org/D139945 Files: lldb/bindings/interface/SBAttachInfo.i lldb/include/lldb/API/SBAttachInfo.h lldb/include/lldb/API/SBStructuredDa

[Lldb-commits] [PATCH] D143122: [lldb/python] Fix scripted_platform python module creation

mib created this revision. mib added a reviewer: bulbazord. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix the creation and addition of the `scrip

[Lldb-commits] [lldb] 4adabb8 - Fix typo: FineLineEntriesForFileIndex -> FindLineEntriesForFileIndex.

Author: Jim Ingham Date: 2023-02-01T16:41:17-08:00 New Revision: 4adabb8786b87e9f105e37d5606e1c0187abc647 URL: https://github.com/llvm/llvm-project/commit/4adabb8786b87e9f105e37d5606e1c0187abc647 DIFF: https://github.com/llvm/llvm-project/commit/4adabb8786b87e9f105e37d5606e1c0187abc647.diff LO

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. In D141907#4094748 , @MaskRay wrote: > The CMake part of this patch improves the matter. Manually constructed > resource dir (many duplicates) string is replace with a library function call. > > However, the introduced condi

[Lldb-commits] [PATCH] D143127: [LLDB] Fix assertion failure by removing `CopyType` in `std::coroutine_handle` pretty printer

avogelsgesang created this revision. avogelsgesang added reviewers: labath, aprantl. Herald added a subscriber: ChuanqiXu. Herald added a project: All. avogelsgesang requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The pretty printer for `st

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

erikdesjardins updated this revision to Diff 494155. erikdesjardins added a comment. rebase over landed D142861 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142862/new/ https://reviews.llvm.org/D142862 Files:

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

erikdesjardins added a comment. In D142862#4089860 , @serge-sans-paille wrote: > Can you take a shot against https://llvm-compile-time-tracker.com/ so that > we get an hint of the practical speedup? I ran rustc perf tests using a patched LLVM in http

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

serge-sans-paille added a comment. https://llvm-compile-time-tracker.com/compare.php?from=1a17739d3aa78599c32f6106e05dcfa7f3f9e823&to=9c1adc5fcca177d6628bdb22c72e7546c7b691aa&stat=instructions:u looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews