aprantl added inline comments.

================
Comment at: lldb/include/lldb/lldb-enumerations.h:492
+  eLanguageTypeAda2005 = 0x002e,
+  eLanguageTypeAda2012 = 0x002f,
+
----------------
aprantl wrote:
> Michael137 wrote:
> > aprantl wrote:
> > > Would it make sense to generate this list from the macros in 
> > > `llvm/include/llvm/BinaryFormat/Dwarf.def` with some clever application 
> > > of the ## operator?
> > The only thing that's stopping us from doing this is that the constants for 
> > the vendor extensions are not consecutive with the rest of the constants. 
> > So if one ever does try to use that language constant we'd run into 
> > out-of-bounds accesses here and there
> Do have arrays that are indexed by language? Or what would be an example of 
> that?
Also, we could still define eNumLanguagesTypes to be at the end of the official 
block?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143061/new/

https://reviews.llvm.org/D143061

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to