[Lldb-commits] [PATCH] D133763: WIP strawman building perf.cpp on an older kernel

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133763 Files: lldb/source/Plugins/Process/Li

[Lldb-commits] [PATCH] D133763: WIP strawman building perf.cpp on an older kernel

DavidSpickett planned changes to this revision. DavidSpickett added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/Process/Linux/Perf.cpp:28 lldb_private::process_linux::LoadPerfTscConversionParameters() { #if LINUX_VERSION_CODE >= KER

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov marked an inline comment as not done. mizvekov added a subscriber: davrec. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1091-1150 +QualType fpTy = ComplexTy->castAs()->getElementType(); IntExpr = S.ImpCastExprToType(IntExpr.get(), fpTy

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

thakis added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47 lldbUtility +lldbPluginDynamicLoaderDarwinKernel +lldbPluginObjectContainerMachOFileset jasonmolenda wrote: > jasonmolenda wrote: > > thakis wrote: > > >

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This seems in line with what was being discussed. Jim, do you have any thoughts on this? Comment at: lldb/include/lldb/lldb-enumerations.h:841 + + kNumFormatterMatchTypes,

[Lldb-commits] [PATCH] D133763: WIP strawman building perf.cpp on an older kernel

labath added a comment. (This file is only used for the processor trace feature, and one can debug just fine without it. So, I'd just conditionally compile out the processor trace support on older kernels -- it's highly questionable whether this works there anyway). Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels

calebzulawski created this revision. calebzulawski added a reviewer: DavidSpickett. calebzulawski added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. calebzulawski requested review of this revision. Herald added a subscriber: lldb-commits. These fields are

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

davrec added a comment. The lines you changed (clang/lib/Sema/SemaExpr.cpp:1091-1150) look good (IIUC you just change cast to cast_as and dyn_cast to getAs, and reorganize for clarity). I suggested some renaming and a few more comments to further clarify. Comment at: clang/l

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

davrec added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1113-1114 +// "double _Complex" is promoted to "long double _Complex". +static QualType handleComplexFloatConversion(Sema &S, ExprResult &LHS, + QualType LHSType, Qua

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

labath added a comment. In D133446#3780961 , @zequanwu wrote: > In D133446#3779600 , @labath wrote: > >> I believe that this fixes the crash, but the names of generated functions >> still look fairly weird. Could

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels

DavidSpickett added reviewers: wallace, jj10306. DavidSpickett added a comment. Adding reviewers who know the trace feature. Seems fine at a glance for the functions that return error types already but for example `GetEffectiveDataBufferSize` check who calls it and might crash if it returns 0.

[Lldb-commits] [PATCH] D133763: WIP strawman building perf.cpp on an older kernel

DavidSpickett abandoned this revision. DavidSpickett added a comment. For https://github.com/llvm/llvm-project/issues/57594, succeeded by https://reviews.llvm.org/D133778. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133763/new/ https://reviews.l

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels

calebzulawski added a comment. I'm not exactly sure what llvm_unreachable does, but I don't believe it will return 0 (maybe it aborts?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133778/new/ https://reviews.llvm.org/D133778 ___

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels

DavidSpickett added a comment. llvm_unreachable is equivalent to __builtin_unreachable so yes it aborts with a stack trace. I misread and thought you were returning values still. Worth trying one of the trace commands in this build and see if lldb crashes or we get a nice "not supported" messag

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels

calebzulawski added a comment. In terms of who calls it and might error, it looks like it's all used in IntelPTMultiCoreTrace.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133778/new/ https://reviews.llvm.org/D133778 _

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels

DavidSpickett added a comment. > old Linux kernels Also, could you include the kernel versions (that you know about at least) in the commit message. For the next person who hits this and wonders if your change is what they need to include. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels (pre-4.1)

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Lgtm, but please include the kernel version for the record Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133778/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D133778: Fix LLDB build on old Linux kernels (pre-4.1)

wallace added a comment. Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133778/new/ https://reviews.llvm.org/D133778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [lldb] f4fc405 - lldb: Add support for R_386_32 relocations to ObjectFileELF

Author: David M. Lary Date: 2022-09-13T18:38:48+02:00 New Revision: f4fc4056319dd8ddfb8759f71c7aec86882c9110 URL: https://github.com/llvm/llvm-project/commit/f4fc4056319dd8ddfb8759f71c7aec86882c9110 DIFF: https://github.com/llvm/llvm-project/commit/f4fc4056319dd8ddfb8759f71c7aec86882c9110.diff

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4fc4056319d: lldb: Add support for R_386_32 relocations to ObjectFileELF (authored by dmlary, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:841 + + kNumFormatterMatchTypes, +}; labath wrote: > I see the enums in this file use wildly inconsistent styles for the "largest > value" enumerator. However, you've picked the one

[Lldb-commits] [lldb] 7240436 - [lldb] Fixed a number of typos

Author: Gabriel Ravier Date: 2022-09-13T10:38:38-07:00 New Revision: 7240436c94bd02762a723a2e3551528d16c8efdb URL: https://github.com/llvm/llvm-project/commit/7240436c94bd02762a723a2e3551528d16c8efdb DIFF: https://github.com/llvm/llvm-project/commit/7240436c94bd02762a723a2e3551528d16c8efdb.diff

[Lldb-commits] [PATCH] D131122: [lldb] Fixed a number of typos

This revision was automatically updated to reflect the committed changes. Closed by commit rG7240436c94bd: [lldb] Fixed a number of typos (authored by GabrielRavier, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D131122?vs=449806&id=459801#toc Repository: rG L

[Lldb-commits] [PATCH] D133546: [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp:66 ReportError( "no target path specified in with the LLDB_FUZZER_TARGET variable"); I think having a flag for the fuzzer target

[Lldb-commits] [PATCH] D133790: Fix heap-use-after-free when clearing DIEs in fission compile units.

rupprecht created this revision. rupprecht added reviewers: labath, clayborg. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D131437 caused heap-use-after-free failu

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

rupprecht added a comment. In D131437#3751366 , @bkramer wrote: > This seems to trigger a use after free in `lldb-api :: > functionalities/thread/create_after_attach/TestCreateAfterAttach.py` > > asan log: > > ==4741==ERROR: AddressSanitizer: heap-use-

[Lldb-commits] [PATCH] D133045: Partial fix for handling backticks in commands and aliases

jingham marked an inline comment as done. jingham added inline comments. Comment at: lldb/source/Interpreter/Options.cpp:1026 +} else + option_to_insert = CommandInterpreter::g_no_argument; + hawkinsw wrote: > Question: Could we drop the final `else` if

[Lldb-commits] [PATCH] D133045: Partial fix for handling backticks in commands and aliases

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. jingham marked an inline comment as done. Closed by commit rG6c089b2af5d8: Be more careful to maintain quoting information when parsing comma

[Lldb-commits] [lldb] 6c089b2 - Be more careful to maintain quoting information when parsing commands.

Author: Jim Ingham Date: 2022-09-13T11:02:47-07:00 New Revision: 6c089b2af5d8d98f66b27b67f70958f520820a76 URL: https://github.com/llvm/llvm-project/commit/6c089b2af5d8d98f66b27b67f70958f520820a76 DIFF: https://github.com/llvm/llvm-project/commit/6c089b2af5d8d98f66b27b67f70958f520820a76.diff LO

[Lldb-commits] [PATCH] D133790: Fix heap-use-after-free when clearing DIEs in fission compile units.

clayborg added a comment. LGTM, but I will let Pavel comment since he did the fission support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133790/new/ https://reviews.llvm.org/D133790 ___ lldb-commits

[Lldb-commits] [PATCH] D133045: Partial fix for handling backticks in commands and aliases

mstorsjo added a comment. This seems to break the build with GCC (tested with the system compiler GCC 9 on Ubuntu 20.04): ld.lld: error: undefined symbol: lldb_private::CommandInterpreter::g_argument >>> referenced by CommandAlias.cpp >>> CommandAlias.cpp.o:(lldb_private::Co

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary added a comment. I saw the build bot failures; looking into them now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132954/new/ https://reviews.llvm.org/D132954 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

dmlary added a comment. I'm not sure what to do about the test cases that now unexpectedly pass. The removal of the `assert()` in `ObjectFileELF::ApplyRelocations` means each of these cases is now passing on what looks like 32-bit arm, but I don't know enough about the three tests to say that

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu added a comment. In D133446#3786561 , @labath wrote: > In D133446#3780961 , @zequanwu > wrote: > >> In D133446#3779600 , @labath wrote: >> >>> I believe that thi

[Lldb-commits] [PATCH] D133546: [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

rupprecht updated this revision to Diff 459844. rupprecht added a comment. - Update error message to reference the new command line flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133546/new/ https://reviews.llvm.org/D133546 Files: lldb/tools

[Lldb-commits] [PATCH] D133546: [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

rupprecht marked an inline comment as done. rupprecht added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/lldb-expression-fuzzer.cpp:66 ReportError( "no target path specified in with the LLDB_FUZZER_TARGET variable");

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

jgorbe updated this revision to Diff 459845. jgorbe added a comment. Replaced `kNumFormatterMatchTypes` with `eLastFormatterMatchType` to avoid "unhandled enum value" warnings, as suggested by Pavel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133240/new/ https://reviews.llvm.org/D13

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef3fa232b338: [Formatters][NFCI] Replace 'is_regex' arguments with an enum. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [lldb] ef3fa23 - [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

Author: Jorge Gorbe Moya Date: 2022-09-13T12:50:55-07:00 New Revision: ef3fa232b338fd73475656ed61847295b0beef24 URL: https://github.com/llvm/llvm-project/commit/ef3fa232b338fd73475656ed61847295b0beef24 DIFF: https://github.com/llvm/llvm-project/commit/ef3fa232b338fd73475656ed61847295b0beef24.di

[Lldb-commits] [lldb] 8433b21 - constexpr isn't right here.

Author: Jim Ingham Date: 2022-09-13T13:01:56-07:00 New Revision: 8433b210839ed655852428ba8b34bb67b191957a URL: https://github.com/llvm/llvm-project/commit/8433b210839ed655852428ba8b34bb67b191957a DIFF: https://github.com/llvm/llvm-project/commit/8433b210839ed655852428ba8b34bb67b191957a.diff LO

[Lldb-commits] [PATCH] D133546: [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

cassanova added a comment. The wording is good, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133546/new/ https://reviews.llvm.org/D133546 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 81f8788 - Trying to understand the TestHelp.py failure from 6c089b2.

Author: Jim Ingham Date: 2022-09-13T14:09:44-07:00 New Revision: 81f8788528886ee611041e1f4ee54eea8bbfa277 URL: https://github.com/llvm/llvm-project/commit/81f8788528886ee611041e1f4ee54eea8bbfa277 DIFF: https://github.com/llvm/llvm-project/commit/81f8788528886ee611041e1f4ee54eea8bbfa277.diff LO

[Lldb-commits] [PATCH] D133680: Add support for mach-o corefile loading of a platform binary

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133680/new/ https://reviews.llvm.org/D133680 ___

[Lldb-commits] [PATCH] D133680: Add support for mach-o corefile loading of a platform binary

jasonmolenda added inline comments. Comment at: lldb/include/lldb/Target/DynamicLoader.h:231 + /// Name of the binary, if available. If an empty StringRef is + /// passed here, a name will be constructed for the module. + /// DavidSpickett wrote: > Ca

[Lldb-commits] [lldb] 3f23eb6 - Revert "Trying to understand the TestHelp.py failure from 6c089b2."

Author: Jim Ingham Date: 2022-09-13T14:58:27-07:00 New Revision: 3f23eb6591bb1eecae38019e8ab1fdf5e2951ae9 URL: https://github.com/llvm/llvm-project/commit/3f23eb6591bb1eecae38019e8ab1fdf5e2951ae9 DIFF: https://github.com/llvm/llvm-project/commit/3f23eb6591bb1eecae38019e8ab1fdf5e2951ae9.diff LO

[Lldb-commits] [lldb] a2d0a01 - Revert "constexpr isn't right here."

Author: Jim Ingham Date: 2022-09-13T14:58:53-07:00 New Revision: a2d0a01e3f9941d0d5370890105f70da142f493f URL: https://github.com/llvm/llvm-project/commit/a2d0a01e3f9941d0d5370890105f70da142f493f DIFF: https://github.com/llvm/llvm-project/commit/a2d0a01e3f9941d0d5370890105f70da142f493f.diff LO

[Lldb-commits] [lldb] ac05bc0 - Revert "Be more careful to maintain quoting information when parsing commands."

Author: Jim Ingham Date: 2022-09-13T14:59:21-07:00 New Revision: ac05bc0524c66c74278b26742896a4c634c034cf URL: https://github.com/llvm/llvm-project/commit/ac05bc0524c66c74278b26742896a4c634c034cf DIFF: https://github.com/llvm/llvm-project/commit/ac05bc0524c66c74278b26742896a4c634c034cf.diff LO

[Lldb-commits] [PATCH] D133680: Add support for mach-o corefile loading of a platform binary

jasonmolenda updated this revision to Diff 459889. jasonmolenda added a comment. Update to address David's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133680/new/ https://reviews.llvm.org/D133680 Files: lldb/include/lldb/Target/Dynam

[Lldb-commits] [PATCH] D133546: [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

This revision was automatically updated to reflect the committed changes. rupprecht marked an inline comment as done. Closed by commit rG4fdda4f82d78: [lldb][fuzz] Allow expression fuzzer to be passed as a flag. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [lldb] 4fdda4f - [lldb][fuzz] Allow expression fuzzer to be passed as a flag.

Author: Jordan Rupprecht Date: 2022-09-13T15:39:15-07:00 New Revision: 4fdda4f82d787c988d5bbdf365df95fd0c8ca14b URL: https://github.com/llvm/llvm-project/commit/4fdda4f82d787c988d5bbdf365df95fd0c8ca14b DIFF: https://github.com/llvm/llvm-project/commit/4fdda4f82d787c988d5bbdf365df95fd0c8ca14b.di

[Lldb-commits] [lldb] 92bd2e4 - Add mach-o corefile support for platform binaries

Author: Jason Molenda Date: 2022-09-13T15:46:18-07:00 New Revision: 92bd2e443e8f0337ef5cc55c9b4a7ea6e3f450b6 URL: https://github.com/llvm/llvm-project/commit/92bd2e443e8f0337ef5cc55c9b4a7ea6e3f450b6 DIFF: https://github.com/llvm/llvm-project/commit/92bd2e443e8f0337ef5cc55c9b4a7ea6e3f450b6.diff

[Lldb-commits] [PATCH] D133680: Add support for mach-o corefile loading of a platform binary

This revision was automatically updated to reflect the committed changes. Closed by commit rG92bd2e443e8f: Add mach-o corefile support for platform binaries (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133680/new/ https:

[Lldb-commits] [PATCH] D133530: [lldb] Add zstd support

MaskRay added a comment. Ping for unresolved issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133530/new/ https://reviews.llvm.org/D133530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D133828: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 1

Ericson2314 created this revision. Herald added a subscriber: mgorny. Herald added a project: All. Ericson2314 requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. A simple sed doing these substitutions: - `${LLVM_BINARY_DIR}/

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

Ericson2314 updated this revision to Diff 459975. Ericson2314 added a comment. Require `LLVM_LIBDIR_SUFFIX` in the sed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 Files: clang/cmake/modules/CMakeLis

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

Ericson2314 added a comment. I think I fixed the issue: I was confusing `/lib` stemming from lib subdirs in the source and `/lib` stemming from building things in a lib directory that will later be installed also to a lib directory. It is just the latter case that uses the suffix, and so just t