[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

mstorsjo added a comment. This commit caused warnings when building with GCC: ../tools/lldb/source/Commands/CommandObjectThread.cpp: In member function ‘virtual lldb_private::Status CommandObjectThreadBacktrace::CommandOptions::SetOptionValue(uint32_t, llvm::StringRef, lldb_private::Executio

[Lldb-commits] [lldb] 5f0080f - [lldb] Fix warnings about unused variables when building without asserts. NFC.

Author: Martin Storsjö Date: 2022-08-29T13:25:38+03:00 New Revision: 5f0080fbe810caae3750d159da62bac04dbd844f URL: https://github.com/llvm/llvm-project/commit/5f0080fbe810caae3750d159da62bac04dbd844f DIFF: https://github.com/llvm/llvm-project/commit/5f0080fbe810caae3750d159da62bac04dbd844f.diff

[Lldb-commits] [PATCH] D132841: [lldb] Use the NativeSock type instead of plain 'int'

mstorsjo created this revision. mstorsjo added reviewers: labath, fixathon, jasonmolenda, clayborg, JDevlieghere, DavidSpickett. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This fixes a warning when building for Windows: ../tools/lldb/

[Lldb-commits] [PATCH] D132841: [lldb] Use the NativeSock type instead of plain 'int'

fixathon accepted this revision. fixathon added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132841/new/ https://reviews.llvm.org/D132841 __

[Lldb-commits] [PATCH] D132803: [lldb][test] Speed up lldb arch determination (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132803/new/ https://reviews.llvm.org/D132803 ___

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, mib, jasonmolenda. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While investigating slow tests, I noticed that `TestLl

[Lldb-commits] [lldb] 296f761 - [lldb][test] Speed up lldb arch determination (NFC)

Author: Dave Lee Date: 2022-08-29T10:20:51-07:00 New Revision: 296f7614edcfb9ac52842d9b952d6eadb0ad6edf URL: https://github.com/llvm/llvm-project/commit/296f7614edcfb9ac52842d9b952d6eadb0ad6edf DIFF: https://github.com/llvm/llvm-project/commit/296f7614edcfb9ac52842d9b952d6eadb0ad6edf.diff LOG:

[Lldb-commits] [PATCH] D132803: [lldb][test] Speed up lldb arch determination (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG296f7614edcf: [lldb][test] Speed up lldb arch determination (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132803/new/ https

[Lldb-commits] [lldb] 9537bfe - [lldb] Remove mention of dotest.pl

Author: Dave Lee Date: 2022-08-29T10:21:40-07:00 New Revision: 9537bfeedf52654eff45564015a51b2265e8c5f6 URL: https://github.com/llvm/llvm-project/commit/9537bfeedf52654eff45564015a51b2265e8c5f6 DIFF: https://github.com/llvm/llvm-project/commit/9537bfeedf52654eff45564015a51b2265e8c5f6.diff LOG:

[Lldb-commits] [lldb] a3172df - [lldb] Quietly source lit-lldb-init

Author: Dave Lee Date: 2022-08-29T10:22:01-07:00 New Revision: a3172df59c32aac48c113eb7d6a1324aaa95c474 URL: https://github.com/llvm/llvm-project/commit/a3172df59c32aac48c113eb7d6a1324aaa95c474 DIFF: https://github.com/llvm/llvm-project/commit/a3172df59c32aac48c113eb7d6a1324aaa95c474.diff LOG:

[Lldb-commits] [PATCH] D132694: [lldb] Quietly source lit-lldb-init

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3172df59c32: [lldb] Quietly source lit-lldb-init (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132694/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D131693: [lldb][Breakpoint] Prevent crash when resolving regex breakpoint on functions with asm declaration

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM. It's hard to prove a negative, but it might be worth checking the other uses of GetFunctionName and make sure we aren't making a similar mistake? Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

JDevlieghere added a comment. The test that's using `iostream` could be rewritten to use `printf` instead. It actually looks like most of those test can be compiled as C programs, which should speed this up even more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D132803: [lldb][test] Speed up lldb arch determination (NFC)

mib added a comment. LGTM! In D132803#3753899 , @kastiglione wrote: > I wonder if it's worth disabling `target.load-script-from-symbol-file` for > all tests as well. I think this feature only works with dSYM bundles on macOS and only certain test wou

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

kastiglione added a comment. The file in question uses c++ headers: lldb/test/API/tools/lldb-server/main.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132868/new/ https://reviews.llvm.org/D132868 ___

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

jingham updated this revision to Diff 456473. jingham added a comment. Herald added subscribers: arphaman, MaskRay, emaste. Herald added a reviewer: ributzka. Remove the static factories and replace them with constructors. This was mostly mechanical, but a biggish patch against the previous versi

[Lldb-commits] [PATCH] D132868: [lldb][test] Enable clang modules in API/tools/lldb-server (NFC)

kastiglione added a comment. I updated the description to remove the mention of `iostream`, since that's not the specific problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132868/new/ https://reviews.llvm.org/D132868