[Lldb-commits] [PATCH] D131983: [LLDB][NFC] Fix optons parsing and misc. reliability in CommandObjectThread

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo added a comment.

This commit caused warnings when building with GCC:

  ../tools/lldb/source/Commands/CommandObjectThread.cpp: In member function 
‘virtual lldb_private::Status 
CommandObjectThreadBacktrace::CommandOptions::SetOptionValue(uint32_t, 
llvm::StringRef, lldb_private::ExecutionContext*)’:
  ../tools/lldb/source/Commands/CommandObjectThread.cpp:66:61: warning: 
comparison of unsigned expression < 0 is always false [-Wtype-limits]
     66 |         if (option_arg.getAsInteger(0, m_count) || (m_count < 0)) {
        |                                                     ~~~~~~~~^~~


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131983/new/

https://reviews.llvm.org/D131983

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits