[Lldb-commits] [PATCH] D130686: [LLDB][RISCV] Add DWARF Registers

Emmmer created this revision. Emmmer added reviewers: craig.topper, MaskRay, DavidSpickett, labath. Emmmer added a project: LLDB. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, JDevlieghere, s.egerton, Jim, ben

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta created this revision. thieta added reviewers: mehdi_amini, jyknight, jhenderson, hans, tstellar, cor3ntin, MaskRay. Herald added subscribers: ayermolo, StephenFan, mgorny. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added a proj

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

mehdi_amini added a comment. Herald added a subscriber: JDevlieghere. Nice, LGTM, thanks for driving this! > Remember that if we want to adopt some new feature in a bigger way it should > be discussed and added to the CodingStandard document. What does it mean exactly? We can't use **anything**

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684330 , @mehdi_amini wrote: > What does it mean exactly? We can't use **anything** C++17 without writing it > in the coding standards? > I'm not sure it'll be manageable: how do you see this playing out? Probably po

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

ChuanqiXu added a comment. In D130689#3684333 , @thieta wrote: > In D130689#3684330 , @mehdi_amini > wrote: > >> What does it mean exactly? We can't use **anything** C++17 without writing >> it in the coding sta

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. In D130689#3684330 , @mehdi_amini wrote: > Nice, LGTM, thanks for driving this! > >> Remember that if we want to adopt some new feature in a b

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

BertalanD added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:79-80 set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -std=c++0x") # Test for libstdc++ version of at least 4.8 by checking for _ZNKSt17bad_function_call4whatEv. # Note: W

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

mehdi_amini added a comment. In D130689#3684333 , @thieta wrote: > In D130689#3684330 , @mehdi_amini > wrote: > >> What does it mean exactly? We can't use **anything** C++17 without writing >> it in the coding s

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

barannikov88 added a comment. There are a few places (primarily in ADT and Support) that check __cplusplus > 201402. Do they need to be cleaned up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 ___

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 448261. thieta added a comment. Address some old comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files: bolt/runtime/CMakeLists.txt clang/CMakeLists.txt

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684360 , @barannikov88 wrote: > There are a few places (primarily in ADT and Support) that check __cplusplus > > 201402. Do they need to be cleaned up? Sounds good - but maybe that can be addressed in a separate diff

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684334 , @ChuanqiXu wrote: > So it is free that developers want to use some C++17 features in a small > amount of code, right? As soon as this land C++ 17 should be free to use everywhere yeah! Repository: rG LLVM

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 448262. thieta added a comment. Fixed unintended indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files: bolt/runtime/CMakeLists.txt clang/CMakeLists.t

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

cor3ntin accepted this revision. cor3ntin added a comment. Thanks a lot for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 ___ lldb-commits ma

[Lldb-commits] [PATCH] D130686: [LLDB][RISCV] Add DWARF Registers

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I couldn't find a definition for `Alternate Frame Return Column`. Perhaps it's this "alternate link register" I see elsewhere that's used for calling compressed code functions?

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

h-vetinari added a comment. It may be worth calling out that this is about C++17 core language and not the standard library? libstdcxx only finished C++17 support in GCC 12, and libcxx is still missing various pieces even today (much less for Clang 5). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D130686: [LLDB][RISCV] Add DWARF Registers

Emmmer updated this revision to Diff 448294. Emmmer added a comment. Add missing `Alternate Frame Return Column` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130686/new/ https://reviews.llvm.org/D130686 Files: lldb/source/Utility/RISCV_DWARF_Registers.h Index: lldb/source/Utility/R

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

hans added a comment. Here's an example where I think this regressed a Clang diagnostic. Consider: template struct Template { Template(int x) {} }; struct S1 { struct Foo; typedef Template Typedef; }; struct S2 { struct Foo; typedef Template Typedef; }; typed

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3684722 , @hans wrote: > The problem is that just based on `Template` it's not clear whether it's > `S1::Foo` or `S2::Foo` that's referred to. The logic in the diagnostic here ended up doing a silent single step desu

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3684722 , @hans wrote: > Here's an example where I think this regressed a Clang diagnostic. Consider: Consider this simple extension of this example, to show how this general problem already existed: https://godbolt.

[Lldb-commits] [PATCH] D130549: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

clayborg added a comment. In D130549#3683617 , @smeenai wrote: > In D130549#3683423 , @clayborg > wrote: > >> Ping. This was accepted before but I had Buildbot issues. Those should all >> be resolved in this upd

[Lldb-commits] [PATCH] D126359: [LLDB] Add basic floating point ops to IR interpreter

clayborg added inline comments. Comment at: lldb/test/API/lang/c/fpeval/main.c:3-4 +{ +double a = 42.0; +double b = 2.0; +return 0; Set break point at this line. labath wrote: > kpdev42 wrote: > > clayborg wrote: > > > We should be testing "float

[Lldb-commits] [PATCH] D130549: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

clayborg added a comment. FYI: I have built this on mac and on my linux machine, so I know both mac and linux build, and we know windows builds now too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130549/new/ https://reviews.llvm.org/D130549 ___

[Lldb-commits] [PATCH] D130549: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. FWIW, I've usually seen people just recommit directly instead of going through another review. Accepting this since it was already reviewed last time and the only changes are buildbot fixes.

[Lldb-commits] [lldb] 529a3d8 - [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

Author: Greg Clayton Date: 2022-07-28T13:28:26-07:00 New Revision: 529a3d87a799a2cba29bc1d0f426a00d5bb4c88f URL: https://github.com/llvm/llvm-project/commit/529a3d87a799a2cba29bc1d0f426a00d5bb4c88f DIFF: https://github.com/llvm/llvm-project/commit/529a3d87a799a2cba29bc1d0f426a00d5bb4c88f.diff

[Lldb-commits] [PATCH] D130549: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

This revision was automatically updated to reflect the committed changes. Closed by commit rG529a3d87a799: [NFC] Improve FileSpec internal APIs and usage in preparation for adding… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [lldb] dc0f452 - Cache the value for absolute path in FileSpec.

Author: Greg Clayton Date: 2022-07-28T13:31:41-07:00 New Revision: dc0f452e85e572f1e824c1eb3cdaa060d326f0c3 URL: https://github.com/llvm/llvm-project/commit/dc0f452e85e572f1e824c1eb3cdaa060d326f0c3 DIFF: https://github.com/llvm/llvm-project/commit/dc0f452e85e572f1e824c1eb3cdaa060d326f0c3.diff

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

mib marked 5 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:47-48 +if not self.target.GetExecutable() or not self.target.IsValid(): +# Return error return -

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

mib updated this revision to Diff 448434. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere feedbacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129611/new/ https://reviews.llvm.org/D129611 Files: lldb/examples/python/crashlog.py lldb/examples/

[Lldb-commits] [PATCH] D130401: Implement better path matching in FileSpecList::FindCompatibleIndex(...).

clayborg updated this revision to Diff 448436. clayborg added a comment. Revert FileSpec::GetPathSeparator() changes that are no longer needed and respond to other imrpovement feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130401/new/ htt

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon updated this revision to Diff 448453. fixathon added a comment. Added unit tests, and verified the fix is working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 Files: lldb/source/API/SBBreak

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon updated this revision to Diff 448457. fixathon added a comment. Fix duplicate name of the test function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 Files: lldb/source/API/SBBreakpointLocat

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

clayborg added a comment. Looks good. I would just inline the contents of shadowed_bkpt_locations_setters_getters_test into test_shadowed_location_getters_setters since it isn't use anywhere else. Comment at: lldb/test/API/functionalities/breakpoint/breakpoint_locations/Test

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon updated this revision to Diff 448463. fixathon added a comment. Address the review comments and inline the tests into an existing test function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 Fil

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

fixathon marked an inline comment as done. fixathon added a comment. Address the review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130660/new/ https://reviews.llvm.org/D130660 ___ lldb-commit

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:1012-1015 +def error(message, sb_error=lldb.SBError()): +nonlocal result +result.SetError(sb_error, "error: %s" % message) +return ---

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

mib updated this revision to Diff 448465. mib marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129614/new/ https://reviews.llvm.org/D129614 Files: lldb/examples/python/crashlog.py Index: lldb/examples/python/crashlog.py ==

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. As long as all values being set on the location differ from any that might be set on the breakpoint itself for any get/set tests you added this is good to go! Repository: rG LLVM Github

[Lldb-commits] [lldb] 2e6b652 - [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

Author: Slava Gurevich Date: 2022-07-28T16:08:35-07:00 New Revision: 2e6b6522296e40304ccd2766ad3233af8a0851bb URL: https://github.com/llvm/llvm-project/commit/2e6b6522296e40304ccd2766ad3233af8a0851bb DIFF: https://github.com/llvm/llvm-project/commit/2e6b6522296e40304ccd2766ad3233af8a0851bb.diff

[Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e6b6522296e: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName() (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord updated this revision to Diff 448472. bulbazord added a comment. Herald added a reviewer: shafik. - Expanded on NameMatchesLookupInfo to handle different scenarios when names we are comparing are mangled/demangled. - Extracted functionality from DWARFASTParserClang to construct a demang

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord marked 3 inline comments as done. bulbazord added inline comments. Comment at: lldb/source/Core/Module.cpp:730 +bool Module::LookupInfo::NameMatchesLookupInfo( +ConstString function_name, LanguageType language_type) const { clayborg wrote: > So th

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

Ericson2314 updated this revision to Diff 448493. Ericson2314 added a comment. Herald added a project: All. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116467/new/ https://reviews.llvm.org/D116467 Files: lld/CMakeLists.txt lldb/cmake/

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thakis added a comment. It'd be nice if this was landed opt-in behind some cmake variable at first, so that folks could try it out on their bots and see how well things work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://review

[Lldb-commits] [PATCH] D130743: [LLDB][RISCV] Add DWARF Registers

Emmmer created this revision. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, n