bulbazord marked 3 inline comments as done.
bulbazord added inline comments.
================
Comment at: lldb/source/Core/Module.cpp:730
+bool Module::LookupInfo::NameMatchesLookupInfo(
+ ConstString function_name, LanguageType language_type) const {
----------------
clayborg wrote:
> So this function can end up being called with an empty function_name when
> there is no mangled name (see comment in DWARFIndex.cpp). If there is no
> language then we return true, but what does a language plug-in do in
> DemangledNameContainsPath? The same thing?
>
> I guess this means if you lookup "foo::erase" and you get a DIE that has
> "erase" as its DW_AT_name, but the DIE has no DW_AT_mangled (yes, some C++
> debug info is emitted without a mangled name), that it will match any DIE
> that has a DW_AT_name that matches "erase" regardless of the actual decl
> context?
I moved the empty check to the top since we always want to keep unnamed
symbols.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129682/new/
https://reviews.llvm.org/D129682
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
