[Lldb-commits] [lldb] d1c124e - [lldb][ARM/AArch64] Update dissembler to v9.3-a

Author: David Spickett Date: 2022-01-28T09:10:04Z New Revision: d1c124e6e7006ff5597981f8adcb48b2e26b110d URL: https://github.com/llvm/llvm-project/commit/d1c124e6e7006ff5597981f8adcb48b2e26b110d DIFF: https://github.com/llvm/llvm-project/commit/d1c124e6e7006ff5597981f8adcb48b2e26b110d.diff LOG

[Lldb-commits] [PATCH] D118358: [lldb][ARM/AArch64] Update dissembler to v9.3-a

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1c124e6e700: [lldb][ARM/AArch64] Update dissembler to v9.3-a (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118358/new/ https:/

[Lldb-commits] [lldb] 59a3f65 - Revert "[lldb] [gdb-remote] Support getting siginfo via API"

Author: Michał Górny Date: 2022-01-28T10:15:52+01:00 New Revision: 59a3f65f5ed6b25b584d504fe4cf8473d4029ff3 URL: https://github.com/llvm/llvm-project/commit/59a3f65f5ed6b25b584d504fe4cf8473d4029ff3 DIFF: https://github.com/llvm/llvm-project/commit/59a3f65f5ed6b25b584d504fe4cf8473d4029ff3.diff

[Lldb-commits] [lldb] 2d75f62 - [lldb] Convert DWARF log to the new API

Author: Pavel Labath Date: 2022-01-28T10:41:10+01:00 New Revision: 2d75f627221e434c9ff64cdd2c47da9dcb437967 URL: https://github.com/llvm/llvm-project/commit/2d75f627221e434c9ff64cdd2c47da9dcb437967 DIFF: https://github.com/llvm/llvm-project/commit/2d75f627221e434c9ff64cdd2c47da9dcb437967.diff

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

mgorny updated this revision to Diff 403948. mgorny added a comment. Add `Thread::GetSiginfoValue()` to perform baseline value construction, and limit `SBThread::GetSiginfo()` to wrapping that. Return errors via `ValueObjectConstResult`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D118473: [lldb] [Commands] Implement "thread siginfo"

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. https://reviews.llvm.org/D118473 Files: lldb/source/Commands/CommandObjectThread.cpp lldb/test/Shell/Commands/Inputs/sigchld.c lldb/test/Shell/Commands/command-thread

[Lldb-commits] [lldb] b414954 - [lldb] Make ReadCStringFromMemory default to read from the file-cache.

Author: Augusto Noronha Date: 2022-01-28T13:08:30-03:00 New Revision: b414954a5f1c2f8f6adecf20e5a433dfbc320cc2 URL: https://github.com/llvm/llvm-project/commit/b414954a5f1c2f8f6adecf20e5a433dfbc320cc2 DIFF: https://github.com/llvm/llvm-project/commit/b414954a5f1c2f8f6adecf20e5a433dfbc320cc2.dif

[Lldb-commits] [PATCH] D118265: [lldb] Make ReadCStringFromMemory default to read from the file-cache.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb414954a5f1c: [lldb] Make ReadCStringFromMemory default to read from the file-cache. (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Thanks for making that change! LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118055/new/ https://reviews.llvm.org/D118055 ___ lld

[Lldb-commits] [PATCH] D118482: [lldb/Plugins] Add ScriptedProcessInterface::GetSelectedThreadIndex method

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a subscriber: arphaman. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds a new method to the Scripted Process Interface to fetch the index to the th

[Lldb-commits] [lldb] ac666d1 - [lldb] [gdb-remote] Support getting siginfo via API

Author: Michał Górny Date: 2022-01-28T17:47:47+01:00 New Revision: ac666d1799c45a1ecd59f7503e1fc649deffd4d4 URL: https://github.com/llvm/llvm-project/commit/ac666d1799c45a1ecd59f7503e1fc649deffd4d4 DIFF: https://github.com/llvm/llvm-project/commit/ac666d1799c45a1ecd59f7503e1fc649deffd4d4.diff

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

paolosev added a comment. Thanks @xujuntwt95329! I am very happy that this was useful for WebAssembly Micro Runtime! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78801/new/ https://reviews.llvm.org/D78801

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

This revision was automatically updated to reflect the committed changes. Closed by commit rGac666d1799c4: [lldb] [gdb-remote] Support getting siginfo via API (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118055/new/ https://re

[Lldb-commits] [PATCH] D118482: [lldb/Plugins] Add ScriptedProcessInterface::GetSelectedThreadIndex method

jingham added a comment. This seems wrong to me. Normal Processes don't get to choose which thread the generic "which stop event is most important" logic selects, they just report the stop events and then the higher level logic decides which one to select. It seems more symmetric to have the

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch fixes a timeout issue on the ScriptedProcess test that was happening on intel platforms. The timeout was due to a mis

[Lldb-commits] [PATCH] D118482: [lldb/Plugins] Add ScriptedProcessInterface::GetSelectedThreadIndex method

mib added a comment. In D118482#3279843 , @jingham wrote: > This seems wrong to me. Normal Processes don't get to choose which thread > the generic "which stop event is most important" logic selects, they just > report the stop events and then the high

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

stella.stamenova updated this revision to Diff 404065. stella.stamenova added a comment. Add more details for developer command prompt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118425/new/ https://reviews.llvm.org/D118425 Files: lldb/docs/resources/build.rst Index: lldb/docs/re

[Lldb-commits] [PATCH] D118482: [lldb/Plugins] Add ScriptedProcessInterface::GetSelectedThreadIndex method

jingham added a comment. My preference for things like crash reports would be that you make up a stop reason that's significant for the thread(s) you think are interesting and then let lldb figure out how to display them. After all, if you set a selected thread w/o having a StopInfo that would

[Lldb-commits] [PATCH] D118482: [lldb/Plugins] Add ScriptedProcessInterface::GetSelectedThreadIndex method

mib updated this revision to Diff 404068. mib added a reviewer: jingham. mib added a comment. Address @jingham concerns by making this fully optional: - Change python default value to 0. Thread indices in lldb are 1-based, so 0 sounds like a good error_value. - Check for python returned integer

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

JDevlieghere accepted this revision. JDevlieghere added a comment. Nice. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118425/new/ https://reviews.llvm.org/D118425 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D118482: [lldb/Plugins] Add ScriptedProcessInterface::GetSelectedThreadIndex method

shafik added a comment. Just nitpicks Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:362 // previous thread state (if any). + uint32_t selected_thread_index = GetInterface().GetSelectedThreadIndex(); + `const` Commen

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019 Win64" -Thost=x64 This line should change a bit more. For VS2019, it also nee

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 403924. RKSimon added a comment. update lldb cmake command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/doc

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019" -A x64 -T host=x64 -Thost=x64 You accidentally added `-T host=x64` twice now

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 404076. RKSimon added a comment. fix cut+paste typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Users

[Lldb-commits] [lldb] 738d73f - [lldb] Update the lldb build instructions on Windows

Author: Stella Stamenova Date: 2022-01-28T10:18:19-08:00 New Revision: 738d73fbf4edc1ae4e6fc2e40f734df267420420 URL: https://github.com/llvm/llvm-project/commit/738d73fbf4edc1ae4e6fc2e40f734df267420420 DIFF: https://github.com/llvm/llvm-project/commit/738d73fbf4edc1ae4e6fc2e40f734df267420420.di

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG738d73fbf4ed: [lldb] Update the lldb build instructions on Windows (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118425/new/

[Lldb-commits] [PATCH] D118494: [lldb] Observe SG_READ_ONLY flag in MachO binaries

kastiglione created this revision. kastiglione added reviewers: aprantl, augusto2112. kastiglione requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Change `Section::GetPermissions()` to indicate non-writability when the Mach

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

JDevlieghere added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_process.py:323-344 +{'name': 'rax', 'bitsize': 64, 'offset': 0, 'encoding': 'uint', 'format': 'hex', 'set': 0, 'gcc': 0, 'dwarf': 0}, +{'name':

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/test/API/functionalities/scripted_process/invalid_scripted_process.py:57 return { "type": lldb.eStopReasonSignal, "data": { -"signal": signal.SIGINT +"signal": sign

[Lldb-commits] [PATCH] D118482: [lldb/Plugins] Add ScriptedProcessInterface::GetSelectedThreadIndex method

mib updated this revision to Diff 404107. mib marked 2 inline comments as done. mib added a comment. Address @shafik feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118482/new/ https://reviews.llvm.org/D118482 Files: lldb/examples/python/

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

mib updated this revision to Diff 404117. mib marked 3 inline comments as done. mib added a comment. Address @JDevlieghere comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118484/new/ https://reviews.llvm.org/D118484 Files: lldb/examples/python/scripted_process/scripted_process

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

mib updated this revision to Diff 404128. mib added a comment. Re-enabling a test function for intel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118484/new/ https://reviews.llvm.org/D118484 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/test/API/functional

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the test comment. Comment at: lldb/examples/python/scripted_process/scripted_process.py:338 + +ARM64_GPR = [ {'name': 'x0', 'bitsize': 64, 'offset':

[Lldb-commits] [PATCH] D118494: [lldb] Observe SG_READ_ONLY flag in MachO binaries

augusto2112 requested changes to this revision. augusto2112 added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1436 result |= ePermissionsReadable; - if (seg_cmd.initprot & VM_PROT_WRIT

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

mib updated this revision to Diff 404142. mib marked 2 inline comments as done. mib added a comment. Add stop reason type test and comment explaining why it's different depending on the architecture. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118484/new/ https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

mib updated this revision to Diff 404147. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118484/new/ https://reviews.llvm.org/D118484 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py lldb/test/API/

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

mib added a subscriber: jingham. mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_process.py:338 + +ARM64_GPR = [ {'name': 'x0', 'bitsize': 64, 'offset': 0, 'encoding': 'uint', 'format': 'hex', 'set': 0, 'gcc': 0, 'dwarf': 0, 'generic':

[Lldb-commits] [PATCH] D118513: [lldb/test] Split Scripted Process test in multiple tests (NFC)

mib created this revision. mib added reviewers: aprantl, JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This splits the scripted process tests to be able to run in parallel since some of test functions can take a very long t

[Lldb-commits] [PATCH] D118494: [lldb] Observe SG_READ_ONLY flag in MachO binaries

kastiglione added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1436 result |= ePermissionsReadable; - if (seg_cmd.initprot & VM_PROT_WRITE) + if ((seg_cmd.initprot & VM_PROT_WRITE) && !(seg_cmd.flags & SG_READ_ONLY)) result |=

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

xujuntwt95329 added a comment. In D78801#3279811 , @paolosev wrote: > Thanks @xujuntwt95329! I am very happy that this was useful for WebAssembly > Micro Runtime! I believe we are making the world of WebAssembly better! BTW, I find an issue when trying