[Lldb-commits] [PATCH] D106226: [lldb] Improve error message when "lldb attach" fails

DavidSpickett added a comment. Thanks for looking at this, I've been tripped up by this myself. > Is AppendMessage() really the right function to use in an error scenario ? or > the additional message should just be appended to AppendErrorWithFormat() ? It changes whether the output goes to std

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

DavidSpickett added a comment. > This doesn't support remote files yet, I am still having trouble testing > those. If you want to set that up we have some docs for it: https://lldb.llvm.org/use/remote.html https://lldb.llvm.org/use/qemu-testing.html This is mostly how I work on AArch64 changes.

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

mib commandeered this revision. mib edited reviewers, added: omjavaid; removed: mib. mib added a comment. Hello @omjavaid, apologies for only looking at this now but I was on vacation last week. This changes make sense but I'd rather conform to the Python interface types. Also, I'm still working

[Lldb-commits] [PATCH] D106263: [lldb] Make WatchpointList iterable

mgorny created this revision. mgorny added reviewers: JDevlieghere, jingham. mgorny requested review of this revision. Based on de448c0a9e5088979526e2e67152fe547ae4ccf0 . https://reviews.llvm.org/D106263 Files: lldb/include

[Lldb-commits] [PATCH] D106263: [lldb] Make WatchpointList iterable

mgorny added inline comments. Comment at: lldb/include/lldb/Breakpoint/WatchpointList.h:193 + WatchpointIterable Watchpoints() const { +return WatchpointIterable(m_watchpoints, m_mutex); NB: I needed to make a `const` variant since it's used in some `const

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:5504-5513 + WatchpointList &wps = GetTarget().GetWatchpointList(); + size_t wp_count = wps.GetSize(); + for (size_t i = 0; i < wp_count; ++i) { +WatchpointSP wp = wps.Get

[Lldb-commits] [PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna created this revision. Topotuna added a reviewer: Anastasia. Herald added subscribers: jeroen.dobbelaere, ldrumm, dexonsmith, dang, yaxunl. Topotuna requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. The commit renam

[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

kimanh created this revision. Herald added a subscriber: arphaman. kimanh added a subscriber: pfaffe. kimanh edited the summary of this revision. kimanh added a reviewer: labath. kimanh published this revision for review. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When

[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:82 + const DWARFUnit &non_skeleton_cu = cu.GetNonSkeletonUnit(); DWARFMappedHash::DIEInfoArray hash_data; I assume the `const` of the `DWARFUnit` is bei

[Lldb-commits] [PATCH] D106263: [lldb] Make WatchpointList iterable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Comment at: lldb/include/lldb/Breakpoint/WatchpointList.h:193 + WatchpointIterable Watchpoints() const { +return WatchpointIterable(m_watchpo

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 updated this revision to Diff 359848. jj10306 retitled this revision from "[trace] Add `thread trace dump ctf -f ` command" to "[trace] Add `thread trace export` command for Intel PT trace visualization". jj10306 edited the summary of this revision. jj10306 added a comment. - Add HTR doc

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 marked 19 inline comments as done. jj10306 added inline comments. Comment at: lldb/docs/htr.rst:1 +Hierarchical Trace Representation (HTR) +== @clayborg @wallace Is there a way to view the "rendered" rst to ensure the t

[Lldb-commits] [lldb] 2656af9 - Don't use !eStateRunning when you mean eStateStopped in DestroyImpl.

Author: Jim Ingham Date: 2021-07-19T14:30:04-07:00 New Revision: 2656af95eb8e67364db7b8dc4a95c3b65c286b2d URL: https://github.com/llvm/llvm-project/commit/2656af95eb8e67364db7b8dc4a95c3b65c286b2d DIFF: https://github.com/llvm/llvm-project/commit/2656af95eb8e67364db7b8dc4a95c3b65c286b2d.diff LO

[Lldb-commits] [PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Anastasia added inline comments. Comment at: clang/include/clang/Basic/LangStandards.def:187 Digraphs | HexFloat | OpenCL) +LANGSTANDARD_ALIAS_DEPR(openclcpp10, "clc++") I am not sure we should move it into the deprecated category yet... for now

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:113 Optional raw_size = GetRawTraceSize(thread); - s.Printf("Tracing technology: %s\nthread #%u: tid = %" PRIu64, plugin_name.AsCString(), thread.GetIndexID(), thread.GetID()); +

[Lldb-commits] [PATCH] D106328: [trace][intel pt] Add TSC timestamps

wallace created this revision. Herald added a subscriber: dang. wallace updated this revision to Diff 359972. wallace added a comment. wallace updated this revision to Diff 359973. wallace retitled this revision from "[intel pt] Add TSC timestamps" to "[trace][intel pt] Add TSC timestamps". wallac

[Lldb-commits] [PATCH] D106328: [trace][intel pt] Add TSC timestamps

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Herald added a subscriber: JDevlieghere. Man cases of having variables named "tsc" or "m_tsc" when it might be clear to have them named "enable_tsc" and "m_enable_tsc". ===

[Lldb-commits] [PATCH] D105717: [trace] [intel pt] Create a "thread trace dump stats" command

hanbingwang updated this revision to Diff 359994. hanbingwang added a comment. {F18030885 }add two spaces before the string "Raw trace size : xxx"; add new line between each thread. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105717/new/ https://re

[Lldb-commits] [PATCH] D106324: Remove debugserver support for the DarwinLog StructuredData streaming service, lldb tests for it

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106324/new/ https://reviews.llvm.org/D106324 ___

[Lldb-commits] [lldb] 7b54b1c - [lldb] Make WatchpointList iterable

Author: Michał Górny Date: 2021-07-20T07:47:48+02:00 New Revision: 7b54b1cdafbcaa5721bcf8ae78e8390a74d580bf URL: https://github.com/llvm/llvm-project/commit/7b54b1cdafbcaa5721bcf8ae78e8390a74d580bf DIFF: https://github.com/llvm/llvm-project/commit/7b54b1cdafbcaa5721bcf8ae78e8390a74d580bf.diff

[Lldb-commits] [PATCH] D106263: [lldb] Make WatchpointList iterable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b54b1cdafbc: [lldb] Make WatchpointList iterable (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D106270: [DWARF5] Fix offset check when using .debug_names

kimanh added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:82 + const DWARFUnit &non_skeleton_cu = cu.GetNonSkeletonUnit(); DWARFMappedHash::DIEInfoArray hash_data; JDevlieghere wrote: > I assume the `const` of the `D