mib commandeered this revision.
mib edited reviewers, added: omjavaid; removed: mib.
mib added a comment.
Hello @omjavaid, apologies for only looking at this now but I was on vacation
last week. This changes make sense but I'd rather conform to the Python
interface types. Also, I'm still working on `Scripted Processes` and I'm
planning to land a patch with these changes soon. Thanks for letting me know
about this oversight.
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp:175
if (py_return.get()) {
auto size = py_return.AsUnsignedLongLong();
+ return (size) ? *size : gen_int_val;
----------------
I'd use to `unsigned long long` to match the interface.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105788/new/
https://reviews.llvm.org/D105788
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
