[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104067/new/ https://reviews.llvm.org/D104067

[Lldb-commits] [lldb] 35cf5b1 - [lldb] Bumb Clang version requirement for TestBasicEntryValues.py to 11

Author: Raphael Isemann Date: 2021-06-22T11:58:05+02:00 New Revision: 35cf5b109769ceb356a9013ca0c0f60fbd230080 URL: https://github.com/llvm/llvm-project/commit/35cf5b109769ceb356a9013ca0c0f60fbd230080 DIFF: https://github.com/llvm/llvm-project/commit/35cf5b109769ceb356a9013ca0c0f60fbd230080.dif

[Lldb-commits] [lldb] 98e2b1a - [lldb] Adjust Clang version requirements for tail_call_frames tests

Author: Raphael Isemann Date: 2021-06-22T12:22:15+02:00 New Revision: 98e2b1a8dd8ff03b6289a40a16fe749834257494 URL: https://github.com/llvm/llvm-project/commit/98e2b1a8dd8ff03b6289a40a16fe749834257494 DIFF: https://github.com/llvm/llvm-project/commit/98e2b1a8dd8ff03b6289a40a16fe749834257494.dif

[Lldb-commits] [PATCH] D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed)

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Mostly by converting uses of GetErrorStream to AppendError, so that the call to SetStatus is implicit. Some remain where it isn't certain th

[Lldb-commits] [PATCH] D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed)

teemperor accepted this revision. teemperor added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:141 static void SetError(CommandReturnObject &result, Error err) { - result.GetErrorStream().Printf("

[Lldb-commits] [PATCH] D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed)

DavidSpickett updated this revision to Diff 353598. DavidSpickett added a comment. Remove c_str() in Reproducer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104697/new/ https://reviews.llvm.org/D104697 Files: lldb/source/Commands/CommandObject

[Lldb-commits] [lldb] 28058d4 - [LLDB] Skip TestExitDuringExpression on aarch64/linux buildbot

Author: Muhammad Omair Javaid Date: 2021-06-22T16:22:48+05:00 New Revision: 28058d4cd10dac8129a5d5760597e832ea6eef81 URL: https://github.com/llvm/llvm-project/commit/28058d4cd10dac8129a5d5760597e832ea6eef81 DIFF: https://github.com/llvm/llvm-project/commit/28058d4cd10dac8129a5d5760597e832ea6eef

[Lldb-commits] [lldb] c462048 - [lldb][NFC] Use SubsystemRAII in XcodeSDKModuleTests

Author: Raphael Isemann Date: 2021-06-22T13:41:01+02:00 New Revision: c462048cc4c088f6d12e6a55c1ceb54fd731a2b3 URL: https://github.com/llvm/llvm-project/commit/c462048cc4c088f6d12e6a55c1ceb54fd731a2b3 DIFF: https://github.com/llvm/llvm-project/commit/c462048cc4c088f6d12e6a55c1ceb54fd731a2b3.dif

[Lldb-commits] [lldb] 48e2d3a - [lldb][NFC] Remove an outdated comment in HostInfoBase

Author: Raphael Isemann Date: 2021-06-22T16:48:17+02:00 New Revision: 48e2d3a5c23f7a11972c30f92d48d85a6a6bf1bd URL: https://github.com/llvm/llvm-project/commit/48e2d3a5c23f7a11972c30f92d48d85a6a6bf1bd DIFF: https://github.com/llvm/llvm-project/commit/48e2d3a5c23f7a11972c30f92d48d85a6a6bf1bd.dif

[Lldb-commits] [PATCH] D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8dd7094d364: [lldb] Remove more redundant SetStatus(eReturnStatusFailed) (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [lldb] a8dd709 - [lldb] Remove more redundant SetStatus(eReturnStatusFailed)

Author: David Spickett Date: 2021-06-22T15:28:28Z New Revision: a8dd7094d364f6fb4921627a36b920e5098e88c3 URL: https://github.com/llvm/llvm-project/commit/a8dd7094d364f6fb4921627a36b920e5098e88c3 DIFF: https://github.com/llvm/llvm-project/commit/a8dd7094d364f6fb4921627a36b920e5098e88c3.diff LOG

[Lldb-commits] [PATCH] D104404: Change PathMappingList::RemapPath to return an optional result (NFC)

aprantl added inline comments. Comment at: lldb/source/Core/Module.cpp:1604 bool Module::RemapSourceFile(llvm::StringRef path, std::string &new_path) const { shafik wrote: > Why not also have this return an `Optional`? That would

[Lldb-commits] [PATCH] D104724: Modernize Module::RemapFile to return an Optional

aprantl created this revision. aprantl added reviewers: shafik, JDevlieghere. aprantl requested review of this revision. This addresses feedback raised in https://reviews.llvm.org/D104404. https://reviews.llvm.org/D104724 Files: lldb/include/lldb/Core/Module.h lldb/source/Core/Module.cpp

[Lldb-commits] [PATCH] D104405: Change PathMappingList::FindFile to return an optional result (NFC)

aprantl updated this revision to Diff 353700. aprantl added a comment. Update to the correct patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104405/new/ https://reviews.llvm.org/D104405 Files: lldb/include/lldb/Target/PathMappingList.h lldb/source/Core/Module.cpp lldb/source/

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

jingham added a comment. Some comments on comments... Comment at: lldb/include/lldb/Symbol/Symtab.h:224 + /// + /// We started not always generating symbol names for synthetic symbols and + /// we want to be able to lookup synthetic symbols by name when needed. This

[Lldb-commits] [lldb] 709f818 - [lldb] Add missing string include to lldb-server's main

Author: Raphael Isemann Date: 2021-06-22T19:49:10+02:00 New Revision: 709f8186a45e28c0640c999a8b779433dc0eb525 URL: https://github.com/llvm/llvm-project/commit/709f8186a45e28c0640c999a8b779433dc0eb525 DIFF: https://github.com/llvm/llvm-project/commit/709f8186a45e28c0640c999a8b779433dc0eb525.dif

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg updated this revision to Diff 353715. clayborg added a comment. Fixed comments per Jim Ingham's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/ https://reviews.llvm.org/D104488 Files: lldb/include/lldb/Symbol/ObjectF

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

jingham added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/ https://reviews.llvm.org/D104488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg added a comment. Anyone have any other comments? Or is this good to go? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/ https://reviews.llvm.org/D104488 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 353783. OmarEmaraDev added a comment. - Remove Field type and use FieldDelegate directly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D104395 Files: lldb/source/Cor

[Lldb-commits] [PATCH] D104404: Change PathMappingList::RemapPath to return an optional result (NFC)

aprantl added a comment. Patch for `Module` is in https://reviews.llvm.org/D104724. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104404/new/ https://reviews.llvm.org/D104404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://l

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg added a comment. Just a few questions on how buttons should be handled since we are making new sweeping changes! See inlined comments and let me know what you think Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1396-1405 + // ___

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

rupprecht added a comment. In D102993#2811902 , @rupprecht wrote: > In D102993#2811337 , @teemperor > wrote: > >> Sure I can take a look, but I don't see the immediate problem when looking >> at the backtrace. >