[Lldb-commits] [PATCH] D104404: Change PathMappingList::RemapPath to return an optional result (NFC)

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Core/Module.cpp:1604
 
 bool Module::RemapSourceFile(llvm::StringRef path,
                              std::string &new_path) const {
----------------
shafik wrote:
> Why not also have this return an `Optional`?
That would be perfectly reasonable. I'll add a review for that patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104404/new/

https://reviews.llvm.org/D104404

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits