[Lldb-commits] [PATCH] D100554: [lldb] [Process/NetBSD] Report fork/vfork events to LLGS

2021-04-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 340251. mgorny added a comment. Synced to the Linux plugin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100554/new/ https://reviews.llvm.org/D100554 Files: lldb/packages/Python/lldbsuite/test/dotest.py lldb/source/Plugins/Process/NetBSD/Native

[Lldb-commits] [lldb] 6c37984 - [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork

2021-04-24 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-04-24T11:08:33+02:00 New Revision: 6c37984ebaf4ee01df6a9b3f78e45f70dcd6fb33 URL: https://github.com/llvm/llvm-project/commit/6c37984ebaf4ee01df6a9b3f78e45f70dcd6fb33 DIFF: https://github.com/llvm/llvm-project/commit/6c37984ebaf4ee01df6a9b3f78e45f70dcd6fb33.diff

[Lldb-commits] [lldb] 3122576 - [lldb] [Process] Introduce protocol extension support API

2021-04-24 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-04-24T11:08:33+02:00 New Revision: 312257688eb0c09a8e6915ced2acdf0bcbbad353 URL: https://github.com/llvm/llvm-project/commit/312257688eb0c09a8e6915ced2acdf0bcbbad353 DIFF: https://github.com/llvm/llvm-project/commit/312257688eb0c09a8e6915ced2acdf0bcbbad353.diff

[Lldb-commits] [lldb] fd0af0c - [lldb] [Process/Linux] Report fork/vfork stop reason

2021-04-24 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-04-24T11:08:34+02:00 New Revision: fd0af0cf08284de79fe1a5bcfdc2dad83794dcfe URL: https://github.com/llvm/llvm-project/commit/fd0af0cf08284de79fe1a5bcfdc2dad83794dcfe DIFF: https://github.com/llvm/llvm-project/commit/fd0af0cf08284de79fe1a5bcfdc2dad83794dcfe.diff

[Lldb-commits] [lldb] bbae0c1 - [lldb] [llgs] Support owning and detaching extra processes

2021-04-24 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-04-24T11:08:33+02:00 New Revision: bbae0c1f7b4f60e9b8ac2be24e35bec79d9b7b01 URL: https://github.com/llvm/llvm-project/commit/bbae0c1f7b4f60e9b8ac2be24e35bec79d9b7b01 DIFF: https://github.com/llvm/llvm-project/commit/bbae0c1f7b4f60e9b8ac2be24e35bec79d9b7b01.diff

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

2021-04-24 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG312257688eb0: [lldb] [Process] Introduce protocol extension support API (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D100196: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork

2021-04-24 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c37984ebaf4: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork (authored by mgorny). Herald added a project: LLDB. Repositor

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

2021-04-24 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbae0c1f7b4f: [lldb] [llgs] Support owning and detaching extra processes (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM G

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

2021-04-24 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd0af0cf0828: [lldb] [Process/Linux] Report fork/vfork stop reason (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D100206: [lldb] [llgs client] Support minimal fork/vfork handling

2021-04-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 340286. mgorny added a comment. Merged D100541 and client fork/vfork stop infos from D100208 into this one. Included `fork-events+` and `vfork-events+` in client qSupported. In other words

[Lldb-commits] [PATCH] D100541: [lldb] [gdb-remote client] Support detaching by PID

2021-04-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny abandoned this revision. mgorny added a comment. Merged into D100206 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100541/new/ https://reviews.llvm.org/D100541 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D100206: [lldb] [llgs client] Support minimal fork/vfork handling

2021-04-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. @labath, now's a curious problem I've seen very rarely (I mean, 1 out of 150 attempts or so): 1: (lldb) command source -s 0 '/home/mgorny/git/llvm-project/build.gentoo/tools/lldb/test/Shell/lit-lldb-init' 2: Executing commands in '/home/mgorny/git/llvm-project/b

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

2021-04-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil created this revision. jankratochvil added reviewers: dblaikie, labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. libstc++ 11 started using `[[no_unique_address]]` which crashes LLDB: ec

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

2021-04-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:103 + // GCC 11 std::default_delete<...> has existing child with GetByteSize()==1. + if (tuple_sp->GetByteSize() > ptr_obj->GetByteSize()) { +ValueObjectSP de

[Lldb-commits] [PATCH] D100206: [lldb] [llgs client] Support minimal fork/vfork handling

2021-04-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 340296. mgorny added a comment. Add gdb_remote_client tests for fork/vfork stop reason handling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100206/new/ https://reviews.llvm.org/D100206 Files: lldb/include/lldb/Target/Process.h lldb/include/ll

[Lldb-commits] [PATCH] D100261: [lldb] [gdb-remote server] Support selecting process via Hg

2021-04-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 340310. mgorny added a comment. Add tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100261/new/ https://reviews.llvm.org/D100261 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp lldb/test/API/tools/lldb-ser

[Lldb-commits] [PATCH] D100931: Set binaries-loaded/unloaded breakpoint on a name, not an address on macOS

2021-04-24 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. Jim whispered to me that he thinks this patch is awesome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100931/new/ https://reviews.llvm.org/D100931 ___ lldb-commits mailing

[Lldb-commits] [lldb] 6fca189 - Simplify the breakpoint setting in DynamicLoaderMacOS::SetNotificationBreakpoint

2021-04-24 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2021-04-24T14:03:41-07:00 New Revision: 6fca189532511da1b48e8c0d9aad8ff2edca382d URL: https://github.com/llvm/llvm-project/commit/6fca189532511da1b48e8c0d9aad8ff2edca382d DIFF: https://github.com/llvm/llvm-project/commit/6fca189532511da1b48e8c0d9aad8ff2edca382d.diff

[Lldb-commits] [PATCH] D100931: Set binaries-loaded/unloaded breakpoint on a name, not an address on macOS

2021-04-24 Thread Jason Molenda via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6fca18953251: Simplify the breakpoint setting in DynamicLoaderMacO

[Lldb-commits] [PATCH] D101241: [lldb] [llgs] Report QPassSignals and qXfer via extensions API

2021-04-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: krytarowski, emaste, labath. mgorny requested review of this revision. Remove hardcoded platform list for QPassSignals, qXfer:auxv:read and qXfer:libraries-svr4:read and instead query the process plugin via the GetSupportedExtensions() API. h

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

2021-04-24 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a subscriber: aprantl. dblaikie added a comment. > As DWARF does not contain the [[no_unique_address]] attribute the patch adds > it to every record member, could it be a problem? Given that no_unique_address changes the layout of data structures ( https://clang.llvm.org/docs/Att

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

2021-04-24 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. In D101237#2714953 , @dblaikie wrote: > Given that no_unique_address changes the layout of data structures ( > https://clang.llvm.org/docs/AttributeReference.html#no-unique-address ) > adding it to a member that doesn't ac

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

2021-04-24 Thread David Blaikie via Phabricator via lldb-commits
dblaikie added a comment. In D101237#2714962 , @jankratochvil wrote: > In D101237#2714953 , @dblaikie > wrote: > >> Given that no_unique_address changes the layout of data structures ( >> https://clang.llvm.org

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

2021-04-24 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. grep tells me that attribute also influences a bunch of other things in subtle ways (It seems to potentially influence ABIs and Obj-C encodings?) and we don't really know what other things this might influence in the future. So I have the suspicion that putting that a