teemperor added a comment. grep tells me that attribute also influences a bunch of other things in subtle ways (It seems to potentially influence ABIs and Obj-C encodings?) and we don't really know what other things this might influence in the future. So I have the suspicion that putting that attr on all record fields might break something in a subtle way.
In any case, what LLDB is usually doing is these situations is inferring from the existing debug information. I assume by looking at the `DW_AT_data_member_locations` values we could determine what the no_unique_address fields are in our record (and then only put the attributes on that)? Not sure what all the corner cases are but the ones I checked (e.g., two empty record fields with only one having the attr at start/end/middle) are surprisingly not ambiguous. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101237/new/ https://reviews.llvm.org/D101237 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
