[Lldb-commits] [PATCH] D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC)

teemperor added inline comments. Comment at: lldb/include/lldb/Symbol/CompilerDeclContext.h:77 /// in a struct, union or class. - bool IsClassMethod(lldb::LanguageType *language_ptr, - bool *is_instance_method_ptr, - ConstString *la

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. In D98179#2626179 , @davezarzycki wrote: > Might somebody be willing to sign off on this change (this week or next)? I'd > like to cherry-pick

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki updated this revision to Diff 330907. davezarzycki added a comment. Removed the commented only-failures and fixed a nit before committing. Thanks everybody for the various rounds of feedback. I'm quite happy with how this turned out. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. That implies a different testing environment. How different is the Windows testing environment compared to Unix? Do you specifically have a custom testing setup? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98179/new

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d297f90649d: [lit] Sort test start times based on prior test timing data (authored by davezarzycki). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. Said differently, the Unix side seems to always run the lit tests from a fresh/clean setup, even for incremental builds. If Windows tests lit differently then ya, things will blow up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. Try: 49d0e115d5df40aa89339f4ace7a8dee378c03bb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98179/new/ https://reviews.llvm.org/D98179 ___

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

jmorse added a comment. Hi, I'm experiencing reorder.py failing intermittently on a Windows system -- it seems to pick up the .lit_test_times.txt produced in the build directory for the Inputs tests after the first run, and use that for ordering. And seeing how that just contains noise, the In

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

jmorse added a comment. It turns out there's a plain old windows-has-different-slashes problem going on. In the Test object __init__ method, the call to `os.sep.join` in this patch produces the string "subdir\ccc.txt", which won't match "subdir/ccc.txt" that you load from the the .lit_test_time

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 330994. DavidSpickett added a comment. Account for a ranges being split across multiple mappings that are next to each other. (tested in the tag read command patch) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/Process.h:2749 + /// Check whether the remote supports memory tagging. + /// omjavaid wrote: > By remote you mean gdb-remote process? Thi

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 330996. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. Correct typo in function comment. "to read tags for" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/ https:/

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

DavidSpickett updated this revision to Diff 330998. DavidSpickett added a comment. Expand test to check that we can read tags for a range that spans two mappings. This covers updated code in GetMemoryTagManager. Refactor the test file a bit to account for the extra mmap. I've tested the mmap seq

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett updated this revision to Diff 331003. DavidSpickett marked 3 inline comments as done. DavidSpickett added a comment. - Remove extra newline after test decorator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95601/new/ https://reviews.

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

amccarth added a comment. This workaround seems consistent with other overrides of FixCodeAddress, my only concern is about the assumption of the number of bits that need to be preserved/stripped. I hope @jasonmolenda gets a chance to chime in. Comment at: lldb/source/Plugin

[Lldb-commits] [PATCH] D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC)

kastiglione added inline comments. Comment at: lldb/include/lldb/Symbol/CompilerDeclContext.h:77 /// in a struct, union or class. - bool IsClassMethod(lldb::LanguageType *language_ptr, - bool *is_instance_method_ptr, - ConstString *

[Lldb-commits] [PATCH] D98653: [lldb] Refactor variable paths to support languages with non-pointer "this" (NFC)

jingham added inline comments. Comment at: lldb/include/lldb/Symbol/CompilerDeclContext.h:77 /// in a struct, union or class. - bool IsClassMethod(lldb::LanguageType *language_ptr, - bool *is_instance_method_ptr, - ConstString *lang

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

jasonmolenda added a comment. Sorry for not replying to this earlier. Yeah, correct number of bits to mask off must be determined dynamically at runtime, by looking at the CPU's TCR_EL0.T0SZ value (or TCR_EL1.T0SZ for EL1 code like a kernel), which is the inverse of the number of bits used for

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

justincohen added a comment. How does this work for a core dump? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98529/new/ https://reviews.llvm.org/D98529 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

jasonmolenda added a comment. I added a Mach-O LC_NOTE which allows us to encode the number of bits used in addressing: (I really need to create a docs/lc-notes.md to document these) "addrable bits" LC_NOTE "addrable bits" (number of bits used for addressing) data payload is a structure: stru

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

jankratochvil added a comment. Based on https://reviews.llvm.org/D92643#inline-925368 where the DIE traversal cannot performance-reasonably implement `target variable -r` I am returning here whether the `.debug_names` index could not be rather extended/improved. LLDB would fall back to `ManualD

[Lldb-commits] [PATCH] D98749: [lldb] [test] Fix TestGdbRemote_vContThreads.py logic

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. The TestGdbRemote_vContThreads.py were introduced to test NetBSD process plugin's capability of sending per-thread and per-process signals. However, at some point the tests

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

justincohen added a comment. Breakpad/Crashpad are not transporting mach-o core files, they are using minidumps. minidumps don't contain any indication of the number of bits in the address. Apple Xcode lldb is still able to work with these minidumps correctly, while trunk lldb is not. How is it

[Lldb-commits] [PATCH] D98761: Fix "image lookup --address" Summary results for inline functions.

clayborg created this revision. clayborg added reviewers: labath, aprantl, JDevlieghere. clayborg requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Inline callstacks were being incorrectly displaye