[Lldb-commits] [PATCH] D93663: [lldb] Abstract scoped timer logic behind LLDB_SCOPED_TIMER (NFC)

labath added a comment. You can't put these declarations inside `do {} while(0)` -- the additional scope works against us in this case, and forces a premature timer termination. Other than that, this seems fine... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93663/new/ https://review

[Lldb-commits] [lldb] 0a8a245 - [lldb/test] Add GdbRemoteTestCaseFactory to avoid duplication in lldb-server tests

Author: Pavel Labath Date: 2020-12-22T10:07:47+01:00 New Revision: 0a8a2453fb843cf2e0f43e389b58d516525f0b8c URL: https://github.com/llvm/llvm-project/commit/0a8a2453fb843cf2e0f43e389b58d516525f0b8c DIFF: https://github.com/llvm/llvm-project/commit/0a8a2453fb843cf2e0f43e389b58d516525f0b8c.diff

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

DavidSpickett added a comment. Great, thanks for the explanation. I don't think this needs a test since (for now) it acts just like existing signals. The change looks good to me but @labath should approve since I don't know all the signal handling details. Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D93690: Add SBType::IsScopedEnumerationType method

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a method to check if the type is a scoped enumeration (i.e. "enum class/struct"). Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D936

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a method for getting the enumeration underlying type. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93696 Files: lldb/bindings/in

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

werat added reviewers: teemperor, JDevlieghere. werat added a subscriber: jarin. werat added inline comments. Comment at: lldb/test/API/python_api/type/TestTypeList.py:156 +self.DebugSBType(int_enum_type) +self.assertEquals(int_enum_type.GetName(), 'unsigned int')

[Lldb-commits] [PATCH] D93621: [lldb][wasm] Parse DWO section names

pfaffe updated this revision to Diff 313321. pfaffe added a comment. Add the new dwo sections to the testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93621/new/ https://reviews.llvm.org/D93621 Files: lldb/source/Plugins/ObjectFile/wasm/Ob

[Lldb-commits] [PATCH] D93481: [lldb/Lua] add support for multiline scripted breakpoints

tammela added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Lua/Lua.h:39 llvm::Error LoadModule(llvm::StringRef filename); + llvm::Error LoadBuffer(llvm::StringRef buffer, bool pop_result = true); llvm::Error ChangeIO(FILE *out, FILE *err); ---

[Lldb-commits] [PATCH] D93663: [lldb] Abstract scoped timer logic behind LLDB_SCOPED_TIMER (NFC)

JDevlieghere added a comment. In D93663#2467370 , @labath wrote: > You can't put these declarations inside `do {} while(0)` -- the additional > scope works against us in this case, and forces a premature timer > termination. Other than that, this seems f

[Lldb-commits] [lldb] 5c1c844 - [lldb] Abstract scoped timer logic behind LLDB_SCOPED_TIMER (NFC)

Author: Jonas Devlieghere Date: 2020-12-22T09:10:27-08:00 New Revision: 5c1c8443eb7366e6e5086426b5d8dc7d24afc13b URL: https://github.com/llvm/llvm-project/commit/5c1c8443eb7366e6e5086426b5d8dc7d24afc13b DIFF: https://github.com/llvm/llvm-project/commit/5c1c8443eb7366e6e5086426b5d8dc7d24afc13b.d

[Lldb-commits] [PATCH] D93663: [lldb] Abstract scoped timer logic behind LLDB_SCOPED_TIMER (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c1c8443eb73: [lldb] Abstract scoped timer logic behind LLDB_SCOPED_TIMER (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D93663?vs=3131

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

JDevlieghere added inline comments. Comment at: lldb/source/API/SBType.cpp:348 +SBType SBType::GetEnumerationIntegerType() { + LLDB_RECORD_METHOD_NO_ARGS(lldb::SBType, SBType, GetEnumerationIntegerType); + You also need to register the new method. You can add th

[Lldb-commits] [PATCH] D93690: Add SBType::IsScopedEnumerationType method

JDevlieghere added inline comments. Comment at: lldb/source/API/SBType.cpp:275 +bool SBType::IsScopedEnumerationType() { + LLDB_RECORD_METHOD_NO_ARGS(bool, SBType, IsScopedEnumerationType); + Same comment as in D93696: you need to register your new method. Re

[Lldb-commits] [PATCH] D93690: Add SBType::IsScopedEnumerationType method

werat updated this revision to Diff 313378. werat added a comment. Register the new method using lldb-instr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93690/new/ https://reviews.llvm.org/D93690 Files: lldb/bindings/interface/SBType.i lldb/

[Lldb-commits] [PATCH] D93690: Add SBType::IsScopedEnumerationType method

werat marked an inline comment as done. werat added inline comments. Comment at: lldb/source/API/SBType.cpp:275 +bool SBType::IsScopedEnumerationType() { + LLDB_RECORD_METHOD_NO_ARGS(bool, SBType, IsScopedEnumerationType); + JDevlieghere wrote: > Same comment as

[Lldb-commits] [PATCH] D93690: Add SBType::IsScopedEnumerationType method

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93690/new/ https://reviews.llvm.org/D93690 _

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

werat updated this revision to Diff 313379. werat added a comment. Register the new method using lldb-instr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93696/new/ https://reviews.llvm.org/D93696 Files: lldb/bindings/interface/SBType.i lldb/

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

werat updated this revision to Diff 313380. werat marked an inline comment as done. werat added a comment. Remove the test case for unscoped enum, because it's implementation defined and can break any moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93696/new/ https://reviews.llvm.org/D93696 _

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

werat added inline comments. Comment at: lldb/source/API/SBType.cpp:348 +SBType SBType::GetEnumerationIntegerType() { + LLDB_RECORD_METHOD_NO_ARGS(lldb::SBType, SBType, GetEnumerationIntegerType); + JDevlieghere wrote: > You also need to register the new method.

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

werat added a comment. Thanks for a quick review! Can you please land these changes for me since I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93696/new/ https://reviews.llvm.org/D93696

[Lldb-commits] [lldb] e17a00f - [lldb] Add SBType::IsScopedEnumerationType method

Author: Andy Yankovsky Date: 2020-12-22T10:08:21-08:00 New Revision: e17a00fc87bc163cc2438ce10faca51d94b91ab3 URL: https://github.com/llvm/llvm-project/commit/e17a00fc87bc163cc2438ce10faca51d94b91ab3 DIFF: https://github.com/llvm/llvm-project/commit/e17a00fc87bc163cc2438ce10faca51d94b91ab3.diff

[Lldb-commits] [lldb] 1432ae5 - [lldb] Add SBType::GetEnumerationIntegerType method

Author: Andy Yankovsky Date: 2020-12-22T10:08:22-08:00 New Revision: 1432ae57bf6e4022b6f4541c9225674ee6b19c23 URL: https://github.com/llvm/llvm-project/commit/1432ae57bf6e4022b6f4541c9225674ee6b19c23 DIFF: https://github.com/llvm/llvm-project/commit/1432ae57bf6e4022b6f4541c9225674ee6b19c23.diff

[Lldb-commits] [PATCH] D93690: Add SBType::IsScopedEnumerationType method

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe17a00fc87bc: [lldb] Add SBType::IsScopedEnumerationType method (authored by werat, committed by JDevlieghere). Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D93696: Add SBType::GetEnumerationIntegerType method

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1432ae57bf6e: [lldb] Add SBType::GetEnumerationIntegerType method (authored by werat, committed by JDevlieghere). Repository: rG LLVM Github Monor

[Lldb-commits] [lldb] 6283d2a - Revert "[LLDB] Unbreak the build after recent clang changes"

Author: Arthur Eubanks Date: 2020-12-22T10:34:04-08:00 New Revision: 6283d2aa51985d6e6f3404f4b0a3b38b5b05ee6e URL: https://github.com/llvm/llvm-project/commit/6283d2aa51985d6e6f3404f4b0a3b38b5b05ee6e DIFF: https://github.com/llvm/llvm-project/commit/6283d2aa51985d6e6f3404f4b0a3b38b5b05ee6e.diff

[Lldb-commits] [PATCH] D93744: [lldb-vscode] Support processId returned by the IDE in the runInTerminal request

wallace created this revision. wallace added reviewers: kusmour, clayborg. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently, the runInTerminal is implemented by using --wait-for underneath, which is error prone as it often