[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp:47-48 + // run-time update to register sizes and offsets.. + ProcessSP process_sp(GetProcess()); + if (process_sp) { +ProcessGDBRemote *gdb_process = Can't

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial eTakeSnapshot action

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Awesome. Let's ship it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/new/ https://reviews.llvm.org/D92187 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching

labath accepted this revision. labath added a comment. This is consistent with the way we launch processes, so lgtm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92667/new/ https://reviews.llvm.org/D92667 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [lldb] ce279e0 - [lldb/test] Simplify TestGdbRemoteExitCode.py

Author: Pavel Labath Date: 2020-12-07T09:24:12+01:00 New Revision: ce279e0c80eb3af913bc2cd08c2bcf4632252675 URL: https://github.com/llvm/llvm-project/commit/ce279e0c80eb3af913bc2cd08c2bcf4632252675 DIFF: https://github.com/llvm/llvm-project/commit/ce279e0c80eb3af913bc2cd08c2bcf4632252675.diff

[Lldb-commits] [lldb] 174b09e - [lldb/test] Simplify TestLldbGdbServer.py

Author: Pavel Labath Date: 2020-12-07T09:24:13+01:00 New Revision: 174b09e9153894903c13bd4f40c6dab07b2558ba URL: https://github.com/llvm/llvm-project/commit/174b09e9153894903c13bd4f40c6dab07b2558ba DIFF: https://github.com/llvm/llvm-project/commit/174b09e9153894903c13bd4f40c6dab07b2558ba.diff

[Lldb-commits] [lldb] a2f4f7d - [lldb/test] Refactor socket_packet_pump

Author: Pavel Labath Date: 2020-12-07T09:24:13+01:00 New Revision: a2f4f7daf76c767efd668390bc7f8b99bdb1218c URL: https://github.com/llvm/llvm-project/commit/a2f4f7daf76c767efd668390bc7f8b99bdb1218c DIFF: https://github.com/llvm/llvm-project/commit/a2f4f7daf76c767efd668390bc7f8b99bdb1218c.diff

[Lldb-commits] [PATCH] D92746: [lldb] [test] Fix continue_to_breakpoint() args in TestThreadStepOut

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. The test is skipped/xfailing on all platforms, so it seems that the API got out of sync. Fix that so it returns to a 'proper' failur

[Lldb-commits] [PATCH] D92729: [LLDB] fix error message for one-line breakpoint scripts

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. Comment at: lldb/test/Shell/ScriptInterpreter/Python/fail_breakpoint_oneline.test:4 +# +# RUN: cat %s | %lldb --script-language python 2>&1 | FileCheck %s +b main --

[Lldb-commits] [PATCH] D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach

labath added a comment. I am having second thoughts about the image list approach to testing this. The regex matching is somewhat messy. A bad load address should manifest itself in plenty of other ways.. Could we print the value of some global variable to check that we got the correct one?

[Lldb-commits] [PATCH] D92740: [lldb] [test] Link FreeBSD test failures to bugs

This revision was automatically updated to reflect the committed changes. Closed by commit rG266c90fec899: [lldb] [test] Link FreeBSD test failures to bugs (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a1cc0ba7db5: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial eTakeSnapshot action

This revision was automatically updated to reflect the committed changes. Closed by commit rG09b08833f301: [lldb] [POSIX-DYLD] Add libraries from initial eTakeSnapshot action (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D92314: [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and GetFileLoadAddress()

This revision was automatically updated to reflect the committed changes. Closed by commit rG276638ecaf22: [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and… (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D92746: [lldb] [test] Fix continue_to_breakpoint() args in TestThreadStepOut

This revision was automatically updated to reflect the committed changes. Closed by commit rG77f0ea4b5b97: [lldb] [test] Fix continue_to_breakpoint() args in TestThreadStepOut (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [lldb] 266c90f - [lldb] [test] Link FreeBSD test failures to bugs

Author: Michał Górny Date: 2020-12-07T09:56:50+01:00 New Revision: 266c90fec899356aa2c88f1e614d40d554db6fb3 URL: https://github.com/llvm/llvm-project/commit/266c90fec899356aa2c88f1e614d40d554db6fb3 DIFF: https://github.com/llvm/llvm-project/commit/266c90fec899356aa2c88f1e614d40d554db6fb3.diff

[Lldb-commits] [lldb] 09b0883 - [lldb] [POSIX-DYLD] Add libraries from initial eTakeSnapshot action

Author: Michał Górny Date: 2020-12-07T09:56:51+01:00 New Revision: 09b08833f301ea375137931d26b7193101f82ceb URL: https://github.com/llvm/llvm-project/commit/09b08833f301ea375137931d26b7193101f82ceb DIFF: https://github.com/llvm/llvm-project/commit/09b08833f301ea375137931d26b7193101f82ceb.diff

[Lldb-commits] [lldb] 1a1cc0b - [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching

Author: Michał Górny Date: 2020-12-07T09:56:51+01:00 New Revision: 1a1cc0ba7db549025ab1a504633ae4554042fd60 URL: https://github.com/llvm/llvm-project/commit/1a1cc0ba7db549025ab1a504633ae4554042fd60 DIFF: https://github.com/llvm/llvm-project/commit/1a1cc0ba7db549025ab1a504633ae4554042fd60.diff

[Lldb-commits] [lldb] 276638e - [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and GetFileLoadAddress()

Author: Michał Górny Date: 2020-12-07T09:56:51+01:00 New Revision: 276638ecaf226a9931c55e835f18b592bdfbea86 URL: https://github.com/llvm/llvm-project/commit/276638ecaf226a9931c55e835f18b592bdfbea86 DIFF: https://github.com/llvm/llvm-project/commit/276638ecaf226a9931c55e835f18b592bdfbea86.diff

[Lldb-commits] [lldb] 77f0ea4 - [lldb] [test] Fix continue_to_breakpoint() args in TestThreadStepOut

Author: Michał Górny Date: 2020-12-07T09:56:51+01:00 New Revision: 77f0ea4b5b978c7caa0788ae8b1a2429089021bd URL: https://github.com/llvm/llvm-project/commit/77f0ea4b5b978c7caa0788ae8b1a2429089021bd DIFF: https://github.com/llvm/llvm-project/commit/77f0ea4b5b978c7caa0788ae8b1a2429089021bd.diff

[Lldb-commits] [PATCH] D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach

mgorny added a comment. In D92264#2436440 , @labath wrote: > I am having second thoughts about the image list approach to testing this. > The regex matching is somewhat messy. > > A bad load address should manifest itself in plenty of other ways.. Could w

[Lldb-commits] [lldb] cf884c1 - [lldb] [test] Remove duplicate xfail for Testtypedef

Author: Michał Górny Date: 2020-12-07T11:22:06+01:00 New Revision: cf884c1035c79973e7297fcd13495b78e00ef919 URL: https://github.com/llvm/llvm-project/commit/cf884c1035c79973e7297fcd13495b78e00ef919 DIFF: https://github.com/llvm/llvm-project/commit/cf884c1035c79973e7297fcd13495b78e00ef919.diff

[Lldb-commits] [PATCH] D92729: [LLDB] fix error message for one-line breakpoint scripts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG280ae10774ab: [LLDB] fix error message for one-line breakpoint scripts (authored by tammela). Changed prior to commit: https://reviews.llvm.org/D9

[Lldb-commits] [PATCH] D82857: [LLDB] Add per-thread register infos shared pointer in gdb-remote

omjavaid updated this revision to Diff 309860. omjavaid added a comment. This update resolves review comments from @rovka and @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82857/new/ https://reviews.llvm.org/D82857 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInf

[Lldb-commits] [lldb] 280ae10 - [LLDB] fix error message for one-line breakpoint scripts

Author: Pedro Tammela Date: 2020-12-07T11:21:07Z New Revision: 280ae10774abac63d4c9fdaf99598afe3053540a URL: https://github.com/llvm/llvm-project/commit/280ae10774abac63d4c9fdaf99598afe3053540a DIFF: https://github.com/llvm/llvm-project/commit/280ae10774abac63d4c9fdaf99598afe3053540a.diff LOG:

[Lldb-commits] [PATCH] D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach

mgorny updated this revision to Diff 309871. mgorny edited the summary of this revision. mgorny added a comment. Rewritten the test wrt comments, that is: 1. Added a breakpoint-continue to ensure that the program is past all initial work before we test it. 2. Print a global variable to test it.

[Lldb-commits] [lldb] 733e2ae - Revert "[lldb] [POSIX-DYLD] Add libraries from initial eTakeSnapshot action"

Author: Michał Górny Date: 2020-12-07T15:58:49+01:00 New Revision: 733e2ae8cdf3d13e0a1ef9878e8500f446ffa699 URL: https://github.com/llvm/llvm-project/commit/733e2ae8cdf3d13e0a1ef9878e8500f446ffa699 DIFF: https://github.com/llvm/llvm-project/commit/733e2ae8cdf3d13e0a1ef9878e8500f446ffa699.diff

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial eTakeSnapshot action

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. This causes ld-linux to be added twice on Linux. I need to change the logic a bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit

mgorny updated this revision to Diff 309950. mgorny retitled this revision from "[lldb] [POSIX-DYLD] Add libraries from initial eTakeSnapshot action" to "[lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit". mgorny edited the summary of this revision. mgorny added a comment. Upda

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

kastiglione created this revision. kastiglione added a reviewer: aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `is_variadic_ptr` is unused. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92778 Fil

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

kastiglione abandoned this revision. kastiglione added a comment. I can't read. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92778/new/ https://reviews.llvm.org/D92778 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

kastiglione updated this revision to Diff 309966. kastiglione added a comment. Remove function use of is_variadic_ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92778/new/ https://reviews.llvm.org/D92778 Files: lldb/include/lldb/Symbol/Compil

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Bonus points for the emotional rollercoaster in the review history. (You probably want to update the downstream next branch too once this has landed just to keep it ~~gree

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

kastiglione added a comment. Yes I plan to merge this manually (rather than automerge) to ensure it's not disruptive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92778/new/ https://reviews.llvm.org/D92778 ___

[Lldb-commits] [lldb] 33e3b07 - [lldb] Include thread id in the reproducer trace (NFC)

Author: Jonas Devlieghere Date: 2020-12-07T20:35:34-08:00 New Revision: 33e3b07af3ce9595f49c75a8af559bdec5cc19fa URL: https://github.com/llvm/llvm-project/commit/33e3b07af3ce9595f49c75a8af559bdec5cc19fa DIFF: https://github.com/llvm/llvm-project/commit/33e3b07af3ce9595f49c75a8af559bdec5cc19fa.d

[Lldb-commits] [PATCH] D92811: [lldb] Track the API boundary using a thread_local variable.

JDevlieghere created this revision. JDevlieghere added reviewers: friss, labath. JDevlieghere requested review of this revision. The reproducers currently use a static variable to track the API boundary. This is obviously incorrect when the SB API is used concurrently. While I do not plan to sup