labath added a comment.

I am having second thoughts about the image list approach to testing this. The 
regex matching is somewhat messy.

A bad load address should manifest itself in plenty of other ways.. Could we 
print the value of some global variable to check that we got the correct one?



================
Comment at: lldb/test/API/commands/process/attach/TestProcessAttach.py:94
+
+        self.runCmd("process attach -p " + str(popen.pid))
+
----------------
Do you need to attach at any particular moment during the process startup? The 
attach command could run pretty quickly, before the loader finished its work...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92264/new/

https://reviews.llvm.org/D92264

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to