[Lldb-commits] [PATCH] D92035: [lldb] Use llvm::Optional for port in LaunchGDBServer

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp:197 #endif - uint16_t *port_ptr = &port; + uint16_t *port_ptr = port.getPo

[Lldb-commits] [PATCH] D91634: [lldb] Error when there are no ports to launch a gdbserver on

labath added a comment. Looks good. Just some cosmetic details... Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.h:30 public: - using PortMap = std::map; using PacketHandler = DavidSpickett wrote: > Only the one in GDBRemo

[Lldb-commits] [PATCH] D91508: [LLDB/Lua] add support for one-liner breakpoint callback

labath added a comment. I think we're converging on something. Now to iron out the details... In D91508#2413789 , @tammela wrote: >> I am puzzled by all the wrapping that's happening inside the `PushSBClass` >> functions. What is that protecting us from?

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

labath added a reviewer: mgorny. labath added a subscriber: mgorny. labath added a comment. +@mgorny, as he's been navigating these waters lately... So... I presume we can't just slap `__attribute__((packed))` on the structure, because the kernel actually expects that the data structure will hav

[Lldb-commits] [PATCH] D91835: [lldb] Add Python bindings to print stack traces on crashes.

JDevlieghere added a comment. In D91835#2407492 , @labath wrote: > In D91835#2407060 , @rupprecht wrote: > >> I ran manual tests for this, but I did so by introducing an intentional >> crash in a place that obvious

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

omjavaid added a comment. In D92063#2416162 , @labath wrote: > +@mgorny, as he's been navigating these waters lately... > > So... I presume we can't just slap `__attribute__((packed))` on the > structure, because the kernel actually expects that the data

[Lldb-commits] [PATCH] D92063: [LLDB] RegisterInfoPOSIX_arm64 remove unused bytes from g/G packet

omjavaid updated this revision to Diff 307769. omjavaid added a comment. Update as per my last comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92063/new/ https://reviews.llvm.org/D92063 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source