labath added a reviewer: mgorny.
labath added a subscriber: mgorny.
labath added a comment.
+@mgorny, as he's been navigating these waters lately...
So... I presume we can't just slap `__attribute__((packed))` on the structure,
because the kernel actually expects that the data structure will have the extra
space for the padding. Is that so?
Even if we can't, I'm wondering if it wouldn't be cleaner to use two structures
for this. Something like:
LLVM_PACKED_START
struct GPR {
// as before...
};
/// Big comment explaining the purpose of padding
struct GPRBuffer: GPR {
uint32_t pad;
};
LLVM_PACKED_END
and then using GPR or GPRBuffer accordingly. What do you think?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92063/new/
https://reviews.llvm.org/D92063
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
