[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

labath added a comment. Sorry, I confused this with the patch that was wrapping stderr into DAP messages. Having python output break the protocol is definitely not good. Fixing it would be nice, but the solution should work on windows as well. One possibility I'd consider is making this fix at

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

labath accepted this revision. labath added a comment. Thanks for tracking this down. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88229/new/ https://reviews.llvm.org/D88229 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D88249: [lldb] Make protected ctor and method of SBAddress take a const reference instead of a pointer.

labath added a comment. cool Comment at: lldb/source/API/SBValue.cpp:1359 - return LLDB_RECORD_RESULT(SBAddress(new Address(addr))); + return LLDB_RECORD_RESULT(SBAddress(Address(addr))); } the `Address(` part is redundant. Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

labath added inline comments. Comment at: lldb/include/lldb/Core/StructuredDataImpl.h:72-74 +lldb::StructuredDataPluginSP plugin_sp; +if (!m_plugin_wp.expired()) + plugin_sp = lldb::StructuredDataPluginSP(m_plugin_wp); This is racy. The right way to

[Lldb-commits] [PATCH] D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays.

labath added a comment. Not long ago. I added a `MCBasedABI` class which makes this goo mostly disappear as it gets its information from llvm MC layer. I haven't converted the mips abi due to a combination of being preempted by higher priority task, not having a mips machine to test on, and thi

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum created this revision. fallkrum added reviewers: jingham, LLDB. fallkrum added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a reviewer: JDevlieghere. fallkrum requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.l

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

labath added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp:349-369 + +TEST_F(SymbolFileDWARFTests, EnsureLineEntriesExistInAfterFirstCodeSection) { + auto ExpectedFile = TestFile::fromYamlFile("test-invalid-addresses.yaml"); + ASSERT_THAT

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

mib added a comment. Spotted some little things here and there ... This patch lacks a test and would need some reformatting (`git clang-format HEAD~`) but other than that, looks ok to me. Comment at: lldb/include/lldb/Symbol/Type.h:118 +/* + GetModule may return modul

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. In D88483#2300716 , @mib wrote: > Spotted some little things here and there ... This patch lacks a test and > would need some reformatting (`git clang-format HEAD~`) but other than that, > looks ok to me. Can I format and add t

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

labath added a comment. I think this patch for its test coverage. The thing I'm not so sure about is the verbatim passing of the os-specific flags. That's nice for the purpose of displaying them to the user, but it can make things messy for programatic use, particularly if multiple platforms st

[Lldb-commits] [lldb] d0ed45d - [lldb] Configure LLDB_FRAMEWORK_DIR in multi-generator builds

Author: Jonas Devlieghere Date: 2020-09-29T08:56:31-07:00 New Revision: d0ed45dc920004bb7b6642d6086b4722443eeba2 URL: https://github.com/llvm/llvm-project/commit/d0ed45dc920004bb7b6642d6086b4722443eeba2 DIFF: https://github.com/llvm/llvm-project/commit/d0ed45dc920004bb7b6642d6086b4722443eeba2.d

[Lldb-commits] [lldb] ccbb982 - [lldb] Also configure lldb_framework_dir in the lit.site.cfg.py

Author: Jonas Devlieghere Date: 2020-09-29T09:13:26-07:00 New Revision: ccbb9827db4c30c93b92a204aeb2b98f9f3a723a URL: https://github.com/llvm/llvm-project/commit/ccbb9827db4c30c93b92a204aeb2b98f9f3a723a DIFF: https://github.com/llvm/llvm-project/commit/ccbb9827db4c30c93b92a204aeb2b98f9f3a723a.d

[Lldb-commits] [lldb] b4968c7 - [lldb] Remove redundant ctor call (NFC)

Author: Jonas Devlieghere Date: 2020-09-29T10:05:12-07:00 New Revision: b4968c7001c2d7e2e607bef1bb11ae8f076e47e0 URL: https://github.com/llvm/llvm-project/commit/b4968c7001c2d7e2e607bef1bb11ae8f076e47e0 DIFF: https://github.com/llvm/llvm-project/commit/b4968c7001c2d7e2e607bef1bb11ae8f076e47e0.d

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

clayborg added inline comments. Comment at: lldb/unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp:369 + EXPECT_EQ(section_sp->GetType(), eSectionTypeCode); +} I would rather deal with an C++ unit test any day. Trying to track down what set of convoluted com

[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:437 + m_supports_DW_AT_APPLE_objc_complete_type(eLazyBoolCalculate) { + auto first_code_section_sp = + m_objfile_sp->GetModule()->GetSectionList()->FindSectionByType( -

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

jingham added inline comments. Comment at: lldb/include/lldb/Core/StructuredDataImpl.h:72-74 +lldb::StructuredDataPluginSP plugin_sp; +if (!m_plugin_wp.expired()) + plugin_sp = lldb::StructuredDataPluginSP(m_plugin_wp); labath wrote: > This is racy.

[Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

Author: Jim Ingham Date: 2020-09-29T12:01:14-07:00 New Revision: 1b1d9815987a753f2f3524cfad050b85972dae5b URL: https://github.com/llvm/llvm-project/commit/1b1d9815987a753f2f3524cfad050b85972dae5b DIFF: https://github.com/llvm/llvm-project/commit/1b1d9815987a753f2f3524cfad050b85972dae5b.diff LO

[Lldb-commits] [lldb] 5d19eb5 - [lldb/docs] Remove manual codesigning documentation

Author: Dave Lee Date: 2020-09-29T12:50:45-07:00 New Revision: 5d19eb542db40fc5fe9f37c46246785ba5ae1e10 URL: https://github.com/llvm/llvm-project/commit/5d19eb542db40fc5fe9f37c46246785ba5ae1e10 DIFF: https://github.com/llvm/llvm-project/commit/5d19eb542db40fc5fe9f37c46246785ba5ae1e10.diff LOG:

[Lldb-commits] [PATCH] D88257: [lldb/docs] Remove manual codesigning documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d19eb542db4: [lldb/docs] Remove manual codesigning documentation (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [lldb] 92e1ebe - [trace] Fix destructor declaration

Author: Walter Erquinigo Date: 2020-09-29T13:09:52-07:00 New Revision: 92e1ebeaa1fe0e5461327d071c55167733834e60 URL: https://github.com/llvm/llvm-project/commit/92e1ebeaa1fe0e5461327d071c55167733834e60 DIFF: https://github.com/llvm/llvm-project/commit/92e1ebeaa1fe0e5461327d071c55167733834e60.di

[Lldb-commits] [lldb] 3c7070f - [lldb] Hoist --server argument out of LLDB_TEST_COMMON_ARGS (NFC)

Author: Jonas Devlieghere Date: 2020-09-29T13:27:29-07:00 New Revision: 3c7070f1a6b89277fce042a943cd83fa65507a67 URL: https://github.com/llvm/llvm-project/commit/3c7070f1a6b89277fce042a943cd83fa65507a67 DIFF: https://github.com/llvm/llvm-project/commit/3c7070f1a6b89277fce042a943cd83fa65507a67.d

[Lldb-commits] [PATCH] D88513: [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints.

rupprecht created this revision. rupprecht added reviewers: wallace, clayborg, labath. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rupprecht requested review of this revision. Per the DAP spec for SetBreakpoints [1], the way to clea

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

clayborg added inline comments. Comment at: lldb/include/lldb/Core/StructuredDataImpl.h:72-74 +lldb::StructuredDataPluginSP plugin_sp; +if (!m_plugin_wp.expired()) + plugin_sp = lldb::StructuredDataPluginSP(m_plugin_wp); jingham wrote: > labath wrote

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

clayborg added a comment. Jim: were you able to repro this with a simple a.out program? Is there something worse going on here like maybe incompatible libc++/libstdc++ implementations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88266/new/ http

[Lldb-commits] [PATCH] D88516: [lldb] Add a "design" section to the documentation.

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: arphaman. JDevlieghere requested review of this revision. Create a "Design" section for the LLDB documentation. The goal would be to have design documents that describe how the LLDB internals work.

[Lldb-commits] [PATCH] D88513: [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Very good! Thank you Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py:228 + empty one.''' +lines = [line_number('main.

[Lldb-commits] [lldb] 2f95c50 - Fix use of wrong printf format specifier for size_t argument.

Author: Richard Smith Date: 2020-09-29T16:02:08-07:00 New Revision: 2f95c50a8b713970c5134dabc246270111a48c6d URL: https://github.com/llvm/llvm-project/commit/2f95c50a8b713970c5134dabc246270111a48c6d DIFF: https://github.com/llvm/llvm-project/commit/2f95c50a8b713970c5134dabc246270111a48c6d.diff

[Lldb-commits] [PATCH] D86670: [intel-pt] Add a basic implementation of the dump command

wallace updated this revision to Diff 295145. wallace added a comment. Herald added a reviewer: JDevlieghere. Rebased and did some code cleanup. The output of the dump command looks like this Settings directory: /home/wallace/llvm-sand/external/llvm-project/lldb/test/API/commands/trace/intel

[Lldb-commits] [lldb] bd14d6e - [lldb] Hoist -s (trace directory) argument out of LLDB_TEST_COMMON_ARGS (NFC)

Author: Jonas Devlieghere Date: 2020-09-29T17:23:33-07:00 New Revision: bd14d6ea1517c93ceecaec29dad016d9a122fa1b URL: https://github.com/llvm/llvm-project/commit/bd14d6ea1517c93ceecaec29dad016d9a122fa1b DIFF: https://github.com/llvm/llvm-project/commit/bd14d6ea1517c93ceecaec29dad016d9a122fa1b.d

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

jingham added a comment. In D88266#2301934 , @clayborg wrote: > Jim: were you able to repro this with a simple a.out program? Is there > something worse going on here like maybe incompatible libc++/libstdc++ > implementations? The crash is pretty easy t

[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

jingham updated this revision to Diff 295156. jingham added a comment. Use std::weak_ptr::lock to make the shared pointer, rather than std::shared_ptr::shared_ptr(std::weak_ptr) (sort of), as the latter throws. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] 154860a - [lldb] Use config.lldb_src_root in lit_config.load_config (NFC)

Author: Jonas Devlieghere Date: 2020-09-29T23:05:12-07:00 New Revision: 154860af338f7b0c82cb04e91d6f199aa72cfdff URL: https://github.com/llvm/llvm-project/commit/154860af338f7b0c82cb04e91d6f199aa72cfdff DIFF: https://github.com/llvm/llvm-project/commit/154860af338f7b0c82cb04e91d6f199aa72cfdff.d