fallkrum added a comment. In D88483#2300716 <https://reviews.llvm.org/D88483#2300716>, @mib wrote:
> Spotted some little things here and there ... This patch lacks a test and > would need some reformatting (`git clang-format HEAD~`) but other than that, > looks ok to me. Can I format and add tests in the very end? The issue of getting module from type turned out a bit tricky and I'm not sure I'v done it the right way. Would like to see opinions first so as not to format and rewrite tests in vain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits