[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

labath added a comment. Though I have messed with IOHandlers in the past, I have successfully suppressed most of the memories of it. I think I have a rough understanding of what the bug is, but I don't understand the solution yet. With this patch, what does guarantee that the IOHandler for the

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. I think this is looking very good now. Excited to have this ready. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

teemperor updated this revision to Diff 238189. teemperor added a comment. - Moved to using the SBAPI. We can't get fully rid of parsing some output as GetDescription of SBValue returns `(type) $0 = VALUE\n` but there seems to be no way to get rid of the stuff around the value we want. But we no

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

teemperor added a comment. I also got rid of the expr->frame var->expr flow and it's not just expr->frame var. I don't want to remove them as we found two formatter bugs by testing both but once these thing don't break constantly then we can remove the 'expr' variant from the simple expression

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

labath added a comment. In D72650#1820897 , @paolosev wrote: > In D72650#1819403 , @labath wrote: > > > The patch looks pretty good. A reasonable way to test this would be again > > via `lldb-test object-file` . Th

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a comment. Testing dynamic loaders is a bit tricky as they require an actual process around. The best thing available to us right now is the "gdb-client" approach, which consists of mocking the responses of the gdb server. It's not the easiest way to write tests, but I don't think

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

teemperor updated this revision to Diff 238205. teemperor added a comment. - Removed everything that is not summary or value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70314/new/ https://reviews.llvm.org/D70314 Files: lldb/packages/Python/lldbsuite/test/commands/expression/call-

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

labath added a comment. This seems fine, assuming it is sufficient to achieve your goals. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2396-2407 +if type(expected) is list: +remaining = got +for expected_part in expecte

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

teemperor updated this revision to Diff 238209. teemperor added a comment. - Removed substr functionality. - Using `frame()` now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70314/new/ https://reviews.llvm.org/D70314 Files: lldb/packages/Python/lldbsuite/test/commands/expression/c

[Lldb-commits] [PATCH] D70314: [lldb] Add better test commands for expression evaluation

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is a great start. We can see how we can extend this later... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70314/new/ https://reviews.llvm.org/D70314 _

[Lldb-commits] [PATCH] D70314: [lldb] Add expect_expr function for testing expression evaluation in dotests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG13f22f5d5958: [lldb] Add expect_expr function for testing expression evaluation in dotests. (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

paolosev added a comment. In D71575#1821312 , @labath wrote: > Thanks. I think this is looking very good now. Excited to have this ready. > > Do you have commit access? No, I certainly don't have commit access, this would be my first accepted patch. :)

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

clayborg added a comment. So I did a bunch of original IOHandler. And there are many complex cases for sure. One thing to be aware of is that if you won't use editline() and we call fgets() in the default implementation, there is no way to cancel this IIRC. So it might be worth trying this with

[Lldb-commits] [PATCH] D70314: [lldb] Add expect_expr function for testing expression evaluation in dotests.

clayborg added a comment. nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70314/new/ https://reviews.llvm.org/D70314 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

clayborg added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/wasm-DYLD/DynamicLoaderWasmDYLD.cpp:121 + : image_load_address); + if (m_process->GetTarget().SetSectionLoadAddress(section_sp, load_addr)) +loa

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

jingham added a comment. In D72748#1822443 , @clayborg wrote: > So I did a bunch of original IOHandler. And there are many complex cases for > sure. One thing to be aware of is that if you won't use editline() and we > call fgets() in the default impleme

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

JDevlieghere planned changes to this revision. JDevlieghere added a comment. I'm working on a different approach that should address al the concerns raised so far. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72748/new/ https://reviews.llvm.org/D72748 __

[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

vsk marked 2 inline comments as done. vsk added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:990 +assert(PCAddr && "Missing return PC information for a call"); +addLabelAddress(CallSiteDIE, dwarf::DW_AT_call_return_pc, PCAddr); } --

[Lldb-commits] [PATCH] D72650: [LLDB] Add SymbolVendorWasm plugin for WebAssembly debugging

paolosev updated this revision to Diff 238342. paolosev added a comment. Modified test to have two "inlined" yaml files and use "yaml2obj --docnum". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72650/new/ https://reviews.llvm.org/D72650 Files:

[Lldb-commits] [lldb] f012055 - [DWARF] Emit DW_AT_call_return_pc as an address

Author: Vedant Kumar Date: 2020-01-15T13:02:23-08:00 New Revision: f0120556c7e2ef14ff3da5bd7d5717cedf94b767 URL: https://github.com/llvm/llvm-project/commit/f0120556c7e2ef14ff3da5bd7d5717cedf94b767 DIFF: https://github.com/llvm/llvm-project/commit/f0120556c7e2ef14ff3da5bd7d5717cedf94b767.diff

[Lldb-commits] [PATCH] D72489: [DWARF] Emit DW_AT_call_return_pc as an address

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0120556c7e2: [DWARF] Emit DW_AT_call_return_pc as an address (authored by vsk). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D72489?vs=237419&id=238350#toc Repositor

[Lldb-commits] [PATCH] D72748: [lldb/IOHandler] Change the way we manage IO handler

JDevlieghere updated this revision to Diff 238358. JDevlieghere added a comment. Synchronize between `RunIOHandler` and `ExecuteIOHandlers` using a mutex. When running an IO handler synchronously, block `ExecuteIOHandlers` until we're finished. CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] 8d2f252 - lldb: Run TestCrossDSOTailCalls.py and TestCrossObjectTailCalls.py on Darwin only

Author: Vedant Kumar Date: 2020-01-15T14:00:05-08:00 New Revision: 8d2f252bb8e4d199be8498c4ee2245117ef08fd2 URL: https://github.com/llvm/llvm-project/commit/8d2f252bb8e4d199be8498c4ee2245117ef08fd2 DIFF: https://github.com/llvm/llvm-project/commit/8d2f252bb8e4d199be8498c4ee2245117ef08fd2.diff

[Lldb-commits] [lldb] 7ce2de2 - [lldb/Debugger] Rename IO handler methods to be more meaningful (NFC)

Author: Jonas Devlieghere Date: 2020-01-15T14:58:16-08:00 New Revision: 7ce2de2ce4e7d4dd8e1e5a7a5b35c0f98e46681d URL: https://github.com/llvm/llvm-project/commit/7ce2de2ce4e7d4dd8e1e5a7a5b35c0f98e46681d DIFF: https://github.com/llvm/llvm-project/commit/7ce2de2ce4e7d4dd8e1e5a7a5b35c0f98e46681d.d

[Lldb-commits] [lldb] 81fc1be - [lldb/Utils] Patch all variables used by lldb-dotest

Author: Jonas Devlieghere Date: 2020-01-15T15:17:16-08:00 New Revision: 81fc1be601e7a8b73b675d318af9b1ba046fb5f5 URL: https://github.com/llvm/llvm-project/commit/81fc1be601e7a8b73b675d318af9b1ba046fb5f5 DIFF: https://github.com/llvm/llvm-project/commit/81fc1be601e7a8b73b675d318af9b1ba046fb5f5.d

[Lldb-commits] [lldb] eac134d - [lldb/Utils] Patch all variables used by lit (3/3)

Author: Jonas Devlieghere Date: 2020-01-15T16:01:42-08:00 New Revision: eac134ddf0344ff44bcd6a6285b6498e080cd1e3 URL: https://github.com/llvm/llvm-project/commit/eac134ddf0344ff44bcd6a6285b6498e080cd1e3 DIFF: https://github.com/llvm/llvm-project/commit/eac134ddf0344ff44bcd6a6285b6498e080cd1e3.d

[Lldb-commits] [lldb] cf95849 - [lldb/Utils] Patch all variables used by lldb-dotest (2/2)

Author: Jonas Devlieghere Date: 2020-01-15T16:01:42-08:00 New Revision: cf958498c4b49447ab1ba6bb61a7d8816d306107 URL: https://github.com/llvm/llvm-project/commit/cf958498c4b49447ab1ba6bb61a7d8816d306107 DIFF: https://github.com/llvm/llvm-project/commit/cf958498c4b49447ab1ba6bb61a7d8816d306107.d

[Lldb-commits] [lldb] 4bafcec - [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

Author: Paolo Severini Date: 2020-01-15T16:25:35-08:00 New Revision: 4bafceced6a7641be7b090229c6ccef22cf55bff URL: https://github.com/llvm/llvm-project/commit/4bafceced6a7641be7b090229c6ccef22cf55bff DIFF: https://github.com/llvm/llvm-project/commit/4bafceced6a7641be7b090229c6ccef22cf55bff.diff

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rG4bafceced6a7: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging (authored by paolosev, committed by dschuff). Changed prior to commit: https://reviews.llvm.org/D71575?vs=238168&id=238391#toc R

[Lldb-commits] [PATCH] D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS

jasonmolenda created this revision. jasonmolenda added reviewers: clayborg, jingham. Herald added a project: LLDB. On macOS lldb has an option that can be added to SBLaunchInfo to create a new Terminal window and run the inferior in that new window. lldb uses some AppleScript to open the new wi

[Lldb-commits] [lldb] 9efd57e - [lldb/Tools] Remove lldb-mi.exports

Author: Jonas Devlieghere Date: 2020-01-15T16:50:17-08:00 New Revision: 9efd57e3b7daa7ebd891084b8564440c5ef297ad URL: https://github.com/llvm/llvm-project/commit/9efd57e3b7daa7ebd891084b8564440c5ef297ad DIFF: https://github.com/llvm/llvm-project/commit/9efd57e3b7daa7ebd891084b8564440c5ef297ad.d

[Lldb-commits] [PATCH] D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS

clayborg added inline comments. Comment at: lldb/source/Host/macosx/objcxx/Host.mm:154-155 + // started, and stop at dyld_start, before we attach. + const int short_sleep = 10; // 0.1 seconds + ::usleep(short_sleep); + This seems racy still?

[Lldb-commits] [lldb] 1e89fb9 - debugserver: Cut dependency on intrinsics_gen

Author: Vedant Kumar Date: 2020-01-15T17:20:10-08:00 New Revision: 1e89fb947ed1f8042e13b5840751b73b18cd6534 URL: https://github.com/llvm/llvm-project/commit/1e89fb947ed1f8042e13b5840751b73b18cd6534 DIFF: https://github.com/llvm/llvm-project/commit/1e89fb947ed1f8042e13b5840751b73b18cd6534.diff

[Lldb-commits] [PATCH] D72813: Fixes to lldb's eLaunchFlagLaunchInTTY feature on macOS

jasonmolenda marked 3 inline comments as done. jasonmolenda added a comment. Thanks for the review Greg. To really do this reliably, we probably either need to use a different kernel API, or push this down into debugserver where we can get the process' task port and inspect what its status is.

[Lldb-commits] [lldb] cd9e5c3 - Fix the macos build after D71575.

Author: Jim Ingham Date: 2020-01-15T18:13:44-08:00 New Revision: cd9e5c32302cd3b34b796683eedb072c6a1cfdc1 URL: https://github.com/llvm/llvm-project/commit/cd9e5c32302cd3b34b796683eedb072c6a1cfdc1 DIFF: https://github.com/llvm/llvm-project/commit/cd9e5c32302cd3b34b796683eedb072c6a1cfdc1.diff LO

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

jingham added a comment. BTW, I had to fix this patch (cd9e5c32302cd3b34b796683eedb072c6a1cfdc1 ) to build on macOS. uint64_t and size_t are differently spelled (though I think otherwise equivalent.) One is "long long unsign

[Lldb-commits] [PATCH] D71575: [LLDB] Add ObjectFileWasm plugin for WebAssembly debugging

paolosev added a comment. In D71575#1823252 , @jingham wrote: > BTW, I had to fix this patch (cd9e5c32302cd3b34b796683eedb072c6a1cfdc1 > ) to > build on macOS. uint64_t and size_t are

[Lldb-commits] [lldb] b54a50f - [lldb/Reproducers] Extract function for reading environment override (NFC)

Author: Jonas Devlieghere Date: 2020-01-15T19:14:28-08:00 New Revision: b54a50f52e9427f250c192a8618b881732e5d7a4 URL: https://github.com/llvm/llvm-project/commit/b54a50f52e9427f250c192a8618b881732e5d7a4 DIFF: https://github.com/llvm/llvm-project/commit/b54a50f52e9427f250c192a8618b881732e5d7a4.d

[Lldb-commits] [lldb] 066e817 - [lldb/Reproducers] Add a flag to always generating a reproducer

Author: Jonas Devlieghere Date: 2020-01-15T19:45:54-08:00 New Revision: 066e817b421e8502a72735988e14713940517aaa URL: https://github.com/llvm/llvm-project/commit/066e817b421e8502a72735988e14713940517aaa DIFF: https://github.com/llvm/llvm-project/commit/066e817b421e8502a72735988e14713940517aaa.d

[Lldb-commits] [lldb] 982a77b - [lldb/Reproducers] Print more info for reproducer status

Author: Jonas Devlieghere Date: 2020-01-15T20:25:44-08:00 New Revision: 982a77b69408d6d54526b331046b4508a68ef459 URL: https://github.com/llvm/llvm-project/commit/982a77b69408d6d54526b331046b4508a68ef459 DIFF: https://github.com/llvm/llvm-project/commit/982a77b69408d6d54526b331046b4508a68ef459.d

[Lldb-commits] [PATCH] D72823: [Reproducers] Add a tool to transparently capture and replay lldb sessions

JDevlieghere created this revision. JDevlieghere added reviewers: labath, friss. Herald added a subscriber: mgorny. Herald added a project: LLDB. This patch introduces a small new tool `(lldb-repro`) to transparently capture and replay debugger sessions from the driver. The goal is to run the she