vsk marked 2 inline comments as done.
vsk added inline comments.
================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:990
+ assert(PCAddr && "Missing return PC information for a call");
+ addLabelAddress(CallSiteDIE, dwarf::DW_AT_call_return_pc, PCAddr);
}
----------------
djtodoro wrote:
> Why don't we use the `getDwarf5OrGNUAttr()` for the `return_pc/low_pc`, since
> we use the address in both cases now?
I'll plan a follow-up for this, thanks.
================
Comment at: llvm/test/tools/dsymutil/Inputs/call-site-entry.c:21-27
+int zero() {
+ return 0;
+}
+
+int main() {
+ return zero();
+}
----------------
dblaikie wrote:
> Would this be able to be simplified down to:
>
> ```
> __attribute__((optnone)) void f() {
> }
> int main() {
> f();
> }
> ```
>
> (the attribute might be simpler than the command line argument to disable
> optimizations)
>
> Or does the function need to return int to get a call_site?
That's a nice simplification, I'll fold that in before committing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72489/new/
https://reviews.llvm.org/D72489
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
