[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

mstorsjo marked an inline comment as done. mstorsjo added a comment. In D68134#1700453 , @amccarth wrote: > LGTM after one question. Thanks! I'll hold off committing for a bit still, as I might try to add more options to the microsoft demangler, to matc

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. I have longed for this change, thank you! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68606/new/ https://reviews.llvm.org/D68606 ___ ll

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

JDevlieghere updated this revision to Diff 223888. JDevlieghere added a comment. We discussed this on IRC a bit and this is my updated proposal for the directory names: - API - Shell - Unit The corresponding targets are `lldb-check-unit` (unchanged), `lldb-check-shell` (runs just the FileCheck

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

labath added a comment. In D68606#1699197 , @thopre wrote: > Shouldn't the CMake target remain check-lldb-unit to be consistant with > check-llvm-unit/check-clang-unit etc.? In D68606#1699219 , @mstorsjo wrote:

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

aleksandr.urakov added a comment. Hello! I am sorry for a delay with reply, I was OOO. Thanks all for the review! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68258/new/ https://reviews.llvm.org/D68258 ___ lldb-co

[Lldb-commits] [lldb] r374145 - [lldb] Don't crash when the ASTImporter produces diagnostics but instead log them.

Author: teemperor Date: Wed Oct 9 01:30:06 2019 New Revision: 374145 URL: http://llvm.org/viewvc/llvm-project?rev=374145&view=rev Log: [lldb] Don't crash when the ASTImporter produces diagnostics but instead log them. When playing with the C++ module prototype I noticed I can get LLDB to crash

[Lldb-commits] [lldb] r374148 - Unify the two CRC implementations

Author: hans Date: Wed Oct 9 02:06:30 2019 New Revision: 374148 URL: http://llvm.org/viewvc/llvm-project?rev=374148&view=rev Log: Unify the two CRC implementations David added the JamCRC implementation in r246590. More recently, Eugene added a CRC-32 implementation in r357901, which falls back t

[Lldb-commits] [PATCH] D68570: Unify the two CRC implementations

This revision was automatically updated to reflect the committed changes. Closed by commit rG1e1e3ba2526e: Unify the two CRC implementations (authored by hansw). Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

jhenderson added subscribers: MaskRay, grimar. jhenderson added a comment. FYI, I'm going to be away for 2 and a half weeks from the end of work today, so won't have time to look at these if I don't get to them later today. I have no issues with other people reviewing them. You might want to add

[Lldb-commits] [PATCH] D68454: Fix the unwinding plan augmentation from x86 assembly

jarin added a reviewer: labath. jarin added a comment. Pavel, could you possibly take a look? It looks like Jason is busy with something else... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68454/new/ https://reviews.llvm.org/D68454 __

[Lldb-commits] [PATCH] D68691: [lldb] Add MemorySource abstraction, unit test StringPrinter and document found bugs

teemperor added a comment. Btw, the current declaration of MemorySource is just what I came up with on the fly. Not sure where the documentation should go or if that class deserves its own header. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68691/new/ https

[Lldb-commits] [PATCH] D68691: [lldb] Add MemorySource abstraction, unit test StringPrinter and document found bugs

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere, abidh, mgorny. Herald added a project: LLDB. teemperor added a comment. Btw, the current declaration of MemorySource is just what I came up with on the fly. Not sure where th

[Lldb-commits] [PATCH] D68674: Remove the is_mangled flag from Mangled and Symbol

labath accepted this revision. labath added a comment. Looks like a nice cleanup, if we can get away with that. I tried to come up with a situation where we would have a more authoritative source on whether something is mangled or not than just looking at the string, but I haven't come up with

[Lldb-commits] [PATCH] D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

teemperor created this revision. teemperor added reviewers: jingham, JDevlieghere, labath. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The SearchCallback has a bool parameter that we always set to false, we never use in any callback implementation and that also changes

[Lldb-commits] [PATCH] D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

teemperor added a comment. I just realised the same is true for `addr` (beside that it is consistently named). I'll remove this too after this has landed. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68696/new/ https://reviews.llvm.org/D68696 _

[Lldb-commits] [PATCH] D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lol Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68696/new/ https://reviews.llvm.org/D68696 ___ lldb-commits

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

labath added inline comments. Comment at: lldb/source/Core/IOHandler.cpp:317-321 + size_t end = pos + 1; + while (end > 0 && + (line_buffer[end - 1] == '\n' || line_buffer[end - 1] == '\r')) +end--; + std::string line = line_buffer.substr(0, end);

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added a comment. I think this is looking pretty good. I like how the read/write methods look now. Just one more question about the PythonBuffer class. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1258-1265 + // you must check PyErr_Oc

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

labath added a comment. Some nits inline, otherwise it looks fine to me. Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:243 +template struct serializer_tag { + typedef typename std::conditional::value, ValueTag, NotImplementedTag>::type type; +}; -

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

grimar added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:111 + + explicit MemoryInfoListStream(std::vector Infos) + : Stream(StreamKind::MemoryInfoList, Maybe be more explicit here, i.e. ``` std::vector &&Infos ``` ? =

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

labath updated this revision to Diff 224065. labath marked 2 inline comments as done. labath added a comment. Address review comments Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68645/new/ https://reviews.llvm.org/D68645 Files: include/llvm/BinaryFormat/Minid

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

labath added inline comments. Comment at: lib/ObjectYAML/MinidumpEmitter.cpp:166 +Header.SizeOfEntry = sizeof(minidump::MemoryInfo); +Header.NumberOfEntries = InfoList.Infos.size(); +File.allocateNewObject(Header); grimar wrote: > Probably just > > `

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

dblaikie added a comment. In D68270#1700108 , @probinson wrote: > Do we care whether llvm-dwarfdump's output bears any similarities to the > output from GNU readelf or objdump? There has been a push lately to get the > LLVM "binutils" to behave more lik

[Lldb-commits] [lldb] r374180 - Remove the is_mangled flag from Mangled and Symbol

Author: adrian Date: Wed Oct 9 09:22:14 2019 New Revision: 374180 URL: http://llvm.org/viewvc/llvm-project?rev=374180&view=rev Log: Remove the is_mangled flag from Mangled and Symbol Testing whether a name is mangled or not is extremely cheap and can be done by looking at the first two character

[Lldb-commits] [PATCH] D68674: Remove the is_mangled flag from Mangled and Symbol

This revision was automatically updated to reflect the committed changes. Closed by commit rG939411c1aaa8: Remove the is_mangled flag from Mangled and Symbol (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D68674?vs=223965&id=224079#toc Re

[Lldb-commits] [lldb] r374184 - [test] Split LLDB tests into API, Shell & Unit

Added: lldb/trunk/test/Shell/SymbolFile/PDB/typedefs.test URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/Shell/SymbolFile/PDB/typedefs.test?rev=374184&view=auto == --- lldb/trunk/test/Shell/SymbolFile/PDB/typedef

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1258-1265 + // you must check PyErr_Occurred() after calling this constructor. + PythonBuffer(PythonObject &obj

[Lldb-commits] [lldb] r374185 - Remove obsolete parameter.

Author: adrian Date: Wed Oct 9 09:55:27 2019 New Revision: 374185 URL: http://llvm.org/viewvc/llvm-project?rev=374185&view=rev Log: Remove obsolete parameter. Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileEL

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

grimar accepted this revision. grimar added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68645/new/ https://reviews.llvm.org/D68645 ___ lldb-commits ma

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

shafik added a comment. `SymbolFile/Breakpad.symtab.test` is failing on green dragon cmake build see: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2378/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 added a comment. Any objections before I commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm added a comment. @shafik thanks, checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68533/new/ https://reviews.llvm.org/D68533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [PATCH] D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

jingham accepted this revision. jingham added a comment. One of the oddities of the Search -> Search callback stuff is that the Searcher's Filter might be narrower than the level at which the Search Callback wants to be invoked. The former is whatever the user actually wants limit the search t

[Lldb-commits] [lldb] r374187 - Revert [test] Split LLDB tests into API, Shell & Unit

Added: lldb/trunk/lit/helper/__init__.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/helper/__init__.py?rev=374187&view=auto == (empty) Added: lldb/trunk/lit/helper/build.py URL: http://llvm.org/viewvc/ll

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

aprantl added a comment. Please go ahead! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [PATCH] D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

jingham added a comment. I have no memory of adding the 'addr' parameter. If you had a search that was guaranteed to only return one address per invocation, this would allow you to have the searcher coordinate gathering the results, rather than having the callback record them on its own. That

[Lldb-commits] [lldb] r374192 - Update breakpad lit test to be independent of the unnamed symbol number

Author: aadsm Date: Wed Oct 9 11:02:59 2019 New Revision: 374192 URL: http://llvm.org/viewvc/llvm-project?rev=374192&view=rev Log: Update breakpad lit test to be independent of the unnamed symbol number Modified: lldb/trunk/lit/SymbolFile/Breakpad/symtab.test Modified: lldb/trunk/lit/Symbol

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm added a comment. @shafik I just pushed a fix, the issue was because on mac there are more unnamed symbols so the number didn't match, I changed it to match any number since this can easily change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D68719: Fix build with Visual Studio

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: hhb. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. The script failed to make a symlink for liblldb.dll because it tried to find it in //__build_root__/bin// whereas Visual

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

This revision was automatically updated to reflect the committed changes. Closed by commit rG89386daa9571: [LLDB] Fix for synthetic children memory leak (authored by cameron314). Changed prior to commit: https://reviews.llvm.org/D68641?vs=223919&id=224112#toc Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 224114. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. fixed pybuffer error handling weirdness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.l

[Lldb-commits] [lldb] r374197 - protect libedit and LLDB gui from receiving null FILE* streams

Author: lawrence_danna Date: Wed Oct 9 11:43:03 2019 New Revision: 374197 URL: http://llvm.org/viewvc/llvm-project?rev=374197&view=rev Log: protect libedit and LLDB gui from receiving null FILE* streams Summary: We now have valid files that will return NULL from GetStream(). libedit and the LLDB

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1284 + PythonBuffer(PythonObject &obj, int flags) : m_buffer({}) { +PyObject_GetBuffe

[Lldb-commits] [PATCH] D68677: protect libedit and LLDB gui from receiving null FILE* streams

This revision was automatically updated to reflect the committed changes. Closed by commit rG609010d0631a: protect libedit and LLDB gui from receiving null FILE* streams (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6867

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

lawrence_danna updated this revision to Diff 224119. lawrence_danna marked 4 inline comments as done. lawrence_danna added a comment. review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68622/new/ https://reviews.llvm.org/D68622 Files: ll

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. My hope was that something like -find=variable -dump-clang-ast would make sense at least from a theoretical perspective. However, after reading to source code, it looks like that may not be tr

[Lldb-commits] [PATCH] D68622: IOHandler: fall back on File::Read if a FILE* isn't available.

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68622/new/ https://reviews.llvm.org/D68622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 224122. lawrence_danna added a comment. Pavel would slightly prefer if the PyObject_GetBuffer happened in the Create function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llv

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade updated this revision to Diff 224120. guiandrade added a comment. Dissociating the use of g/G packets and trying to address the AVX/MPX offset bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.llvm.org/D62931

[Lldb-commits] [lldb] r374201 - Re-land "[test] Split LLDB tests into API, Shell & Unit"

Added: lldb/trunk/test/Shell/SymbolFile/PDB/typedefs.test URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/Shell/SymbolFile/PDB/typedefs.test?rev=374201&view=auto == --- lldb/trunk/test/Shell/SymbolFile/PDB/typedef

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade added a comment. In D62931#1699746 , @labath wrote: > In D62931#1697999 , @guiandrade > wrote: > > > Thank you for looking into this, @labath > > > > I'd like to fix that, but I'm not sure if I understan

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

dim created this revision. dim added reviewers: devnexen, emaste, MaskRay, mgorny. Herald added a subscriber: krytarowski. dim added a comment. After rLLDB365761 , and with `LLVM_ENABLE_ABI_BREAKING_CHECKS` enabled, launching any process on FreeBSD crashes ll

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

dim added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/ https://reviews.llvm.org/D68723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r374212 - [test] Skip entry value test when clang < 10.0.0

Author: vedantk Date: Wed Oct 9 13:21:33 2019 New Revision: 374212 URL: http://llvm.org/viewvc/llvm-project?rev=374212&view=rev Log: [test] Skip entry value test when clang < 10.0.0 clang-9 emitted the wrong opcode for entry values on Darwin. rdar://56119661 Modified: lldb/trunk/packages/

[Lldb-commits] [PATCH] D68678: WIP: Speed up accelerator table lookups

aprantl updated this revision to Diff 224140. aprantl added a comment. Now with testcase! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile lldb/packages/Python/ll

[Lldb-commits] [lldb] r374215 - [utils] Update lldb-dotest for new test layout

Author: jdevlieghere Date: Wed Oct 9 13:30:54 2019 New Revision: 374215 URL: http://llvm.org/viewvc/llvm-project?rev=374215&view=rev Log: [utils] Update lldb-dotest for new test layout The path to dotest.py changed after the test directory reorganization. Modified: lldb/trunk/utils/lldb-dot

[Lldb-commits] [lldb] r374216 - [CMake] Fix add_lldb_test_dependency

Author: jdevlieghere Date: Wed Oct 9 13:36:29 2019 New Revision: 374216 URL: http://llvm.org/viewvc/llvm-project?rev=374216&view=rev Log: [CMake] Fix add_lldb_test_dependency This function would ignore all but the first argument. Now it correctly adds every dependency by iterating over its argum

[Lldb-commits] [lldb] r374217 - Skip Apple simulator test for all remote testing scenarios.

Author: friss Date: Wed Oct 9 13:39:04 2019 New Revision: 374217 URL: http://llvm.org/viewvc/llvm-project?rev=374217&view=rev Log: Skip Apple simulator test for all remote testing scenarios. The test makes no sense to run remotely, period. The architecture of the target is not the discriminant h

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

shafik added a comment. This change broek the`TestDataFormatterInvalidStdUniquePtr.py` test, see: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2411/testReport/ I verified that reverting this commit fixes the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224145. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/TestCP

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

gmittert updated this revision to Diff 224147. gmittert added a comment. Updated/Rebased for the rename of lit->test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: test/CMakeLists.txt Index: test/CMakeLists.

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

gmittert updated this revision to Diff 224148. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 Files: test/CMakeLists.txt Index: test/CMakeLists.txt ===

[Lldb-commits] [PATCH] D68727: Allow pexpect tests to work in remote testsuite runs

friss created this revision. friss added reviewers: teemperor, labath. Herald added a project: LLDB. This commit adds platform selection/connection commands to the base PExpectTest class. I doesn't look like any of the current tests are really interesting to test remotely, but it's easy enough to

[Lldb-commits] [lldb] r374225 - allow arbitrary python streams to be converted to SBFile

Author: lawrence_danna Date: Wed Oct 9 13:56:17 2019 New Revision: 374225 URL: http://llvm.org/viewvc/llvm-project?rev=374225&view=rev Log: allow arbitrary python streams to be converted to SBFile Summary: This patch adds SWIG typemaps that can convert arbitrary python file objects into lldb_pri

[Lldb-commits] [lldb] r374226 - Revert "[lldb] Calculate relative path for symbol links"

Author: jingham Date: Wed Oct 9 13:56:43 2019 New Revision: 374226 URL: http://llvm.org/viewvc/llvm-project?rev=374226&view=rev Log: Revert "[lldb] Calculate relative path for symbol links" This reverts commit 958091c209d0a92e38b9cb27fb77a0ff7da11853. This commit incorrectly sets the _lldb.so s

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

This revision was automatically updated to reflect the committed changes. Closed by commit rG21b8a8ae27f3: allow arbitrary python streams to be converted to SBFile (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:114 + + // When searching for "std::vector::const_iterator", reject any + // files without "vector" early, since there will be many other This comment gives

[Lldb-commits] [lldb] r374229 - [LLDB] Remove standalone build dep on llvm-strip

Author: jdevlieghere Date: Wed Oct 9 14:06:03 2019 New Revision: 374229 URL: http://llvm.org/viewvc/llvm-project?rev=374229&view=rev Log: [LLDB] Remove standalone build dep on llvm-strip When building standalone, since llvm-strip is a symlink, it is created using add_custom_command/add_custom_ta

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

hhb updated this revision to Diff 224159. hhb added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68728/new/ https://reviews.llvm.org/D68728 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt ==

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

This revision was automatically updated to reflect the committed changes. Closed by commit rG988ad4194848: [LLDB] Remove standalone build dep on llvm-strip (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D68614?vs=224148&id=224160#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

hhb created this revision. hhb added a reviewer: tatyana-krasnukha. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb updated this revision to Diff 224159. hhb added a comment. Fix format Fixes issue like D68719 Repository: rG

[Lldb-commits] [PATCH] D68719: Fix build with Visual Studio

hhb added a comment. I think this is caused by D68442 . Can you check whether D68728 fixes it? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68719/new/ https://reviews.llvm.org/D68719 __

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224161. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/TestCP

[Lldb-commits] [PATCH] D68731: Remove CC autodetection from Makefile.rules

aprantl created this revision. aprantl added reviewers: friss, JDevlieghere, labath. Auto-detecting CC in Makefile.rules is no longer useful. Every since out-of-tree builds you are better off just running lldb-dotest which sets it directly. This also makes it harder to accidentally unset CC in a

[Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

cameron314 added a comment. I've committed a fix in rG745e57c5939e . Sorry about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68641/new/ https://reviews.llvm.org/D68641

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

hhb updated this revision to Diff 224166. hhb added a comment. Simplify the path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68728/new/ https://reviews.llvm.org/D68728 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt ===

[Lldb-commits] [lldb] r374195 - [LLDB] Fix for synthetic children memory leak

Author: cameron314 Date: Wed Oct 9 11:27:33 2019 New Revision: 374195 URL: http://llvm.org/viewvc/llvm-project?rev=374195&view=rev Log: [LLDB] Fix for synthetic children memory leak The lifetime of a ValueObject and all its derivative ValueObjects (children, clones, etc.) is managed by a Cluste

Re: [Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

Can you try a clean build as opposed to incremental? Before landing I checked that it worked for me for both a clean and incremental build, but it seems like at least GreenDragon had some issues with the incremental one. On Wed, Oct 9, 2019 at 10:27 AM Jan Kratochvil via Phabricator wrote: > > ja

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

jankratochvil added a comment. Before this patch I was getting : #rm -rf * cmake ~/redhat/llvm-monorepo2/llvm/ -DCMAKE_BUILD_TYPE=Release -DLLVM_USE_LINKER=gold -DLLVM_ENABLE_PROJECTS="lldb;clang;lld" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=c

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

JDevlieghere updated this revision to Diff 224072. JDevlieghere added a comment. Herald added a reviewer: alexshap. Rename `lit` to `test` to decrease the number of renames in the git history. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68606/new/ https://reviews.llvm.org/D68606 File

Re: [Lldb-commits] [PATCH] D68641: [LLDB] Fix for synthetic children memory leak

I'll have a look, sorry about that. On Wed, Oct 9, 2019 at 4:37 PM Shafik Yaghmour via Phabricator < revi...@reviews.llvm.org> wrote: > shafik added a comment. > > This change broek the`TestDataFormatterInvalidStdUniquePtr.py` test, see: > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/2

Re: [Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

I finally managed to reproduce and check-lldb was indeed broken. I've fixed it when re-landing the patch in r374201. On Wed, Oct 9, 2019 at 11:16 AM Jan Kratochvil wrote: > > On Wed, 09 Oct 2019 19:58:35 +0200, Jonas Devlieghere wrote: > > Can you try a clean build as opposed to incremental? > >

Re: [Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

On Wed, 09 Oct 2019 19:58:35 +0200, Jonas Devlieghere wrote: > Can you try a clean build as opposed to incremental? This is what I do, indicated by that: #rm -rf * (I did put there a # so that someone does not accidentally delete his whole world during a copy-paste.) It rather worked bef

[Lldb-commits] [lldb] r374231 - [LLDB] Fix for regression of test 'TestDataFormatterInvalidStdUniquePtr.py' introduced in r374195

Author: cameron314 Date: Wed Oct 9 14:15:48 2019 New Revision: 374231 URL: http://llvm.org/viewvc/llvm-project?rev=374231&view=rev Log: [LLDB] Fix for regression of test 'TestDataFormatterInvalidStdUniquePtr.py' introduced in r374195 Differential Revision: https://reviews.llvm.org/D68641 Modif

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

This revision was automatically updated to reflect the committed changes. Closed by commit rG22314179f066: [test] Split LLDB tests into API, Shell & Unit (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D68606?vs=224072&id=224087#toc Repository: rG LLVM Github Mo

[Lldb-commits] [lldb] r374234 - TestHelloWorld: Make compatible with remote testing

Author: friss Date: Wed Oct 9 14:41:02 2019 New Revision: 374234 URL: http://llvm.org/viewvc/llvm-project?rev=374234&view=rev Log: TestHelloWorld: Make compatible with remote testing The synchronization token handling was not remote-friendly. Modified: lldb/trunk/packages/Python/lldbsuite/

[Lldb-commits] [lldb] r374236 - [Reproducer] Add convenience methods IsCapturing and IsReplaying.

Author: jdevlieghere Date: Wed Oct 9 14:47:49 2019 New Revision: 374236 URL: http://llvm.org/viewvc/llvm-project?rev=374236&view=rev Log: [Reproducer] Add convenience methods IsCapturing and IsReplaying. Add convenience methods to the Reproducer class for when you don't need access to the genera

[Lldb-commits] [lldb] r374237 - SBFile: add a bunch of tests that should eventually work.

Author: lawrence_danna Date: Wed Oct 9 14:50:46 2019 New Revision: 374237 URL: http://llvm.org/viewvc/llvm-project?rev=374237&view=rev Log: SBFile: add a bunch of tests that should eventually work. Summary: It's really annoying and confusing to have to keep referring back to earlier versions of

[Lldb-commits] [lldb] r374239 - remove a smattering of isolated, unnecessary uses of FILE*

Author: lawrence_danna Date: Wed Oct 9 14:50:52 2019 New Revision: 374239 URL: http://llvm.org/viewvc/llvm-project?rev=374239&view=rev Log: remove a smattering of isolated, unnecessary uses of FILE* Summary: There a a few call sites that use FILE* which are easy to fix without disrupting anythin

[Lldb-commits] [lldb] r374238 - SBFile support in SBCommandReturnObject

Author: lawrence_danna Date: Wed Oct 9 14:50:49 2019 New Revision: 374238 URL: http://llvm.org/viewvc/llvm-project?rev=374238&view=rev Log: SBFile support in SBCommandReturnObject Summary: This patch add SBFile interfaces to SBCommandReturnObject, and removes the internal callers of its FILE* in

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

clayborg added a comment. That qualified name hash the Apple tables used to avoid pulling in DWARF for stuff that didn't match. Did this functionality stop working when accelerator tables got refactored? The .apple_types has a qualified name hash which is the hash of the complete type named (de

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added a parent revision: D68433: SBFile: add a bunch of tests that should eventually work.. This patch adds FileSP versions of SetInputFile(), Set

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb24022cd723f: SBFile: add a bunch of tests that should eventually work. (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D68433?vs=223979&id=224178#toc Repository: rG L

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

This revision was automatically updated to reflect the committed changes. Closed by commit rG9eb137192364: SBFile support in SBCommandReturnObject (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D68434?vs=223980&id=224179#toc Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

This revision was automatically updated to reflect the committed changes. Closed by commit rG5da2bc22badd: remove a smattering of isolated, unnecessary uses of FILE* (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/ne

[Lldb-commits] [lldb] r374242 - Fix a crasher due to an assert when two files have the same UUID but different paths.

Author: gclayton Date: Wed Oct 9 15:03:15 2019 New Revision: 374242 URL: http://llvm.org/viewvc/llvm-project?rev=374242&view=rev Log: Fix a crasher due to an assert when two files have the same UUID but different paths. Summary: The PlaceholderObjectFile has an assert in SetLoadAddress that fir

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a subscriber: aprantl. Herald added a project: LLDB. If you look at what this test is doing, it's actually quite mysterious why it works at all. It sets the input file inside a

[Lldb-commits] [PATCH] D68454: Fix the unwinding plan augmentation from x86 assembly

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Hi Jaroslav, I apologize for taking so long to look at this; I've been heads-down on a project the past few weeks an my email inbox is a disaster right now. This patch looks good,

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:97-102 + SBError SetInputFile(FileSP file); + + SBError SetOutputFile(FileSP file); + + SBError SetErrorFile(FileSP file); + Are these really for public consumption? I would hope no

  1   2   >