jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land.
Hi Jaroslav, I apologize for taking so long to look at this; I've been heads-down on a project the past few weeks an my email inbox is a disaster right now. This patch looks good, thanks for doing this. The fragile thing is that we have two methods doing very similar things -- GetNonCallSiteUnwindPlanFromAssembly() and AugmentUnwindPlanFromCallSite() -- and we've got some divergence between the two that make it harder to spot bugs like this. I can't remember the history well, but I have a feeling that AugmentUnwindPlanFromCallSite() is basically an older version of how GetNonCallSiteUnwindPlanFromAssembly() was written. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68454/new/ https://reviews.llvm.org/D68454 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
