[Lldb-commits] [PATCH] D67942: Install python dll to bin

hhb marked an inline comment as done. hhb added a comment. Arguably a correct python installation in windows should already have python*.dll. But then why do we copy the file to build dir above. Comment at: lldb/CMakeLists.txt:233 COMMENT "Copying Python DLL to LL

[Lldb-commits] [PATCH] D67942: Install python dll to bin

mstorsjo added a comment. Sorry, I'm not familiar with how LLDB integrates with python and how all of that works on Windows, so I can't really comment on this one for now... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67942/new/ https://reviews.

[Lldb-commits] [PATCH] D67903: [lldb] Add completion support for log enable/disable/list

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Utility/Log.cpp:49 + +void Log::ListCategories(llvm::raw_ostream &stream, + const ChannelMap::value_type &entry) { JDevlieghere wrote: > I

[Lldb-commits] [lldb] r372691 - [lldb] Add completion support for log enable/disable/list

Author: teemperor Date: Tue Sep 24 00:18:09 2019 New Revision: 372691 URL: http://llvm.org/viewvc/llvm-project?rev=372691&view=rev Log: [lldb] Add completion support for log enable/disable/list Reviewers: #lldb, JDevlieghere Reviewed By: JDevlieghere Subscribers: JDevlieghere, lldb-commits Tag

[Lldb-commits] [PATCH] D67903: [lldb] Add completion support for log enable/disable/list

This revision was automatically updated to reflect the committed changes. Closed by commit rL372691: [lldb] Add completion support for log enable/disable/list (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r372692 - [lldb] Remove redundant argument lists in CompletionRequest

Author: teemperor Date: Tue Sep 24 00:22:44 2019 New Revision: 372692 URL: http://llvm.org/viewvc/llvm-project?rev=372692&view=rev Log: [lldb] Remove redundant argument lists in CompletionRequest We currently have two lists in the CompletionRequest that we inherited from the old API: The complete

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

labath added a comment. Yeah, after writing the previous comment, I realized that you'll probably want to subclass File to implement the python stuff (which I agree is a good idea). So, going for unique_ptr is probably the best way forward here. Nonetheless, I still believe the return type of t

[Lldb-commits] [PATCH] D67943: documentation: update test.rst

labath accepted this revision. labath added a comment. This should have been done a long time ago, thanks for taking care of that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67943/new/ https://reviews.llvm.org/D67943 _

[Lldb-commits] [PATCH] D67942: Install python dll to bin

labath added a comment. Looking at the history goes provide us with some clues. It seems it was done to ensure that during development launching lldb uses the same python dll that the lldb was built with. However, this was done in the days when one had to buil

[Lldb-commits] [lldb] r372696 - [lldb] Fix log output and UtilityTests/LogChannelTest.List

Author: teemperor Date: Tue Sep 24 01:20:05 2019 New Revision: 372696 URL: http://llvm.org/viewvc/llvm-project?rev=372696&view=rev Log: [lldb] Fix log output and UtilityTests/LogChannelTest.List I refactored this code in 372691 and it seems I didn't fully replicate the original log output, so tha

[Lldb-commits] [lldb] r372700 - [LLDB] Avoid warnings about redefining posix mode defines on MinGW

Author: mstorsjo Date: Tue Sep 24 01:39:12 2019 New Revision: 372700 URL: http://llvm.org/viewvc/llvm-project?rev=372700&view=rev Log: [LLDB] Avoid warnings about redefining posix mode defines on MinGW Since these defines were added in LLVM SVN r189364 in 2013, mingw-w64 got defines for S_I?GRP,

[Lldb-commits] [lldb] r372699 - [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

Author: mstorsjo Date: Tue Sep 24 01:39:06 2019 New Revision: 372699 URL: http://llvm.org/viewvc/llvm-project?rev=372699&view=rev Log: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures While debugging on those architectures might not be supported yet, the generic code

[Lldb-commits] [lldb] r372701 - [lldb][NFC] Relax completion tests for log command to make them pass on Linux

Author: teemperor Date: Tue Sep 24 01:41:10 2019 New Revision: 372701 URL: http://llvm.org/viewvc/llvm-project?rev=372701&view=rev Log: [lldb][NFC] Relax completion tests for log command to make them pass on Linux The log channels change depending on platform, so listing them breaks on some platf

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rL372700: [LLDB] Avoid warnings about redefining posix mode defines on MinGW (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rL372699: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D66638: Unwind: Add a stack scanning mechanism to support win32 unwinding

labath added a comment. In D66638#1679440 , @clayborg wrote: > In D66638#1679195 , @labath wrote: > > > Thanks for the review and sorry for the delay (I was OOO). The idea to use > > `Process::GetLoadAddressPermiss

[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This is definitely right. I remember running into this in the past, but I don't remember whether I ended up not committing the fix, or is this another instance of that bug. In either case, it

[Lldb-commits] [PATCH] D67953: [LLDB] [test] Allow differing order of some matches

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, amccarth, hhb. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. These can appear in a different order depending on the relative layout of the source and build trees. Repository: rLLDB LLDB https

[Lldb-commits] [PATCH] D67951: [LLDB] Add tests for PECOFF arm architecture identification

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, amccarth, hhb. Herald added subscribers: JDevlieghere, abidh, kristof.beyls. Herald added a project: LLDB. Add a test case for the change from SVN r372657, and for the preexisting ARM identification. Add a missing ArchDe

[Lldb-commits] [PATCH] D67952: [LLDB] [test] Add a few missing cases of REQUIRES: python

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, amccarth, hhb. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67952 Files: lldb/lit/Commands/command-script-import.test lldb/lit/Reproducer/T

[Lldb-commits] [PATCH] D67953: [LLDB] [test] Allow differing order of some matches

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I would prefer if we could have a deterministic order in the list of files when dumping them (e.g. sorting by name), but I'm fine with landing this because this test is failing on all of

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

mstorsjo created this revision. mstorsjo added reviewers: labath, compnerd, amccarth, hhb, asmith. Herald added subscribers: JDevlieghere, abidh, kristof.beyls, mgorny. Herald added a project: LLDB. This seems to be enough for getting a backtrace and variable values for MinGW-built binaries for A

[Lldb-commits] [lldb] r372716 - [lldb] Decouple importing the std C++ module from the way the program is compiled

Author: teemperor Date: Tue Sep 24 03:08:18 2019 New Revision: 372716 URL: http://llvm.org/viewvc/llvm-project?rev=372716&view=rev Log: [lldb] Decouple importing the std C++ module from the way the program is compiled Summary: At the moment, when trying to import the `std` module in LLDB, we loo

[Lldb-commits] [PATCH] D67760: [lldb] Decouple importing the std C++ module from the way the program is compiled

This revision was automatically updated to reflect the committed changes. Closed by commit rL372716: [lldb] Decouple importing the std C++ module from the way the program is… (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

mstorsjo added a comment. > This seems to be enough for getting a backtrace and variable values for > MinGW-built binaries for ARM64. To clarify; this is binaries that use DWARF debug info. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67954/new/ https://revi

[Lldb-commits] [lldb] r372724 - [lldb][NFC] Use llvm::StringRef in formatters::NSStringSummaryProvider

Author: teemperor Date: Tue Sep 24 04:00:37 2019 New Revision: 372724 URL: http://llvm.org/viewvc/llvm-project?rev=372724&view=rev Log: [lldb][NFC] Use llvm::StringRef in formatters::NSStringSummaryProvider Modified: lldb/trunk/source/Plugins/Language/ObjC/NSString.cpp Modified: lldb/trunk/s

[Lldb-commits] [lldb] r372729 - [lldb] Use convert_to_slash in CppModuleConfiguration

Author: teemperor Date: Tue Sep 24 04:17:38 2019 New Revision: 372729 URL: http://llvm.org/viewvc/llvm-project?rev=372729&view=rev Log: [lldb] Use convert_to_slash in CppModuleConfiguration That's what we actually want to do. Might fix the Windows bot. Modified: lldb/trunk/source/Plugins/Exp

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

labath added a subscriber: aleksandr.urakov. labath added a comment. Have you considered going the "native" route directly? My understanding is that this route is already functional on x86 (modulo watchpoints, which I need to get around to reviewing). It would be great to be able to delete the i

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

mstorsjo added a comment. In D67954#1680536 , @labath wrote: > Have you considered going the "native" route directly? My understanding is > that this route is already functional on x86 (modulo watchpoints, which I > need to get around to reviewing). It w

[Lldb-commits] [lldb] r372736 - [lldb][NFC] Use default member initializers in ReadStringAndDumpToStreamOptions

Author: teemperor Date: Tue Sep 24 05:01:15 2019 New Revision: 372736 URL: http://llvm.org/viewvc/llvm-project?rev=372736&view=rev Log: [lldb][NFC] Use default member initializers in ReadStringAndDumpToStreamOptions Modified: lldb/trunk/include/lldb/DataFormatters/StringPrinter.h Modified: l

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

labath added a comment. This looks mostly fine to me. There's still a lot more copy-pasta between the three kinds of register contexts than I'd like (e.g. on linux, all of these three cases are handled by a single class), but I don't have a clear idea what to do about that at this point. ===

[Lldb-commits] [lldb] r372737 - [lldb] Also force posix paths in CppModuleConfigurationTest

Author: teemperor Date: Tue Sep 24 05:13:35 2019 New Revision: 372737 URL: http://llvm.org/viewvc/llvm-project?rev=372737&view=rev Log: [lldb] Also force posix paths in CppModuleConfigurationTest Modified: lldb/trunk/unittests/Expression/CppModuleConfigurationTest.cpp Modified: lldb/trunk/un

[Lldb-commits] [lldb] r372739 - [LLDB] [test] Add a few missing cases of REQUIRES: python

Author: mstorsjo Date: Tue Sep 24 05:20:33 2019 New Revision: 372739 URL: http://llvm.org/viewvc/llvm-project?rev=372739&view=rev Log: [LLDB] [test] Add a few missing cases of REQUIRES: python Differential Revision: https://reviews.llvm.org/D67952 Modified: lldb/trunk/lit/Commands/command-sc

[Lldb-commits] [lldb] r372741 - [LLDB] Add tests for PECOFF arm architecture identification

Author: mstorsjo Date: Tue Sep 24 05:20:52 2019 New Revision: 372741 URL: http://llvm.org/viewvc/llvm-project?rev=372741&view=rev Log: [LLDB] Add tests for PECOFF arm architecture identification Add a test case for the change from SVN r372657, and for the preexisting ARM identification. Add a mi

[Lldb-commits] [lldb] r372738 - [LLDB] Fix typo in RegisterContextDarwin_arm64

Author: mstorsjo Date: Tue Sep 24 05:20:21 2019 New Revision: 372738 URL: http://llvm.org/viewvc/llvm-project?rev=372738&view=rev Log: [LLDB] Fix typo in RegisterContextDarwin_arm64 In these cases, the register number should be calculated from fpu_d0, not fpu_s0. Differential Revision: https://r

[Lldb-commits] [lldb] r372740 - [LLDB] [test] Allow differing order of some matches

Author: mstorsjo Date: Tue Sep 24 05:20:38 2019 New Revision: 372740 URL: http://llvm.org/viewvc/llvm-project?rev=372740&view=rev Log: [LLDB] [test] Allow differing order of some matches These can appear in a different order depending on the relative layout of the source and build trees. Differe

[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

This revision was automatically updated to reflect the committed changes. Closed by commit rL372738: [LLDB] Fix typo in RegisterContextDarwin_arm64 (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[Lldb-commits] [PATCH] D67953: [LLDB] [test] Allow differing order of some matches

This revision was automatically updated to reflect the committed changes. Closed by commit rL372740: [LLDB] [test] Allow differing order of some matches (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [PATCH] D67952: [LLDB] [test] Add a few missing cases of REQUIRES: python

This revision was automatically updated to reflect the committed changes. Closed by commit rL372739: [LLDB] [test] Add a few missing cases of REQUIRES: python (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [PATCH] D67951: [LLDB] Add tests for PECOFF arm architecture identification

This revision was automatically updated to reflect the committed changes. Closed by commit rL372741: [LLDB] Add tests for PECOFF arm architecture identification (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67222: [Windows] Added support of watchpoints to `NativeProcessWindows`

labath added a comment. Btw, in the context of D67954 , I realized that I don't know how to actually enable the usage of lldb-server in lldb on windows. Can you share how you did that ? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] r372744 - Enhance SymbolFileDWARF::ParseDeclsForContext performance

Author: labath Date: Tue Sep 24 05:36:54 2019 New Revision: 372744 URL: http://llvm.org/viewvc/llvm-project?rev=372744&view=rev Log: Enhance SymbolFileDWARF::ParseDeclsForContext performance This implements DWARFASTParserClang::EnsureAllDIEsInDeclContextHaveBeenParsed so as to provide a faster wa

[Lldb-commits] [PATCH] D67022: Enhance SymbolFileDWARF::ParseDeclsForContext performance

labath closed this revision. labath added a comment. Herald added a subscriber: usaxena95. In D67022#1669298 , @guiandrade wrote: > Thank you, guys! Could you please submit it for me? Landed as r370374. Sorry about the delay. Repository: rG LLVM Gith

[Lldb-commits] [lldb] r372755 - [lldb] [Process/NetBSD] Fix handling LLDB_INVALID_SIGNAL_NUMBER

Author: mgorny Date: Tue Sep 24 06:41:54 2019 New Revision: 372755 URL: http://llvm.org/viewvc/llvm-project?rev=372755&view=rev Log: [lldb] [Process/NetBSD] Fix handling LLDB_INVALID_SIGNAL_NUMBER Fix NativeProcessNetBSD::Resume() to handle LLDB_INVALID_SIGNAL_NUMBER correctly. Fixes breakage ca

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

labath created this revision. labath added reviewers: jasonmolenda, aprantl, JDevlieghere, tatyana-krasnukha. Herald added subscribers: atanasyan, kbarton, mgorny, nemanjai. I was recently surprised to learn that there is a total of 2 (two) users of the register info definitions contained in the A

[Lldb-commits] [lldb] r372763 - [NFC] Fix typo in the "kind" description for the software single-step breakpoint

Author: tkrasnukha Date: Tue Sep 24 07:24:52 2019 New Revision: 372763 URL: http://llvm.org/viewvc/llvm-project?rev=372763&view=rev Log: [NFC] Fix typo in the "kind" description for the software single-step breakpoint Modified: lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp Mod

[Lldb-commits] [PATCH] D67966: Use llvm for dumping DWARF expressions

labath created this revision. labath added reviewers: JDevlieghere, aprantl, jasonmolenda. It uses the new ability of ABI plugins to vend llvm::MCRegisterInfo structs (which is what is needed to turn dwarf register numbers into strings). https://reviews.llvm.org/D67966 Files: include/lldb/Uti

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Honestly, this is just setting up the register context for ARM64. I dont think that there is much of a test for this. I mean, I suppose you could test this by instantiating the context a

[Lldb-commits] [PATCH] D67966: Use llvm for dumping DWARF expressions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This is great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67966/new/ https://reviews.llvm.org/D67966 ___ lldb-commits mai

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

JDevlieghere added inline comments. Comment at: source/Target/ABI.cpp:216 + +std::unique_ptr ABI::MakeMCRegisterInfo(const ArchSpec &arch) { + std::string triple = arch.GetTriple().getTriple(); Should this return an llvm::Expected instead? I understand it will

[Lldb-commits] [PATCH] D67954: [LLDB] [Windows] Initial support for ARM64 debugging

labath added a comment. In D67954#1680893 , @compnerd wrote: > Honestly, this is just setting up the register context for ARM64. I dont > think that there is much of a test for this. I mean, I suppose you could > test this by instantiating the context

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

kwk added a comment. @clayborg @labath I'm still trying to only add symbols when they are unique. Take this already existing test: ./bin/llvm-lit -avv ~/llvm-project/lldb/lit/SymbolFile/DWARF/debug-types-line-tables.s The symbols that are being added at the end of `ObjectFileELF::ParseSymbol

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

tatyana-krasnukha added inline comments. Comment at: include/lldb/Target/ABI.h:141 protected: - // Classes that inherit from ABI can see and modify these - ABI(lldb::ProcessSP process_sp) { -if (process_sp.get()) -m_process_wp = process_sp; + ABI(lldb::ProcessSP p

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

jankratochvil added a comment. In D67390#1681034 , @kwk wrote: > I wonder how to define uniqueness for them. As you can see, the only > difference is the symbol section which wasn't part of your definition of > uniqueness (yet). These symbols should

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

labath marked an inline comment as done. labath added inline comments. Comment at: source/Target/ABI.cpp:216 + +std::unique_ptr ABI::MakeMCRegisterInfo(const ArchSpec &arch) { + std::string triple = arch.GetTriple().getTriple(); JDevlieghere wrote: > Should thi

[Lldb-commits] [PATCH] D67972: [unittest] Skip the socket tests if we $TMPDIR is too long.

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. Herald added a subscriber: abidh. Herald added a project: LLDB. Adrian added a sanity check to the socket tests to ensure the $TMPDIR is not to long for a socket. While this is great for diagnosing the problem it doesn't

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

mgorny updated this revision to Diff 221555. mgorny marked 8 inline comments as done. mgorny retitled this revision from "[lldb] [cmake] Unify and correct Python module installation paths" to "[lldb] [cmake] Fix installing Python modules on systems using /usr/lib". mgorny edited the summary of th

[Lldb-commits] [PATCH] D67966: Use llvm for dumping DWARF expressions

aprantl added a comment. Awesome! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67966/new/ https://reviews.llvm.org/D67966 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

aprantl added inline comments. Comment at: source/Plugins/ABI/CMakeLists.txt:1 -add_subdirectory(SysV-arm) -add_subdirectory(SysV-arm64) -add_subdirectory(SysV-hexagon) -add_subdirectory(SysV-ppc) -add_subdirectory(SysV-ppc64) -add_subdirectory(SysV-mips) -add_subdirectory(SysV-m

[Lldb-commits] [lldb] r372774 - [unittest] Skip the socket tests if we $TMPDIR is too long.

Author: jdevlieghere Date: Tue Sep 24 12:34:50 2019 New Revision: 372774 URL: http://llvm.org/viewvc/llvm-project?rev=372774&view=rev Log: [unittest] Skip the socket tests if we $TMPDIR is too long. Adrian added a sanity check to the socket tests to ensure the $TMPDIR is not too long for a socket

[Lldb-commits] [PATCH] D67972: [unittest] Skip the socket tests if we $TMPDIR is too long.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372774: [unittest] Skip the socket tests if we $TMPDIR is too long. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [PATCH] D67965: Have ABI plugins vend llvm MCRegisterInfo data

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67965/new/ https://reviews.llvm.org/D67965 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

aprantl created this revision. aprantl added reviewers: jasonmolenda, JDevlieghere, labath. Herald added subscribers: arphaman, christof. This test streamlines our use of variables that are expected by Makefile.rules throughout the test suite. Mostly it replaced potentially dangerous overrides a

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

aprantl updated this revision to Diff 221592. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67984/new/ https://reviews.llvm.org/D67984 Files: lldb/packages/Python/lldbsuite/test/arm/breakpoint-it/Makefile lldb/packages/Python/lldbsuite/test/arm/breakpoint-thumb-codesection/Makefile

[Lldb-commits] [PATCH] D67988: [lldb] clean up lldb/scripts a little bit

hhb created this revision. hhb added reviewers: labath, mgorny. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. No functional change. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67988 Files: lldb/scripts/Python/finishSwigPythonLLDB.py lldb/scripts

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

JDevlieghere added a comment. A few things that need checking/reordering, but otherwise great cleanup! Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/vbool/Makefile:4 include Makefile.rules -CXXFLAGS += -O0 +CXXFLAGS_E

[Lldb-commits] [PATCH] D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

JDevlieghere created this revision. JDevlieghere added reviewers: friss, xiaobai, aprantl. Herald added a subscriber: mgorny. Herald added a project: LLDB. r366433 broke support for the system debugserver. Although the change was well-intended, it (presumably) unintentionally removed the logic to

[Lldb-commits] [PATCH] D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

JDevlieghere updated this revision to Diff 221611. JDevlieghere added a comment. Herald added a reviewer: jfb. Add decorator to tests that require a more recent debugserver. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67991/new/ https://reviews.llvm.org/D67991 Files: lldb/packages

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

aprantl added a comment. I checked, and Makefile.rules does initialize CXXFLAGS lazily, but it's still better to not depend on that implementation detail. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67984/new/ https://reviews.llvm.org/D67984 ___

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

hhb created this revision. hhb added reviewers: labath, mgorny. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This replaces the hard coded path. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67993 Files: lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [PATCH] D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

xiaobai added inline comments. Herald added a subscriber: dexonsmith. Comment at: lldb/test/CMakeLists.txt:103 + ${system_debugserver_path} ${LLVM_RUNTIME_OUTPUT_INTDIR} + COMMENT "Copying the system debugserver to LLDB's binaries directory for testing.") message(

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

aprantl updated this revision to Diff 221613. aprantl added a comment. Address feedback from Jonas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67984/new/ https://reviews.llvm.org/D67984 Files: lldb/packages/Python/lldbsuite/test/arm/breakpoint-it/Makefile lldb/packages/Python/ll

[Lldb-commits] [PATCH] D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/test/CMakeLists.txt:103 + ${system_debugserver_path} ${LLVM_RUNTIME_OUTPUT_INTDIR} + COMMENT "Copying the system debugserver to LLDB's binaries directory for testing.")

[Lldb-commits] [lldb] r372786 - [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

Author: jdevlieghere Date: Tue Sep 24 15:39:04 2019 New Revision: 372786 URL: http://llvm.org/viewvc/llvm-project?rev=372786&view=rev Log: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER r366433 broke support for the system debugserver. Although the change was well

[Lldb-commits] [PATCH] D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. No objections from me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67991/new/ https://reviews.llvm.org/D67991 ___ lldb-commits maili

[Lldb-commits] [PATCH] D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

This revision was automatically updated to reflect the committed changes. Closed by commit rL372786: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ch

[Lldb-commits] [lldb] r372788 - Host: use the platform identifiers from LLVM (NFC)

Author: compnerd Date: Tue Sep 24 15:55:44 2019 New Revision: 372788 URL: http://llvm.org/viewvc/llvm-project?rev=372788&view=rev Log: Host: use the platform identifiers from LLVM (NFC) Use symbolic constants for the platform identifiers rather than replicating them locally. Modified: lldb/t

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

shafik created this revision. shafik added reviewers: labath, JDevlieghere, xiaobai, aam, amccarth. Herald added a subscriber: aprantl. shafik marked an inline comment as done. shafik added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3060 + +

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

shafik marked an inline comment as done. shafik added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3060 + +switch (tag) { + case DW_TAG_array_type: I added this change because currently when end up trying to parse non-

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

vsk added inline comments. Comment at: clang/lib/AST/Mangle.cpp:130 + return; +} + rjmccall wrote: > This is actually backwards, right? A literal label is one that doesn't get > the global prefix and therefore potentially needs the `\01` prefix to > s

[Lldb-commits] [PATCH] D67991: [CMake] Copy over the system debugserver when using LLDB_USE_SYSTEM_DEBUGSERVER

aprantl added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentManyBreakpoints.py:18 @expectedFailureNetBSD +@skipIfOutOfTreeDebugserver def test(self): It may be more for

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

xiaobai added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3029 Log *log = LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_INFO); - TypeSP type_sp = dwarf_ast->ParseTypeFromDWARF(sc, die, log, type_is_new_ptr); + + TypeSP type_sp; --

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. lawrence_danna added a project: LLDB. This patch converts FileSystem::Open from this prototype: Status Open(File &File, const FileSpec &file_spec, ...); to this one: llvm::Expected> Open(co

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

shafik updated this revision to Diff 221622. shafik added a comment. - Formatting code - Removing FunctionDecl case since it was not correct CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67994/new/ https://reviews.llvm.org/D67994 Files: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

JDevlieghere added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3029 Log *log = LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_INFO); - TypeSP type_sp = dwarf_ast->ParseTypeFromDWARF(sc, die, log, type_is_new_ptr); + + TypeSP type_sp; -

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3032 + + type_sp = dwarf_ast->ParseTypeFromDWARF(sc, die, log, type_is_new_ptr); if (type_sp) { indent is wrong Comment at: source/Plugin

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 221621. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. converted to Expected, and split into two separate patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/n

[Lldb-commits] [PATCH] D67994: [WIP] Modify lldb-test to print out ASTs from symbol file

aprantl added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3077 + ParseType(sc, die, &type_is_new).get(); + printf( "pubname: %s is_type = %d\n", die.GetPubname(), true); + break; You also probably do

[Lldb-commits] [PATCH] D67943: documentation: update test.rst

lawrence_danna updated this revision to Diff 221625. lawrence_danna added a comment. added note about passing --filter to lit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67943/new/ https://reviews.llvm.org/D67943 Files: lldb/docs/resources/tes

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 221627. lawrence_danna added a comment. changed unique_ptr to shared_ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

rjmccall added inline comments. Comment at: clang/lib/AST/Mangle.cpp:130 + return; +} + vsk wrote: > rjmccall wrote: > > This is actually backwards, right? A literal label is one that doesn't get > > the global prefix and therefore potentially needs th

[Lldb-commits] [lldb] r372793 - [CMake] Don't try to install the system debugserver.

Author: jdevlieghere Date: Tue Sep 24 17:21:31 2019 New Revision: 372793 URL: http://llvm.org/viewvc/llvm-project?rev=372793&view=rev Log: [CMake] Don't try to install the system debugserver. The custom target for the system debugserver has no install target, so we need to remove it from the LLVM

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67984/new/ https://reviews.llvm.org/D67984 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D67984: Canonicalize variable usage in testsuite Makefiles

This revision was automatically updated to reflect the committed changes. Closed by commit rL372795: Canonicalize variable usage in testsuite Makefiles (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/API/SBFile.cpp:20-26 +void SBFile::SetStream(FILE *file, bool transfer_ownership) { +m_opaque_up = std::make_unique(file, transfer_ownership); +} + +void SBFile::Set

[Lldb-commits] [lldb] r372797 - [Documentation] Expand on testing variants.

Author: jdevlieghere Date: Tue Sep 24 17:58:39 2019 New Revision: 372797 URL: http://llvm.org/viewvc/llvm-project?rev=372797&view=rev Log: [Documentation] Expand on testing variants. The testing documentation appears to be from an era when the only kind of tests were the lldbsuite python tests. T

[Lldb-commits] [PATCH] D67943: documentation: update test.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rL372797: [Documentation] Expand on testing variants. (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[Lldb-commits] [PATCH] D68001: remove unused method ResetOutputFileHandle()

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. ResetOutputFileHandle() isn't being used by anything. Also it's using FILE*, which is something we should be doing less of. Remove it. Repository: rG LLVM

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

vsk updated this revision to Diff 221645. vsk retitled this revision from "[Mangle] Add flag to asm labels to disable global prefixing" to "[Mangle] Add flag to asm labels to disable '\01' prefixing". vsk edited the summary of this revision. vsk added a comment. - Address latest round of comment

[Lldb-commits] [PATCH] D68003: [dotest] Support specifying a version for skipIfOutOfTreeDebugserver

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, labath. Herald added a subscriber: mgorny. Herald added a reviewer: jfb. Herald added a project: LLDB. The `skipIfOutOfTreeDebugserver` decorator is meant to skip tests that exercise functionalities that may not be present

  1   2   >