JDevlieghere added inline comments.
================
Comment at: source/Target/ABI.cpp:216
+
+std::unique_ptr<llvm::MCRegisterInfo> ABI::MakeMCRegisterInfo(const ArchSpec
&arch) {
+ std::string triple = arch.GetTriple().getTriple();
----------------
Should this return an llvm::Expected instead? I understand it will cause a lot
of churn around the call sites, but now if this fails it will trigger an assert
in the ABI constructor?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67965/new/
https://reviews.llvm.org/D67965
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits