[Lldb-commits] [lldb] r372652 - File::SetDescriptor() should require options

Author: jdevlieghere Date: Mon Sep 23 13:36:46 2019 New Revision: 372652 URL: http://llvm.org/viewvc/llvm-project?rev=372652&view=rev Log: File::SetDescriptor() should require options lvm_private::File::GetStream() can fail if m_options == 0 It's not clear from the header a File created with a d

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

compnerd added a comment. I think that `printf` is quite an amazing notification :-) Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:87 case 4: #if defined(__x86_64__) || defined(_M_AMD64) case 8: mstorsjo wrote: > comp

[Lldb-commits] [PATCH] D67792: File::SetDescriptor() should require options

This revision was automatically updated to reflect the committed changes. Closed by commit rL372652: File::SetDescriptor() should require options (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[Lldb-commits] [lldb] r372656 - [LLDB] Rework a MinGW build fix from D65691

Author: mstorsjo Date: Mon Sep 23 13:43:11 2019 New Revision: 372656 URL: http://llvm.org/viewvc/llvm-project?rev=372656&view=rev Log: [LLDB] Rework a MinGW build fix from D65691 That change didn't contain any explanation for this bit. There shouldn't be any need for a check for MinGW ifdefs here

[Lldb-commits] [lldb] r372657 - [LLDB] [PECOFF] Recognize arm64 executables

Author: mstorsjo Date: Mon Sep 23 13:43:16 2019 New Revision: 372657 URL: http://llvm.org/viewvc/llvm-project?rev=372657&view=rev Log: [LLDB] [PECOFF] Recognize arm64 executables Differential Revision: https://reviews.llvm.org/D67912 Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/Obje

[Lldb-commits] [lldb] r372658 - [LLDB] [Windows] Map COFF ARM machine ids to the right triple architectures

Author: mstorsjo Date: Mon Sep 23 13:43:22 2019 New Revision: 372658 URL: http://llvm.org/viewvc/llvm-project?rev=372658&view=rev Log: [LLDB] [Windows] Map COFF ARM machine ids to the right triple architectures Differential Revision: https://reviews.llvm.org/D67913 Modified: lldb/trunk/sourc

[Lldb-commits] [PATCH] D67913: [LLDB] [Windows] Map COFF ARM machine ids to the right triplet architectures

This revision was automatically updated to reflect the committed changes. Closed by commit rL372658: [LLDB] [Windows] Map COFF ARM machine ids to the right triple architectures (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[Lldb-commits] [PATCH] D67912: [LLDB] [PECOFF] Recognize arm64 executables

This revision was automatically updated to reflect the committed changes. Closed by commit rL372657: [LLDB] [PECOFF] Recognize arm64 executables (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

This revision was automatically updated to reflect the committed changes. Closed by commit rL372656: [LLDB] Rework a MinGW build fix from D65691 (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo added a comment. In D67911#1679696 , @compnerd wrote: > I think that `printf` is quite an amazing notification :-) Ok, I'll make it an `LLDB_LOG` then, as I'd presume using raw printfs isn't really allowed :-) Repository: rLLDB LLDB CHANGE

[Lldb-commits] [PATCH] D67911: [LLDB] [Windows] Add missing ifdefs to fix building for non-x86 architectures

mstorsjo updated this revision to Diff 221406. mstorsjo added a comment. Added a log message, changed an `x86_64` ifdef into `_WIN64`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67911/new/ https://reviews.llvm.org/D67911 Files: lldb/source/Plugins/Process/Windows/Common/RegisterCo

[Lldb-commits] [PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

rjmccall added inline comments. Comment at: clang/include/clang/Basic/Attr.td:734 +// TODO: Make it possible to specify this in source. +BoolArgument<"LiteralLabel"> + ]; `LiteralLabel` is an unfortunate name for this property because `getLiteralLabel`

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

hhb added inline comments. Comment at: lldb/scripts/Python/prepare_binding_Python.py:284 +module_path = options.python_relative_path +if module_path is None: +from distutils.sysconfig import get_python_lib Just bail out in this situati

[Lldb-commits] [PATCH] D67776: Use UnixSignals::ShouldSuppress to filter out signals a process expects

jingham added a comment. Pavel's example shows why these two choices might be better separated. If you are using __builtin_trap to implement a stop when in the debugger of some sort, it seems likely you would want to suppress the signal, but it also seems likely that when you are running in b

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

hhb added inline comments. Comment at: lldb/scripts/Python/prepare_binding_Python.py:284 +module_path = options.python_relative_path +if module_path is None: +from distutils.sysconfig import get_python_lib hhb wrote: > Just bail out in

[Lldb-commits] [lldb] r372669 - [Make] Add support for building NeXT-style frameworks

Author: jdevlieghere Date: Mon Sep 23 15:31:16 2019 New Revision: 372669 URL: http://llvm.org/viewvc/llvm-project?rev=372669&view=rev Log: [Make] Add support for building NeXT-style frameworks This patch extends the Makefile.rules to build NeXT-style frameworks. It also fixes a bug in the clean l

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

hhb accepted this revision. hhb added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Host/windows/PosixApi.h:39 #endif +#ifndef S_IRGRP #define S_IRGRP 0 /* read, group */ Maybe move these into the defined(_MSC_V

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna added a comment. @labath How's it look now? I made FileSystem::Open return a unique_ptr, and only convert that over to a shared_ptr where necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 221431. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. converted many uses of shared_ptr into unique_ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ http

[Lldb-commits] [lldb] r372677 - Adapt test to upstream clang compiler changes.

Author: adrian Date: Mon Sep 23 17:27:13 2019 New Revision: 372677 URL: http://llvm.org/viewvc/llvm-project?rev=372677&view=rev Log: Adapt test to upstream clang compiler changes. Clang now emits the correct C++ language version in DWARF. Modified: lldb/trunk/packages/Python/lldbsuite/test/

[Lldb-commits] [PATCH] D67942: Install python dll to bin

hhb created this revision. hhb added a reviewer: mstorsjo. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Not sure whether this is a feature or bug... Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67942 Files: lldb/CMakeLists.txt Index: lldb

[Lldb-commits] [PATCH] D67943: documentation: update test.rst

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. The testing documentation appears to be from an era when the only kind of tests were the lldbsuite python tests. This patch adds a short description of the unit

[Lldb-commits] [PATCH] D67943: documentation: update test.rst

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/docs/resources/test.rst:126 + + > ./bin/llvm-lit -sv tools/lldb/lit/Commands/CommandScriptImmediateOutput + Another altern

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lldb/include/lldb/Host/windows/PosixApi.h:39 #endif +#ifndef S_IRGRP #define S_IRGRP 0 /* read, group */ hhb wrote: > Maybe move these into the defined(_MSC_VER) above? Or th

[Lldb-commits] [PATCH] D67912: [LLDB] [PECOFF] Recognize arm64 executables

labath added a comment. Since this (unlike most of your other patches in this series) is definitely adding new functionality, it would be good to accompany it with a test. The simplest way to do that should be via something like `yaml2obj && lldb-test object-file | FileCheck`. I'd recommend loo

[Lldb-commits] [lldb] r372690 - Ignore generated @import statements in the expression evaluator

Author: teemperor Date: Mon Sep 23 23:58:39 2019 New Revision: 372690 URL: http://llvm.org/viewvc/llvm-project?rev=372690&view=rev Log: Ignore generated @import statements in the expression evaluator Summary: The ClangModulesDeclVendor is currently interpreting all injected `@import` statements

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

labath added reviewers: amccarth, ted. labath added a comment. This is looking very good to me. Adding some windows folks to help with trying this out on that platform. Comment at: lldb/scripts/Python/prepare_binding_Python.py:284 +module_path = options.python_relative

[Lldb-commits] [PATCH] D61565: Ignore generated @import statements in the expression evaluator

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372690: Ignore generated @import statements in the expression evaluator (authored by teemperor, committed by ). Herald add

<    1   2