[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

kwk updated this revision to Diff 198987. kwk added a comment. - Fix https://reviews.llvm.org/D61737#inline-548136 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61737/new/ https://reviews.llvm.org/D61737 Files: lldb/tools/driver/Options.td Ind

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

kwk added a comment. In D61737#1497202 , @jingham wrote: > I would rather not clutter up the lldb command driver's options with gdb > command flags. That seems like it will make lldb harder to figure out and > reduce our freedom to choose reasonable sho

[Lldb-commits] [PATCH] D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan

labath added a comment. In D61732#1497609 , @jasonmolenda wrote: > I'm not super concerned about the size of the UnwindPlan or FuncUnwinders > objects - we create them lazily as we unwind through functions in the > process, so my guess is that even a lo

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

echristo added a comment. In D61737#1497202 , @jingham wrote: > I would rather not clutter up the lldb command driver's options with gdb > command flags. That seems like it will make lldb harder to figure out and > reduce our freedom to choose reasonabl

[Lldb-commits] [lldb] r360409 - FuncUnwinders: Add a new "SymbolFile" unwind plan

Author: labath Date: Fri May 10 00:54:37 2019 New Revision: 360409 URL: http://llvm.org/viewvc/llvm-project?rev=360409&view=rev Log: FuncUnwinders: Add a new "SymbolFile" unwind plan Summary: some unwind formats are specific to a single symbol file and so it does not make sense for their parsing

[Lldb-commits] [PATCH] D61732: FuncUnwinders: Add a new "SymbolFile" unwind plan

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB360409: FuncUnwinders: Add a new "SymbolFile" unwind plan (authored by labath, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

teemperor added a comment. In D61737#1497785 , @kwk wrote: > In D61737#1497202 , @jingham wrote: > > > I would rather not clutter up the lldb command driver's options with gdb > > command flags. That seems like it

[Lldb-commits] [PATCH] D61779: FuncUnwinders: General clean up and optimization

labath created this revision. labath added reviewers: jasonmolenda, clayborg. A large chunk of this file was dealing with the caching of unwind plans. In this patch I create a helper class to encapsulate this behavior and leave the functions to deal with the actual work, which is to compute the ac

Re: [Lldb-commits] Fwd: buildbot failure in LLVM on lldb-x64-windows-ninja

On 10/05/2019 00:20, Greg Clayton via lldb-commits wrote: Can anyone that builds the windows lldb compile the following file as the test suite would: trunk/packages/Python/lldbsuite/test/python_api/thread/main2.cpp and send me the binary that is produced by the test suite? I see the windows b

[Lldb-commits] [PATCH] D61733: Breakpad: Generate unwind plans from STACK CFI records

labath marked 3 inline comments as done. labath added inline comments. Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:472 + if (!unwind_rules.empty()) +LLDB_LOG(log, "Could not parse `{0}` as an unwind rule.", unwind_rules); + return true; ---

[Lldb-commits] [PATCH] D61733: Breakpad: Generate unwind plans from STACK CFI records

labath updated this revision to Diff 198993. labath added a comment. - use a yaml form of the minidump file (as it is possible to do that as of today) - fix the CHECK-NOT directives in the test and the two issues they caught - found a way to trigger one of the asserts with an invalid input, so I

[Lldb-commits] [lldb] r360412 - Minidump: use ThreadList parsing code from llvm/Object

Author: labath Date: Fri May 10 02:36:11 2019 New Revision: 360412 URL: http://llvm.org/viewvc/llvm-project?rev=360412&view=rev Log: Minidump: use ThreadList parsing code from llvm/Object Modified: lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp lldb/trunk/source/Plugins/Pro

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

kwk added a comment. @teemperor Do you recommend me to work on support for GDB's `--args` parameter then and ditch this review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61737/new/ https://reviews.llvm.org/D61737 ___

[Lldb-commits] [PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

martong marked an inline comment as done. martong added inline comments. Comment at: clang/include/clang/AST/ASTImporter.h:203 /// context, or the import error. -llvm::Expected Import_New(TypeSourceInfo *FromTSI); -// FIXME: Remove this version. -TypeSourceInfo *

[Lldb-commits] [PATCH] D61783: [DWARF] Use sequential integers for the IDs of the SymbolFileDWOs

labath created this revision. labath added reviewers: JDevlieghere, clayborg, aprantl. Herald added subscribers: dexonsmith, mehdi_amini. Instead of using the offset of the contained compile unit, we use it's ID. The goal of this change is two-fold: - free up space in the user_id_t representation

[Lldb-commits] [lldb] r360423 - [lldb] [lit] Fix clobbers in x86_64 register test

Author: mgorny Date: Fri May 10 06:12:36 2019 New Revision: 360423 URL: http://llvm.org/viewvc/llvm-project?rev=360423&view=rev Log: [lldb] [lit] Fix clobbers in x86_64 register test Modified: lldb/trunk/lit/Register/Inputs/x86-64-write.cpp Modified: lldb/trunk/lit/Register/Inputs/x86-64-wri

[Lldb-commits] [PATCH] D61779: FuncUnwinders: General clean up and optimization

clayborg added inline comments. Comment at: include/lldb/Symbol/FuncUnwinders.h:117 + class LazyPlan { +lldb::UnwindPlanSP m_plan_sp; + maybe use: ``` llvm::Optional m_plan_sp; ``` Then just check if it has no value, and if so compute and set it either to

[Lldb-commits] [PATCH] D61783: [DWARF] Use sequential integers for the IDs of the SymbolFileDWOs

clayborg added a comment. Might want the person that did DWO support to chime in here if that wasn't you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61783/new/ https://reviews.llvm.org/D61783 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D61779: FuncUnwinders: General clean up and optimization

labath marked an inline comment as done. labath added inline comments. Comment at: include/lldb/Symbol/FuncUnwinders.h:117 + class LazyPlan { +lldb::UnwindPlanSP m_plan_sp; + clayborg wrote: > maybe use: > > ``` > llvm::Optional m_plan_sp; > ``` > > Then j

[Lldb-commits] [PATCH] D61779: FuncUnwinders: General clean up and optimization

clayborg added inline comments. Comment at: include/lldb/Symbol/FuncUnwinders.h:117 + class LazyPlan { +lldb::UnwindPlanSP m_plan_sp; + labath wrote: > clayborg wrote: > > maybe use: > > > > ``` > > llvm::Optional m_plan_sp; > > ``` > > > > Then just check

[Lldb-commits] [PATCH] D61783: [DWARF] Use sequential integers for the IDs of the SymbolFileDWOs

labath added a comment. It was @tberghammer. I'm cc-ing him to these patches, but I'm not sure what's his state these days... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61783/new/ https://reviews.llvm.org/D61783 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D61779: FuncUnwinders: General clean up and optimization

clayborg added inline comments. Comment at: include/lldb/Symbol/FuncUnwinders.h:117 + class LazyPlan { +lldb::UnwindPlanSP m_plan_sp; + clayborg wrote: > labath wrote: > > clayborg wrote: > > > maybe use: > > > > > > ``` > > > llvm::Optional m_plan_sp; > >

[Lldb-commits] [PATCH] D61779: FuncUnwinders: General clean up and optimization

labath marked an inline comment as done. labath added inline comments. Comment at: include/lldb/Symbol/FuncUnwinders.h:117 + class LazyPlan { +lldb::UnwindPlanSP m_plan_sp; + clayborg wrote: > clayborg wrote: > > labath wrote: > > > clayborg wrote: > > > > m

[Lldb-commits] [lldb] r360432 - minidump: Don't eagerly resolve module paths read from the minidump

Author: labath Date: Fri May 10 08:05:26 2019 New Revision: 360432 URL: http://llvm.org/viewvc/llvm-project?rev=360432&view=rev Log: minidump: Don't eagerly resolve module paths read from the minidump This can cause us to return paths to files on the local filesystem even if we don't end up using

[Lldb-commits] [lldb] r360443 - Finish renaming CompileUnit -> Unit

Author: jankratochvil Date: Fri May 10 10:14:37 2019 New Revision: 360443 URL: http://llvm.org/viewvc/llvm-project?rev=360443&view=rev Log: Finish renaming CompileUnit -> Unit D42892 changed a lot of code to use superclass DWARFUnit instead of its subclass DWARFCompileUnit. Finish this change mo

[Lldb-commits] [PATCH] D61501: 02/06: Finish renaming CompileUnit->Unit

This revision was automatically updated to reflect the committed changes. Closed by commit rL360443: Finish renaming CompileUnit -> Unit (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

jingham added a comment. If you really are going to support many languages you need to figure out how to tell folks what really happened with more specificity. For instance, you can use C++ to throw anything, so you could throw an ObjC object from a C++ exception throw. So you need to disting

[Lldb-commits] [PATCH] D61501: 02/06: Finish renaming CompileUnit->Unit

jankratochvil added a comment. Thanks for the review, I have pushed it ahead of the rest of the series as it was a bit annoying to keep it updating off-trunk. And then the renaming is a correct cleanup anyway. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61501/n

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

jingham added a comment. I really don't want to pollute the lldb driver options with gdb equivalents (or really any duplicate spellings of already present functionality). For the lldb command line, I want us to have the freedom to do the best job of making the lldb options consistent and easy

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

jankratochvil added a comment. In D61737#1498297 , @jingham wrote: > If you have simple gdb startup commands then translating them into the lldb > way should be straightforward, and the burden of learning how lldb works from > the command line for these

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai added a comment. In D61776#1498225 , @jingham wrote: > If you really are going to support many languages you need to figure out how > to tell folks what really happened with more specificity. I agree. > For instance, you can use C++ to throw an

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. With appropriate comments, this seems fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61776/new/ https://reviews.llvm.org/D61776 _

[Lldb-commits] [PATCH] D61776: [Target] Generalize some behavior in Thread

xiaobai updated this revision to Diff 199048. xiaobai added a comment. Add comments to give better context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61776/new/ https://reviews.llvm.org/D61776 Files: source/Target/Thread.cpp Index: source/Target/Thread.cpp ==

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

jingham added a comment. In D61737#1498329 , @jankratochvil wrote: > In D61737#1498297 , @jingham wrote: > > > If you have simple gdb startup commands then translating them into the lldb > > way should be straight

[Lldb-commits] [PATCH] D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo()

shafik created this revision. shafik added reviewers: friss, jingham, aam. We track down a crash in FindLibCppStdFunctionCallableInfo() to a missing `nullptr` check for the `symbol` variable. https://reviews.llvm.org/D61805 Files: source/Target/CPPLanguageRuntime.cpp Index: source/Target/C

[Lldb-commits] [PATCH] D61778: [Docs] Replace SVN revisions with lldb versions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61778/new/ https://reviews.llvm.org/D61778 ___

[Lldb-commits] [lldb] r360480 - Ted pointed out that some of test tests that are enabling packet

Author: jmolenda Date: Fri May 10 16:03:05 2019 New Revision: 360480 URL: http://llvm.org/viewvc/llvm-project?rev=360480&view=rev Log: Ted pointed out that some of test tests that are enabling packet logging when the testsuite is run with trace mode enabled are leaving the logging enabled after th

[Lldb-commits] [lldb] r360482 - Change the disabling of packet logging to be in TearDownHook lambdas.

Author: jmolenda Date: Fri May 10 16:22:15 2019 New Revision: 360482 URL: http://llvm.org/viewvc/llvm-project?rev=360482&view=rev Log: Change the disabling of packet logging to be in TearDownHook lambdas. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/

[Lldb-commits] [PATCH] D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo()

friss added a comment. Do you have a testcase triggering this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61805/new/ https://reviews.llvm.org/D61805 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D61759: Switch to FindSymbolsMatchingRegExAndType() from FindFunctions() in FindLibCppStdFunctionCallableInfo()

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. This seems obviously better, go for it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61759/new/ https://reviews.llvm.org/D61759 ___ lldb-

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

xiaobai updated this revision to Diff 199113. xiaobai added a comment. - Fix minor bug - Return vector by value instead of passing in one by parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61746/new/ https://reviews.llvm.org/D61746 Files: include/lldb/Target/Language.h sou

[Lldb-commits] [PATCH] D61805: Add nullptr check in FindLibCppStdFunctionCallableInfo()

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. What's the scenario that's causing this? Adding a nullptr check is an obviously save thing to do, but it would be excellent if we could add a comment explaining why the symbol could

[Lldb-commits] [lldb] r360509 - [Breakpoint] Make breakpoint language agnostic

Author: xiaobai Date: Fri May 10 20:32:25 2019 New Revision: 360509 URL: http://llvm.org/viewvc/llvm-project?rev=360509&view=rev Log: [Breakpoint] Make breakpoint language agnostic Summary: Breakpoint shouldn't need to depend on any specific details from a programming language. Currently the only

[Lldb-commits] [PATCH] D61746: [Breakpoint] Make breakpoint language agnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rL360509: [Breakpoint] Make breakpoint language agnostic (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAS