[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

labath added a comment. I'm going to throw one more opinion into the mix here. :) While I agree that sprinkling `#ifdef PYTHON` everywhere is bad, and it's great to be rid of it, I also think that it is good for the user to be able to know how a particular build of lldb was configured. So, I wo

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot marked 2 inline comments as done. zloyrobot added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:110 + +static std::string findPdbFile(const llvm::StringRef exe_path, const llvm::StringRef pdb_file, llvm::file_magic &magic

[Lldb-commits] [PATCH] D59537: Instantiate 'std' templates explicitly in the expression evaluator

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Symbol/StdModuleHandler.cpp:242 +// Instantiate the template. +found_decl = ClassTemplateSpecializationDecl::Create( +m_sema->getASTContext(), mar

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

labath added a subscriber: zturner. labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:110 + +static std::string findPdbFile(const llvm::StringRef exe_path, const llvm::StringRef pdb_file, llvm::file_magic &magic) { + auto

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot updated this revision to Diff 196614. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60962/new/ https://reviews.llvm.org/D60962 Files: lldb/lit/SymbolFile/NativePDB/Inputs/pdb-file-lookup.lldbinit lldb/lit/SymbolFile/NativePDB/pdb-file-lookup.cpp

[Lldb-commits] [PATCH] D60962: [NativePDB] Extend .pdb files search folders

zloyrobot marked 2 inline comments as done. zloyrobot added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:110 + +static std::string findPdbFile(const llvm::StringRef exe_path, const llvm::StringRef pdb_file, llvm::file_magic &magic

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy added a comment. Ping! Are these changes accepted ? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60519/new/ https://reviews.llvm.org/D60519 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D61128: Fix stack unwinding for struct methods

zloyrobot created this revision. zloyrobot added reviewers: amccarth, aleksandr.urakov. zloyrobot added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. Repository: rLLDB LLDB https://reviews.llvm.org/D61128 Files: lldb/lit/SymbolFile/NativePDB/Inputs/stack_unwinding01.lld

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

clayborg added a comment. I agree with Pavel: no new SB APIs needed as this call is where it is supposed to be on SBHostOS. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61090/new/ https://reviews.llvm.org/D61090 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D61085: [lldb] [lit] Remove unnecessary array use in XMM reading test

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This looks like the kind of thing you could have committed without review. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61085/new/ https://reviews.llvm.org/D61085 _

[Lldb-commits] [PATCH] D61072: [lldb] [lit] Add tests for reading new x86_64 registers

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/lit/Register/Inputs/x86-64-read.cpp:8 +int main() { + uint64_t r8 = 0x0102030405060708; + uint64_t r9 = 0x1112131415161718; what do yo

[Lldb-commits] [PATCH] D61072: [lldb] [lit] Add tests for reading new x86_64 registers

mgorny added inline comments. Comment at: lldb/lit/Register/Inputs/x86-64-read.cpp:8 +int main() { + uint64_t r8 = 0x0102030405060708; + uint64_t r9 = 0x1112131415161718; labath wrote: > what do you think about including r0-r7 too? They're of different sizes on

[Lldb-commits] [PATCH] D61074: [lldb] [lit] Add register read tests for YMM registers (AVX)

labath added a comment. This test is pretty much a reimplementation of TestYMMRegisters dotest test. I like this one more for several reasons, but if we're going to check this in, we should also delete the other one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61074/new/ https://rev

[Lldb-commits] [PATCH] D61073: [lldb] [lit] Add feature flags for native CPU features

labath added a reviewer: JDevlieghere. labath added a subscriber: JDevlieghere. labath added a comment. I like this approach, but as this is a novel idea, I'd like to get more opinions first. @JDevlieghere, what do you think? Comment at: lldb/lit/lit.cfg.py:81 +cpuid_exe =

[Lldb-commits] [PATCH] D61073: [lldb] [lit] Add feature flags for native CPU features

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/lit/lit.cfg.py:81 +cpuid_exe = lit.util.which('lit-cpuid', config.lldb_tools_dir) +if cpuid_exe is not None: +out, err, exitcode = lit.util.executeCommand([cpuid_exe])

[Lldb-commits] [PATCH] D61072: [lldb] [lit] Add tests for reading new x86_64 registers

labath added inline comments. Comment at: lldb/lit/Register/Inputs/x86-64-read.cpp:8 +int main() { + uint64_t r8 = 0x0102030405060708; + uint64_t r9 = 0x1112131415161718; mgorny wrote: > labath wrote: > > what do you think about including r0-r7 too? They're of

[Lldb-commits] [PATCH] D61073: [lldb] [lit] Add feature flags for native CPU features

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I really like this too, it's conceptually simple, easy to use and allows us to write more tests in lit. Thanks for doing this Michał. Comment at: lldb/lit/lit.cf

[Lldb-commits] [PATCH] D61056: PostfixExpression: move DWARF generator out of NativePDB internals

labath updated this revision to Diff 196665. labath marked an inline comment as done. labath added a comment. - simplify symbol resolution even more - drop the NativePDB unittest changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61056/new/ https://reviews.llvm.org/D61056 Files: i

[Lldb-commits] [PATCH] D61056: PostfixExpression: move DWARF generator out of NativePDB internals

labath marked 4 inline comments as done. labath added a comment. In D61056#1477914 , @amccarth wrote: > Can the test deletions be a separate patch, or will they fail because of the > other changes in this patch? They feel like a good but separable step.

[Lldb-commits] [lldb] r359206 - Fixed typo in CompileUnit::GetImportedModules documentation [NFC]

Author: teemperor Date: Thu Apr 25 10:08:54 2019 New Revision: 359206 URL: http://llvm.org/viewvc/llvm-project?rev=359206&view=rev Log: Fixed typo in CompileUnit::GetImportedModules documentation [NFC] Modified: lldb/trunk/include/lldb/Symbol/CompileUnit.h Modified: lldb/trunk/include/lldb/S

Re: [Lldb-commits] [lldb] r359138 - [ScriptInterpreterPython] find_first_of -> find (NFC)

On 24/04/2019 22:40, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Wed Apr 24 13:40:24 2019 New Revision: 359138 URL: http://llvm.org/viewvc/llvm-project?rev=359138&view=rev Log: [ScriptInterpreterPython] find_first_of -> find (NFC) Follow up to r357198. Modified:

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

jingham added a comment. I'm a bit confused. If we get to the world where we can support multiple script interpreters, I would expect to add a static method on ScriptInterpreter that enumerates the available interpreters. I would not expect that to be on SBHostOS since this is not a feature o

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

labath added a comment. In D61090#1479004 , @jingham wrote: > I'm a bit confused. If we get to the world where we can support multiple > script interpreters, I would expect to add a static method on > ScriptInterpreter that enumerates the available inte

[Lldb-commits] [PATCH] D61074: [lldb] [lit] Add register read tests for YMM registers (AVX)

mgorny added a comment. In D61074#1478859 , @labath wrote: > This test is pretty much a reimplementation of TestYMMRegisters dotest test. > I like this one more for several reasons, but if we're going to check this > in, we should also delete the other o

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

jingham added a comment. I really thought there was one at the SB layer, because in terms of design that is what makes sense. I guess we never really needed it until now, so we didn't add it. Once there's more than one hard-coded script interpreter, we will need to add some way to select & di

[Lldb-commits] [PATCH] D61073: [lldb] [lit] Add feature flags for native CPU features

mgorny updated this revision to Diff 196675. mgorny added a comment. Added warnings for missing or failed lit-cpuid. Not that there any failure conditions in the program right now ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61073/new/ https://reviews.llvm.org/D61073 Files: ll

[Lldb-commits] [lldb] r359208 - [lldb] [lit] Remove unnecessary array use in XMM reading test

Author: mgorny Date: Thu Apr 25 10:42:40 2019 New Revision: 359208 URL: http://llvm.org/viewvc/llvm-project?rev=359208&view=rev Log: [lldb] [lit] Remove unnecessary array use in XMM reading test Remove the use of 2-element array for XMM data. It is an accidental leftover from previous implementa

[Lldb-commits] [lldb] r359210 - [lldb] [lit] Add tests for reading new x86_64 registers

Author: mgorny Date: Thu Apr 25 10:42:49 2019 New Revision: 359210 URL: http://llvm.org/viewvc/llvm-project?rev=359210&view=rev Log: [lldb] [lit] Add tests for reading new x86_64 registers Add tests covering read operations for the general-purpose and XMM registers added in x86_64 (r8-r15 and xmm

[Lldb-commits] [PATCH] D61072: [lldb] [lit] Add tests for reading new x86_64 registers

This revision was automatically updated to reflect the committed changes. Closed by commit rL359210: [lldb] [lit] Add tests for reading new x86_64 registers (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[Lldb-commits] [PATCH] D61085: [lldb] [lit] Remove unnecessary array use in XMM reading test

This revision was automatically updated to reflect the committed changes. Closed by commit rL359208: [lldb] [lit] Remove unnecessary array use in XMM reading test (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D61090: [SBHostOS} Remove getting the python script interpreter path

clayborg added a comment. I agree with all that was said above. My reason for leaving it in SBHostOS is due to SBCommandInterpreter not being the right place, since we don't have SBScriptInprereter in the API, and we might as well leave it in SBHostOS until we are going to do it right by having

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Yes, sorry. I hadn't gotten around to testing it to make sure the failures were gone. Do you still need someone to commit for you? Repository: rLLDB LLDB CHANGES SINCE

[Lldb-commits] [PATCH] D61056: PostfixExpression: move DWARF generator out of NativePDB internals

amccarth accepted this revision. amccarth marked 2 inline comments as done. amccarth added a comment. This revision is now accepted and ready to land. Clever (hopefully not too clever)! Not having to derive a special class from Visitor is really nice. LGTM. Comment at: inclu

[Lldb-commits] [PATCH] D60519: [Windows] Dump more information about access violation exception

leonid.mashinskiy added a comment. Thanks! I think I can ask @aleksandr.urakov to land changes. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60519/new/ https://reviews.llvm.org/D60519 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r359221 - [lldb] [lit] Un-XFAIL Register/x86-64-read.test for Darwin

Author: mgorny Date: Thu Apr 25 11:38:58 2019 New Revision: 359221 URL: http://llvm.org/viewvc/llvm-project?rev=359221&view=rev Log: [lldb] [lit] Un-XFAIL Register/x86-64-read.test for Darwin Modified: lldb/trunk/lit/Register/x86-64-read.test Modified: lldb/trunk/lit/Register/x86-64-read.tes

[Lldb-commits] [lldb] r359228 - [lldb] [lit] Use constexpr and better constraints in Register tests

Author: mgorny Date: Thu Apr 25 12:56:54 2019 New Revision: 359228 URL: http://llvm.org/viewvc/llvm-project?rev=359228&view=rev Log: [lldb] [lit] Use constexpr and better constraints in Register tests Use constexpr to explicitly indicate that we're dealing with integer constants, and provoke clan

[Lldb-commits] [lldb] r359234 - Two tests were using the interactive convenience variable

Author: jmolenda Date: Thu Apr 25 13:03:39 2019 New Revision: 359234 URL: http://llvm.org/viewvc/llvm-project?rev=359234&view=rev Log: Two tests were using the interactive convenience variable lldb.debugger. They should not be. Modified: lldb/trunk/packages/Python/lldbsuite/test/expressio

[Lldb-commits] [PATCH] D61074: [lldb] [lit] Add register read tests for YMM registers (AVX)

mgorny updated this revision to Diff 196714. mgorny added a comment. Added a 32-bit version of the test, and constexpr. I propose to keep the dotest tests until I reimplement ZMM as well, and then remove it altogether. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61074/new/ https://r

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

shafik created this revision. shafik added reviewers: jingham, aprantl, teemperor, rsmith. This will fix a bug where during expression parsing we are not setting a `CXXRecordDecl` to not be passed in registers and the resulting code generation is wrong. The DWARF attribute `DW_CC_pass_by_refere

[Lldb-commits] [lldb] r359240 - Another use of the interactive lldb.debugger.

Author: jmolenda Date: Thu Apr 25 13:45:10 2019 New Revision: 359240 URL: http://llvm.org/viewvc/llvm-project?rev=359240&view=rev Log: Another use of the interactive lldb.debugger. Modified: lldb/trunk/packages/Python/lldbsuite/test/python_api/formatters/synth.py Modified: lldb/trunk/packag

[Lldb-commits] [PATCH] D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF

shafik added a comment. @rsmith I tagged you in this change in case we are missing any implications in using `DW_CC_pass_by_reference` to do `setArgPassingRestrictions(clang::RecordDecl::APK_CannotPassInRegs);` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61146/new/ https://reviews.l

[Lldb-commits] [PATCH] D60667: Allow direct comparison of ConstString against StringRef

teemperor updated this revision to Diff 196732. teemperor added a comment. - Removed the remaining uses of the new operator for comparisons against values that are not literals. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60667/new/ https://reviews.llvm.org/D60667 Files: lldb/incl

[Lldb-commits] [PATCH] D60667: Allow direct comparison of ConstString against StringRef

teemperor added a comment. > I didn't mean to imply that `strlen` is called twice. My point was that > there are two linear passes over the string literal: The first is the call > to `strlen` to make the StringRef, and the second is the actual string > comparison. Thanks for the explanation.

[Lldb-commits] [lldb] r359249 - [TestTemplateFunction] Add a missing debug info variant.

Author: davide Date: Thu Apr 25 15:53:10 2019 New Revision: 359249 URL: http://llvm.org/viewvc/llvm-project?rev=359249&view=rev Log: [TestTemplateFunction] Add a missing debug info variant. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/template-function/TestTemplateFunctions.p

[Lldb-commits] [PATCH] D61128: Fix stack unwinding for struct methods

amccarth added a comment. Please add some detail to the commit message and consider re-titling it. It looks like this patch is actually adding missing functionality rather than "fixing" a bug in how structs are handled. If that's correct, then please make the commit message reflect that. Sor

[Lldb-commits] [PATCH] D60957: Read ObjC class names in one large read, instead of reading them individually

jasonmolenda updated this revision to Diff 196776. jasonmolenda added a comment. Fix one small bug in the jitted expressions. Increase the estimated size of class names that lldb uses to pre-allocate the string pool buffer. Added a method to read the string pool out of the inferior, to reduce

[Lldb-commits] [PATCH] D61172: [ScriptInterpreter] Pass the debugger instead of the command interpreter

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, jingham. Herald added a project: LLDB. As discussed in D61090 , there's no good reason for the script interpreter to depend on the command interpreter. When looking at the code, i