JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
I really like this too, it's conceptually simple, easy to use and allows us to
write more tests in lit. Thanks for doing this Michał.
================
Comment at: lldb/lit/lit.cfg.py:81
+ cpuid_exe = lit.util.which('lit-cpuid', config.lldb_tools_dir)
+ if cpuid_exe is not None:
+ out, err, exitcode = lit.util.executeCommand([cpuid_exe])
----------------
mgorny wrote:
> labath wrote:
> > So if the binary is not found for any reason, this will just silently skip
> > the relevant tests, right? Would it make sense to at least print a warning
> > in this case?
> Yes, it will skip them. I don't have an opinion on whether it's something we
> should warn about; but I can surely add one.
I agree it would be good to print a warning. We're the ones building the tool
so there's really no good reason for it not to be found.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61073/new/
https://reviews.llvm.org/D61073
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
