[Lldb-commits] [lldb] r354766 - Finish revert of r354706

Author: labath Date: Mon Feb 25 01:30:41 2019 New Revision: 354766 URL: http://llvm.org/viewvc/llvm-project?rev=354766&view=rev Log: Finish revert of r354706 The revert in r354711 wasn't complete. Finish the job. Modified: lldb/trunk/lit/ExecControl/StopHook/stop-hook.test Modified: lldb/tr

[Lldb-commits] [PATCH] D58394: Add --auto-continue to stop-hooks, fix up a few tests

labath added a comment. I'm not sure why you ended up reverting this, but it looks like the revert wasn't complete (which is why we got the test failures that Jan mentions). I've finished the revert in r354766. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58394/

[Lldb-commits] [PATCH] D58394: Add --auto-continue to stop-hooks, fix up a few tests

jankratochvil added a comment. In D58394#1408117 , @jankratochvil wrote: > Getting now failure for every run: `LLDB :: > ExecControl/StopHook/stop-hook.test` It is because after this commit (rL354706 = GIT `ff8c7a09

[Lldb-commits] [PATCH] D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

abidh accepted this revision. abidh added a comment. This revision is now accepted and ready to land. The lldb-mi bits look ok to me. Comment at: tools/lldb-mi/MIUtilString.h:36 va_list vArgs); + static bool IsAllValidAlphaAndNumeric(cons

[Lldb-commits] [PATCH] D58610: [lldb] [lit] Set LD_LIBRARY_PATH or alike for Suite tests

mgorny created this revision. mgorny added a reviewer: labath. mgorny added a project: LLDB. Herald added subscribers: abidh, fedor.sergeev. Set LD_LIBRARY_PATH or local platform's equivalent of it when running the 'Suite' tests. This is necessary when running tests inside build tree with BUILD_S

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

serge-sans-paille abandoned this revision. serge-sans-paille added a comment. @sgraenitz It's fixed! I'm dropping this patch then, thanks for investigating o/ Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58193/new/ https://reviews.llvm.org/D58193 __

[Lldb-commits] [PATCH] D58339: Changes for running LLDB test suite for Swift on PowerPC64LE

sarveshtamba added a comment. Hi, can someone point me the right repo to submit these changes? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58339/new/ https://reviews.llvm.org/D58339 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D58339: Changes for running LLDB test suite for Swift on PowerPC64LE

teemperor added a comment. That should be the right repo: https://github.com/apple/swift-lldb Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58339/new/ https://reviews.llvm.org/D58339 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

tatyana-krasnukha updated this revision to Diff 188188. tatyana-krasnukha added a comment. Removed new lines from MIUtilString.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55653/new/ https://reviews.llvm.org/D55653 Files: tools/lldb-mi/MICmdCmdMiscellanous.cpp tools/lldb-mi/MICm

[Lldb-commits] [lldb] r354798 - [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

Author: tkrasnukha Date: Mon Feb 25 08:40:11 2019 New Revision: 354798 URL: http://llvm.org/viewvc/llvm-project?rev=354798&view=rev Log: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment Differential Revision: https://reviews.llvm.org/D55653 Added: lldb/trunk/un

[Lldb-commits] [PATCH] D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL354798: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment (authored by tkrasnukha, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[Lldb-commits] [PATCH] D58630: [lldb] [test] Pass appropriate -L for just-built libc++

mgorny created this revision. mgorny added reviewers: krytarowski, labath, zturner. mgorny added a project: LLDB. Herald added a reviewer: EricWF. Herald added a subscriber: teemperor. Herald added a reviewer: serge-sans-paille. Pass appropriate -L flags pointing out to the LLVM library directory

[Lldb-commits] [lldb] r354803 - [lldb-mi] Fix conversion warning for 64-bit build

Author: tkrasnukha Date: Mon Feb 25 10:23:44 2019 New Revision: 354803 URL: http://llvm.org/viewvc/llvm-project?rev=354803&view=rev Log: [lldb-mi] Fix conversion warning for 64-bit build Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebugger.cpp Modified: lldb/trunk/tools/lldb-mi/MICmnLLDBDebu

[Lldb-commits] [lldb] r354804 - [lldb-mi] Return source line number in proper format

Author: tkrasnukha Date: Mon Feb 25 10:32:46 2019 New Revision: 354804 URL: http://llvm.org/viewvc/llvm-project?rev=354804&view=rev Log: [lldb-mi] Return source line number in proper format Line number is a decimal number and is printed as such, however for some reason it was prefixed with '0x',

Re: [Lldb-commits] [lldb] r354711 - Revert r354706 - lit touched my thigh

While it’s a good chuckle, can you elaborate on what exactly the commit message means? On Fri, Feb 22, 2019 at 5:07 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jingham > Date: Fri Feb 22 17:08:17 2019 > New Revision: 354711 > > URL: http://llvm.org/viewvc/llvm-pr

[Lldb-commits] [PATCH] D58565: [Reproducers] Enable replay from SBRepro

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58565/new/ https://reviews.llvm.org/D58565 ___ lldb-commits

Re: [Lldb-commits] [lldb] r354711 - Revert r354706 - lit touched my thigh

A test that was passing locally failed on the bot after submitting this patch. Not sure what the difference is yet. Jim > On Feb 25, 2019, at 12:22 PM, Zachary Turner wrote: > > While it’s a good chuckle, can you elaborate on what exactly the commit > message means? > On Fri, Feb 22, 2019 a

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

aprantl added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:31 +class CommandProvider; +struct CommandProviderInfo { + static const char *name; Doxygen comments? Comment at: lldb/include/lldb/Interpreter/Comma

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere updated this revision to Diff 188244. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Add comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58564/new/ https://reviews.llvm.org/D58564 Files: lldb/include/lldb/Interpreter/CommandInterprete

[Lldb-commits] [PATCH] D58648: Improve process launch comments for Windows

amccarth created this revision. amccarth added a reviewer: zturner. The existing comment about over-allocating the command line was incorrect. The contents of the command line may be changed, but it's not necessary to over allocate. The changes will be limited to the existing contents of the s

[Lldb-commits] [PATCH] D58648: Improve process launch comments for Windows

amccarth updated this revision to Diff 188263. amccarth added a comment. Forgot to include context in original diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58648/new/ https://reviews.llvm.org/D58648 Files: lldb/source/Host/windows/ProcessLauncherWindows.cpp Index: lldb/sourc

[Lldb-commits] [PATCH] D58566: [Reproducers] Add more logging capabilities to reproducer instrumentation

aprantl added inline comments. Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:591 -LLDB_LOG(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API), "Recording ({0}) '{1}'", +#ifndef LLDB_REPRO_INSTR_TRACE +LLDB_LOG(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API), "Reco

[Lldb-commits] [PATCH] D58653: [Utility] Allow the value 'unknown' when checking if triple components are unknown

xiaobai created this revision. xiaobai added reviewers: aprantl, labath, JDevlieghere. Herald added subscribers: jdoerfert, srhines. I saw that `llvm::Triple::normalize` will set vendor, os, and environment to "unknown" if they aren't set. Because we use that function when creating a triple with a

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

zturner created this revision. zturner added reviewers: labath, jgorbe, JDevlieghere, davide. Herald added subscribers: mgorny, emaste. `Host/Config.h` is where we have platform specific preprocessor defines that are configured at CMake time. Then, we can include this file `lldb/Host/Config.h`

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

JDevlieghere added a comment. Makes sense, no objections from me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58654/new/ https://reviews.llvm.org/D58654 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D58653: [Utility] Allow the value 'unknown' when checking if triple components are unknown

JDevlieghere added a comment. Do we actually need to check the string values in addition to the enum values? It looks like the llvm class tries pretty hard to make that the canonical way to query it. I know triples and arches are pretty tricky in lldb though, so maybe there's a reason that we c

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

jingham added a comment. Utility is supposed to be a bunch of stand-alone utility files & headers that we gather together for convenience's sake. Host is where we put all the code that is specific to one or another host, and any support files that requires. For instance, that's why PlatformLin

[Lldb-commits] [PATCH] D58564: [Reproducers] Add command provider

JDevlieghere updated this revision to Diff 188286. JDevlieghere added a comment. - Add testcase. - Don't log sourced commands twice. For some reason I thought that we no longer needed to differentiate between commands being sourced from a file. I remember an earlier discussing with Pavel on thi

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

zturner added a comment. In D58654#1409974 , @jingham wrote: > Utility is supposed to be a bunch of stand-alone utility files & headers that > we gather together for convenience's sake. > > Host is where we put all the code that is specific to one or anot

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

jingham added a comment. There aren't many more platforms (OpenVMS?) that are likely to show up and need support for lldb, so maybe this is making too much of the matter. But having there be a well defined set of places where you need to look when porting lldb to a new host platform seems a us

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

zturner added a comment. In D58654#1410080 , @jingham wrote: > There aren't many more platforms (OpenVMS?) that are likely to show up and > need support for lldb, so maybe this is making too much of the matter. But > having there be a well defined set o

[Lldb-commits] [PATCH] D58653: [Utility] Allow the value 'unknown' when checking if triple components are unknown

xiaobai updated this revision to Diff 188309. xiaobai added a comment. Remove redundant checks for triple components CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58653/new/ https://reviews.llvm.org/D58653 Files: include/lldb/Utility/ArchSpec.h source/Utility/ArchSpec.cpp unittes

[Lldb-commits] [PATCH] D58653: [Utility] Allow the value 'unknown' when checking if triple components are unknown

xiaobai added a comment. In D58653#1409978 , @JDevlieghere wrote: > Do we actually need to check the string values in addition to the enum > values? It looks like the llvm class tries pretty hard to make that the > canonical way to query it. I know trip

[Lldb-commits] [PATCH] D58664: [Utility] Fix ArchSpec.MergeFrom to correctly merge environments

xiaobai created this revision. xiaobai added reviewers: aprantl, labath, JDevlieghere, clayborg. Herald added subscribers: jdoerfert, srhines. This behavior was originally added in rL252264 (git commit 76a7f365da) in order to be extra careful with handling plat

[Lldb-commits] [PATCH] D58664: [Utility] Fix ArchSpec.MergeFrom to correctly merge environments

xiaobai updated this revision to Diff 188312. xiaobai set the repository for this revision to rLLDB LLDB. xiaobai added a comment. Herald added a subscriber: abidh. Herald added a project: LLDB. Accidentally added a commit to this diff that I didn't intend to add. Repository: rLLDB LLDB CHANG

[Lldb-commits] [PATCH] D58653: [Utility] Allow the value 'unknown' when checking if triple components are unknown

labath added a reviewer: clayborg. labath added a comment. I think this basically defeats the purpose of the `IsUnspecifiedUnknown` functions, which was to differentiate between foo-unknown-bar and foo--bar triples. That in itself was a pretty big hack, but it seems that there is functionality