mgorny created this revision. mgorny added a reviewer: labath. mgorny added a project: LLDB. Herald added subscribers: abidh, fedor.sergeev.
Set LD_LIBRARY_PATH or local platform's equivalent of it when running the 'Suite' tests. This is necessary when running tests inside build tree with BUILD_SHARED_LIBS enabled, in order to make the LLDB modules load freshly built LLVM libraries. The code is copied from clang (test/Unit/lit.cfg) with minimal change of removing support for disjoint LLVM/Clang library directory. A similar option (along with additional site configuration variable) will become necessary if LLDB ever starts supporting building shared libraries, for stand-alone builds (where LLDB library dir != LLVM library dir). Repository: rLLDB LLDB https://reviews.llvm.org/D58610 Files: lldb/lit/Suite/lit.cfg Index: lldb/lit/Suite/lit.cfg =================================================================== --- lldb/lit/Suite/lit.cfg +++ lldb/lit/Suite/lit.cfg @@ -3,6 +3,7 @@ # Configuration file for the 'lit' test runner. import os +import platform import shlex import lit.formats @@ -32,6 +33,25 @@ 'detect_stack_use_after_return=1' config.environment['DYLD_INSERT_LIBRARIES'] = runtime +# Shared library build of LLVM may require LD_LIBRARY_PATH or equivalent. +def find_shlibpath_var(): + if platform.system() in ['Linux', 'FreeBSD', 'NetBSD', 'SunOS']: + yield 'LD_LIBRARY_PATH' + elif platform.system() == 'Darwin': + yield 'DYLD_LIBRARY_PATH' + elif platform.system() == 'Windows': + yield 'PATH' + +for shlibpath_var in find_shlibpath_var(): + shlibpath = os.path.pathsep.join( + (config.llvm_libs_dir, + config.environment.get(shlibpath_var, ''))) + config.environment[shlibpath_var] = shlibpath + break +else: + lit_config.warning("unable to inject shared library path on '{}'" + .format(platform.system())) + # Build dotest command. dotest_cmd = [config.dotest_path, '-q'] dotest_cmd.extend(config.dotest_args_str.split(';'))
Index: lldb/lit/Suite/lit.cfg =================================================================== --- lldb/lit/Suite/lit.cfg +++ lldb/lit/Suite/lit.cfg @@ -3,6 +3,7 @@ # Configuration file for the 'lit' test runner. import os +import platform import shlex import lit.formats @@ -32,6 +33,25 @@ 'detect_stack_use_after_return=1' config.environment['DYLD_INSERT_LIBRARIES'] = runtime +# Shared library build of LLVM may require LD_LIBRARY_PATH or equivalent. +def find_shlibpath_var(): + if platform.system() in ['Linux', 'FreeBSD', 'NetBSD', 'SunOS']: + yield 'LD_LIBRARY_PATH' + elif platform.system() == 'Darwin': + yield 'DYLD_LIBRARY_PATH' + elif platform.system() == 'Windows': + yield 'PATH' + +for shlibpath_var in find_shlibpath_var(): + shlibpath = os.path.pathsep.join( + (config.llvm_libs_dir, + config.environment.get(shlibpath_var, ''))) + config.environment[shlibpath_var] = shlibpath + break +else: + lit_config.warning("unable to inject shared library path on '{}'" + .format(platform.system())) + # Build dotest command. dotest_cmd = [config.dotest_path, '-q'] dotest_cmd.extend(config.dotest_args_str.split(';'))
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits