[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

labath marked an inline comment as done. labath added a comment. In D56537#1393202 , @amccarth wrote: > My knowledge of PECOFF is even more limited, but it's my understanding that > the ImageBase is the _preferred_ address for the module. That doesn't >

[Lldb-commits] [lldb] r353806 - [NativePDB] Process virtual bases in the correct order

Author: aleksandr.urakov Date: Tue Feb 12 00:17:11 2019 New Revision: 353806 URL: http://llvm.org/viewvc/llvm-project?rev=353806&view=rev Log: [NativePDB] Process virtual bases in the correct order Summary: This patch makes virtual bases to be added in the correct order to the bases list. It is i

[Lldb-commits] [PATCH] D56904: [NativePDB] Process virtual bases in the correct order

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353806: [NativePDB] Process virtual bases in the correct order (authored by aleksandr.urakov, committed by ). Herald ad

[Lldb-commits] [PATCH] D57995: [lldb] [cmake] Use install directories for LLVM_* variables

mgorny added a comment. Indeed it is a problem. However, it seems to be a bug that `LLVM_INCLUDE_DIR` contains two directories. Apparently in regular builds it contains the directory with built includes only, with `LLVM_MAIN_INCLUDE_DIR` being the other directory. In other words, it's a mess ;-

[Lldb-commits] [lldb] r353812 - Extract common PlatformPOSIX/Windows code into a separate class

Author: labath Date: Tue Feb 12 01:27:24 2019 New Revision: 353812 URL: http://llvm.org/viewvc/llvm-project?rev=353812&view=rev Log: Extract common PlatformPOSIX/Windows code into a separate class Summary: The two classes contained a lot of duplicated code, but there wasn't a good place to factor

[Lldb-commits] [PATCH] D58052: Extract common PlatformPOSIX/Windows code into a separate class

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353812: Extract common PlatformPOSIX/Windows code into a separate class (authored by labath, committed by ). Herald added a subscriber: jdoerfert. Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D57995: [lldb] [cmake] Use install directories for LLVM_* variables

mgorny updated this revision to Diff 186427. mgorny added a comment. Updated to use exported LLVM_MAIN_INCLUDE_DIR, as introduced by D58109 . This works both for build-tree and install-tree, and avoids having to introduce any conditionals. CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. Herald added a project: LLDB. `RemoteAwarePlatform` is a thing now, so you should be able to take the methods from PlatformPOSIX which make sense for you, and sink them into the new c

[Lldb-commits] [PATCH] D57995: [lldb] [cmake] Use install directories for LLVM_* variables

sgraenitz added a comment. In D57995#1394412 , @mgorny wrote: > Indeed it is a problem. However, it seems to be a bug that `LLVM_INCLUDE_DIR` > contains two directories. Yes, especially since we also have `LLVM_INCLUDE_DIRS`. But that's not the end.. i

[Lldb-commits] [PATCH] D57402: build: remove custom variables

sgraenitz requested changes to this revision. sgraenitz added a comment. This revision now requires changes to proceed. Actually, both use cases already work without this change: passing `LLVM_DIR && Clang_DIR` or passing `LLDB_PATH_TO_LLVM_BUILD`. IMHO this patch needs good reason to land. Re

[Lldb-commits] [lldb] r353841 - Have Stream::PutCStringAsRawHex8 take llvm::StringRef

Author: labath Date: Tue Feb 12 06:28:55 2019 New Revision: 353841 URL: http://llvm.org/viewvc/llvm-project?rev=353841&view=rev Log: Have Stream::PutCStringAsRawHex8 take llvm::StringRef This enables the function to be called with a StringRef without jumping through any hoops. I rename the functi

[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1370 -auto section = section_list->GetSectionAtIndex(section_idx); +auto section = section_list-

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

teemperor created this revision. teemperor added reviewers: aprantl, jingham, shafik, friss, davide. teemperor added a project: C++ modules in LLDB. Herald added subscribers: lldb-commits, jdoerfert, abidh, mgorny. Herald added a reviewer: serge-sans-paille. Herald added a project: LLDB. This patc

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

teemperor planned changes to this revision. teemperor added a comment. All the changes regarding extracting module include paths are probably superseded by Adrian's patch (which does the same thing nicer). So all the code related to `GetModuleIncludes` will be removed from this patch most likely

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

teemperor updated this revision to Diff 186478. teemperor added a comment. - Cleaned up setup method. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58125/new/ https://reviews.llvm.org/D58125 Files: lldb/include/lldb/Expression/ExpressionSourceCode.h lldb/include/lldb/Symbol/Compile

[Lldb-commits] [PATCH] D58090: [WIP] Deserialize Clang module search path from DWARF

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jdoerfert. +1. That's a cleaner version of what I had to do in D58125 , so feel free to commit when done. The code is similar

[Lldb-commits] [PATCH] D58129: Move UnwindTable from ObjectFile to Module

labath created this revision. labath added reviewers: jasonmolenda, clayborg. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. This is a preparatory step to enable adding extra unwind strategies by symbol file plugins. This has been discussed on the lldb-dev maili

[Lldb-commits] [PATCH] D58131: [lldb] [unittest] Avoid mixing '127.0.0.1' and 'localhost'

mgorny created this revision. mgorny added reviewers: k8stone, labath, krytarowski. mgorny added a project: LLDB. Fix the tests not to use '127.0.0.1' and 'localhost' interchangeably. More specifically, since tests bind specifically to 127.0.0.1, connect to that address as well; using 'localhost'

[Lldb-commits] [PATCH] D58129: Move UnwindTable from ObjectFile to Module

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. You changed the API to return a pointer which can be NULL so we either need to check all returns for this or change the API to return a reference to a default constructed UnwindT

[Lldb-commits] [PATCH] D58131: [lldb] [unittest] Avoid mixing '127.0.0.1' and 'localhost'

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Yeah localhost can cause problems if someone has a custom mapping in their network config file. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58131/new/

[Lldb-commits] [lldb] r353856 - Fix Xcode project for RemoteAwarePlatform files.

Author: gclayton Date: Tue Feb 12 08:54:28 2019 New Revision: 353856 URL: http://llvm.org/viewvc/llvm-project?rev=353856&view=rev Log: Fix Xcode project for RemoteAwarePlatform files. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL

[Lldb-commits] [PATCH] D58131: [lldb] [unittest] Avoid mixing '127.0.0.1' and 'localhost'

krytarowski accepted this revision. krytarowski added a comment. Short term this looks fine. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58131/new/ https://reviews.llvm.org/D58131 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] r353868 - [lldb] [unittest] Avoid mixing '127.0.0.1' and 'localhost'

Author: mgorny Date: Tue Feb 12 10:09:00 2019 New Revision: 353868 URL: http://llvm.org/viewvc/llvm-project?rev=353868&view=rev Log: [lldb] [unittest] Avoid mixing '127.0.0.1' and 'localhost' Fix the tests not to use '127.0.0.1' and 'localhost' interchangeably. More specifically, since tests bind

[Lldb-commits] [PATCH] D58131: [lldb] [unittest] Avoid mixing '127.0.0.1' and 'localhost'

This revision was automatically updated to reflect the committed changes. Closed by commit rL353868: [lldb] [unittest] Avoid mixing '127.0.0.1' and 'localhost' (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [lldb] r353869 - [lldb-instr] Pass PCHContainerOperations to ClangTool

Author: jdevlieghere Date: Tue Feb 12 10:19:34 2019 New Revision: 353869 URL: http://llvm.org/viewvc/llvm-project?rev=353869&view=rev Log: [lldb-instr] Pass PCHContainerOperations to ClangTool On a local modules build this would cause an error. > fatal error: no handler registered for module for

[Lldb-commits] [PATCH] D58090: [WIP] Deserialize Clang module search path from DWARF

JDevlieghere added a comment. The change itself looks fine, just a few nits inline. Comment at: include/lldb/Symbol/SourceModule.h:24 + +}; + Can you run clang-format on this? (It will add `// namespace lldb_private` here.) Comment at: sourc

[Lldb-commits] [PATCH] D57995: [lldb] [cmake] Use install directories for LLVM_* variables

xiaobai added a comment. I just caught up to this thread and wow, yeah things are far more broken than I realized. Apologies for opening this can of worms. That being said, thanks for taking the time to look at it and clean it up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57995/new

[Lldb-commits] [PATCH] D57402: build: remove custom variables

compnerd added a comment. Yes, both paths currently work since the `LLDB_PATH_TO_*` variables are just hints to where to look. It just seems unnecessary to have the custom variables when CMake has a mechanism for directing the build to look for packages in a certain location. Repository: r

[Lldb-commits] [PATCH] D58090: [WIP] Deserialize Clang module search path from DWARF

shafik added inline comments. Comment at: source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:266 - for (size_t ci = 1; ci < path.size(); ++ci) { -llvm::StringRef component = path[ci].GetStringRef(); + for (size_t ci = 1; ci < module.path.size(); ++ci) { +

[Lldb-commits] [lldb] r353894 - [testsuite] Convert TestSingleQuote to lit.

Author: davide Date: Tue Feb 12 14:57:57 2019 New Revision: 353894 URL: http://llvm.org/viewvc/llvm-project?rev=353894&view=rev Log: [testsuite] Convert TestSingleQuote to lit. Nothing crazy, this is pretty mechanical. Added: lldb/trunk/lit/Driver/Inputs/hello.c lldb/trunk/lit/Driver/Tes

[Lldb-commits] [lldb] r353896 - [testsuite] Add a comment explaining what this test does.

Author: davide Date: Tue Feb 12 15:02:53 2019 New Revision: 353896 URL: http://llvm.org/viewvc/llvm-project?rev=353896&view=rev Log: [testsuite] Add a comment explaining what this test does. Modified: lldb/trunk/lit/Driver/TestSingleQuote.test Modified: lldb/trunk/lit/Driver/TestSingleQuote.

[Lldb-commits] [PATCH] D57995: [lldb] [cmake] Use install directories for LLVM_* variables

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. After looking at the dependent patch, this looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57995/new/ https://reviews.llvm.org/D57995

[Lldb-commits] [PATCH] D58076: [Reproducers] Integrate FileProvider with clang

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM with one comment. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:252-262 + + if (repro::Generator *g = repro::Reproducer::Instance().

[Lldb-commits] [PATCH] D58090: Deserialize Clang module search path from DWARF

aprantl updated this revision to Diff 186571. aprantl added a comment. Herald added a reviewer: serge-sans-paille. Almost final version. There's a silly bug that prevents the C Darwin module to be loaded now that I haven't been able to track down yet. CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [lldb] r353906 - [Reproducers] Integrate FileProvider with clang

Author: jdevlieghere Date: Tue Feb 12 17:30:41 2019 New Revision: 353906 URL: http://llvm.org/viewvc/llvm-project?rev=353906&view=rev Log: [Reproducers] Integrate FileProvider with clang This patch hooks up clang and lldb's reproducers functionality. It ensures that when capturing a reproducer, h

[Lldb-commits] [PATCH] D58076: [Reproducers] Integrate FileProvider with clang

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353906: [Reproducers] Integrate FileProvider with clang (authored by JDevlieghere, committed by ). Changed prior to commit: https://reviews.llvm.org/D58076?vs=186336&id=186573#toc Repository: rLLD

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

asmith updated this revision to Diff 186580. Herald added subscribers: jdoerfert, emaste. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56232/new/ https://reviews.llvm.org/D56232 Files: include/lldb/Target/RemoteAwarePlatform.h source/Plugins/Platform/POSIX/PlatformPOSIX.cpp source

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

shafik added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/basic/main.cpp:1 +#include + Looks like you are relying on `iostream` to bring in `cstdlib` which is not guaranteed. Comment

[Lldb-commits] [PATCH] D57402: build: remove custom variables

labath added a comment. IIUC, Stefan would like to have LLVM path be a hint for where to search for clang. That doesn't seem like an unreasonable thing to me. Couldn't that just be solved by passing `${LLVM_DIR}` as a `HINTS` argument to the `find_package(Clang` command? Repository: rLLDB L

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Just for future patches, please make sure to only clang-format the lines you actually touch. This patch includes a lot of formatting changes to lines that haven't been substantiall

[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

labath added a comment. I don't know much about modules so these are just two comments I noticed from a quick glance: - using both `virtual` and `override` on a method (like `ExternalASTSourceWrapper` does) is overkill. Drop `virtual`. - Returning `/usr/include` from `GetSystemIncludeDirectorie

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

Hui added a comment. In D56237#1394320 , @labath wrote: > I like the direction this is going. I have one small comment about the code > organization inline, but the bigger question I have in mind is: After these > changes, is there any use for `Host::Get

[Lldb-commits] [lldb] r353916 - ObjectFilePECOFF: Create a "container" section spanning the entire module image

Author: labath Date: Tue Feb 12 23:17:24 2019 New Revision: 353916 URL: http://llvm.org/viewvc/llvm-project?rev=353916&view=rev Log: ObjectFilePECOFF: Create a "container" section spanning the entire module image Summary: This is coming from the discussion in D55356 (the most interesting part hap

[Lldb-commits] [PATCH] D56537: ObjectFilePECOFF: Create a "container" section spanning the entire module image

This revision was automatically updated to reflect the committed changes. Closed by commit rL353916: ObjectFilePECOFF: Create a "container" section spanning the entire module image (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

labath added a subscriber: sas. labath added a comment. In D56237#1395791 , @Hui wrote: > In D56237#1394320 , @labath wrote: > > > I like the direction this is going. I have one small comment about the code > > org

[Lldb-commits] [PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows

asmith updated this revision to Diff 186591. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56232/new/ https://reviews.llvm.org/D56232 Files: include/lldb/Target/RemoteAwarePlatform.h source/Plugins/Platform/POSIX/PlatformPOSIX.cpp source/Plugins/Platform/POSIX/PlatformPOSIX.h sou