[Lldb-commits] [PATCH] D58125: Add ability to import std module into expression parser to improve C++ debugging

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: 
lldb/packages/Python/lldbsuite/test/expression_command/import-std-module/basic/main.cpp:1
+#include <iostream>
+
----------------
Looks like you are relying on `iostream` to bring in `cstdlib` which is not 
guaranteed. 


================
Comment at: 
lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp:444
+  switch (language) {
+  case lldb::eLanguageTypeC_plus_plus:
+  case lldb::eLanguageTypeC_plus_plus_11:
----------------
`eLanguageTypeC_plus_plus_03`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58125/new/

https://reviews.llvm.org/D58125



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits