labath created this revision.
labath added a reviewer: krytarowski.
This function existed (with identical code) in both NativeProcessLinux
and NativeProcessNetBSD, and it is likely that it would be useful to any
future implementation of NativeProcessProtocol.
Therefore I move it to the base class
labath added inline comments.
Comment at: lit/Expr/TestIRMemoryMapWindows.test:1-12
+# REQUIRES: windows
+
+# RUN: clang-cl /Zi %p/Inputs/call-function.cpp -o %t
+
+# RUN: lldb-test ir-memory-map %t %S/Inputs/ir-memory-map-basic
+# RUN: lldb-test ir-memory-map -host-only %t %S/In
labath added a comment.
In https://reviews.llvm.org/D52461#1250555, @aleksandr.urakov wrote:
> I've tried to parse with it a name like
>
> N0::`unnamed namespase'::Name
>
>
> and it can't parse it correctly. May be it just can't parse MSVC demangled
> names?
I expect the backqoutes are confu
One idea would be to define some lit substitutions like %debuginfo. It’s
true you can produce a gcc style command line that will be equivalent to a
clang-cl invocation but it won’t be easy. eg you’ll needing to pass
-fms-compatibility as well as various -I for includes.
It may be easier to have su
zturner added a comment.
One idea would be to define some lit substitutions like %debuginfo. It’s
true you can produce a gcc style command line that will be equivalent to a
clang-cl invocation but it won’t be easy. eg you’ll needing to pass
-fms-compatibility as well as various -I for includes.
I
Author: jdevlieghere
Date: Mon Oct 1 06:20:15 2018
New Revision: 343470
URL: http://llvm.org/viewvc/llvm-project?rev=343470&view=rev
Log:
Escape newlines in default disassembly format.
We can safely escape newlines in format strings because they will be
ignored by the format entity parser.
Modi
Author: jdevlieghere
Date: Mon Oct 1 06:22:24 2018
New Revision: 343471
URL: http://llvm.org/viewvc/llvm-project?rev=343471&view=rev
Log:
[Interpreter] Escape backticks when dumping format entities.
Currently we reject our own default disassembly-format string because it
contains two backticks w
JDevlieghere updated this revision to Diff 167722.
JDevlieghere edited the summary of this revision.
JDevlieghere added a comment.
- Rebase
https://reviews.llvm.org/D52651
Files:
include/lldb/Interpreter/OptionValue.h
lit/Settings/TestExport.test
source/Commands/CommandObjectSettings.cpp
stella.stamenova added a comment.
In https://reviews.llvm.org/D52618#1250909, @zturner wrote:
> One idea would be to define some lit substitutions like %debuginfo. It’s
> true you can produce a gcc style command line that will be equivalent to a
> clang-cl invocation but it won’t be easy. eg yo
zturner added a comment.
In https://reviews.llvm.org/D52618#1251076, @stella.stamenova wrote:
> In https://reviews.llvm.org/D52618#1250909, @zturner wrote:
>
> > One idea would be to define some lit substitutions like %debuginfo. It’s
> > true you can produce a gcc style command line that will b
Author: asmith
Date: Mon Oct 1 10:08:51 2018
New Revision: 343497
URL: http://llvm.org/viewvc/llvm-project?rev=343497&view=rev
Log:
[lldb] Start a new line for the next output if there are no symbols in the
current symtab
Summary:
If there is no newline the "lldb" prompt could be on the wrong l
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343497: [lldb] Start a new line for the next output if there
are no symbols in the… (authored by asmith, committed by ).
H
Author: tkrasnukha
Date: Mon Oct 1 10:14:12 2018
New Revision: 343500
URL: http://llvm.org/viewvc/llvm-project?rev=343500&view=rev
Log:
Fix build with GCC < 5.0 (PR39131)
Modified:
lldb/trunk/source/Commands/CommandObjectType.cpp
Modified: lldb/trunk/source/Commands/CommandObjectType.c
Author: jdevlieghere
Date: Mon Oct 1 10:20:57 2018
New Revision: 343502
URL: http://llvm.org/viewvc/llvm-project?rev=343502&view=rev
Log:
Fix tests affected by printing change.
I forgot to update some tests that were affected by the escaping of
backticks in the format string, landed in r343471.
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Runnings `settings export` crashes LLDB:
(lldb) down
❲ 8❳ CommandObjectSettingsExport::DoExecute(this=0x55652a80,
args=0x7fffd6b8, result=0x7fffdd80
teemperor added a comment.
- Running `settings export /home/teemperor/foobar1 /home/teemperor/foobar2`
will actually just create foobar1, but will not report any error that foobar2
is silently ignored.
- Do we actually have a way to have file completion for the argument? (This
doesn't have to
aprantl updated this revision to Diff 167827.
aprantl added a comment.
Thanks, that was excellent feedback! Updated the patch to set the expression's
module instead.
https://reviews.llvm.org/D52678
Files:
include/lldb/Expression/DWARFExpression.h
packages/Python/lldbsuite/test/functionalit
Author: adrian
Date: Mon Oct 1 15:27:42 2018
New Revision: 343545
URL: http://llvm.org/viewvc/llvm-project?rev=343545&view=rev
Log:
Enable C++ tests to run in the -gmodules configuration on Darwin.
This addresses PR36048 (http://llvm.org/bugs/show_bug.cgi?id=36048)
rdar://problem/36776281
Modi
jingham added a comment.
To Raphael's points:
Argument completion handlers are set by the command object implementing
HandleArgumentCompletion and dispatching to the
CommandCompletions::eDiskFileCompletion. An example of this is in
CommandObjectProcessLaunch. Note, arguments currently have a
jingham added a comment.
The only thing that worries me about this fix is that it's addressing a problem
that's a pretty easy mistake to make. Is there ever a case that you would want
to resolve a DWARF expression in the context of a .o file module? If not, is
there some way we can make this
20 matches
Mail list logo
