sgraenitz updated this revision to Diff 167593.
sgraenitz marked 8 inline comments as done.
sgraenitz added a comment.
Address feedback from Adrian and Duncan
https://reviews.llvm.org/D52375
Files:
include/lldb/Symbol/Symtab.h
packages/Python/lldbsuite/test/macosx/debug_map/Makefile
packa
sgraenitz added inline comments.
Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:13
+# Set inputs empty, if not passed from the Python script.
+CFLAGS ?=
+LDFLAGS ?=
aprantl wrote:
> This is a noop. You can remove it without affecting anythin
grimar created this revision.
grimar added reviewers: LLDB, clayborg.
Herald added subscribers: JDevlieghere, aprantl.
LLDB does not support this DWARF5 form atm.
At least gcc emits it in some cases when doing optimization
for abbreviations.
As far I can tell, clang does not support it yet, thoug
aprantl added inline comments.
Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:30
+main.o: main.c
+ $(CC) -c -g $(CFLAGS) $(CFLAGS_MAIN) -o main.o $(SRCDIR)/main.c
+
sgraenitz wrote:
> aprantl wrote:
> > ` $(CC) -c $(CFLAGS) $(CFLAGS_M
