JDevlieghere accepted this revision.
JDevlieghere added a comment.
Thanks Vedant, this looks very useful!
https://reviews.llvm.org/D50751
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM minus one small detail (see inline comment). Thanks Vedant!
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:51
import sys
+import tempfile
import tim
tatyana-krasnukha added a comment.
On CentOS this test hangs forever. If I manually kill lldb-mi and lldb-server
subprocesses, the output is
--
Exit Code: 1
Command Output (stderr):
--
/lldb/lit/tools/lldb-mi/target/target-select-so-path.test:16:10: error:
CHECK: expected string no
Author: vedantk
Date: Tue Sep 18 12:31:47 2018
New Revision: 342508
URL: http://llvm.org/viewvc/llvm-project?rev=342508&view=rev
Log:
Allow use of self.filecheck in LLDB tests (c.f self.expect)
Add a "filecheck" method to the LLDB test base. This allows test authors
to pattern match command outpu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342508: Allow use of self.filecheck in LLDB tests (c.f
self.expect) (authored by vedantk, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5075
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB342508: Allow use of self.filecheck in LLDB tests (c.f
self.expect) (authored by vedantk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50751?vs=165613&id=166017#toc
Repository:
shafik created this revision.
shafik added a reviewer: jingham.
SBFrame should be a thin wrapper around the core functionality in StackFrame.
Currently FindVariable() core functionality is implemented in SBFrame and this
will move that into StackFrame.
This is step two in enabling stepping into
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM modulo minor.
Comment at: source/Target/StackFrame.cpp:1733-1738
+if (sc.block->AppendVariables(
+can_create, get_parent_variables,
stop_if_block_is_inl
davide added inline comments.
Comment at: include/lldb/Target/StackFrame.h:506-507
+ lldb::ValueObjectSP FindVariable(const char *name);
+
//--
Also, I think you might want to add a doxygen com
clayborg requested changes to this revision.
clayborg added inline comments.
This revision now requires changes to proceed.
Comment at: include/lldb/Target/StackFrame.h:506
+ lldb::ValueObjectSP FindVariable(const char *name);
+
davide wrote:
> Also, I think y
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
Can you use `target_include_directories` instead and do this only on `lldbHost`
instead please? That restricts the inclusion to just that target, which would
help prevent accide
jingham added a comment.
I agree with Greg, this is the sort of function that we'd pass a ConstString to
on the lldb_private side.
We haven't documented all the API's we should. This one is pretty
self-explanatory, but still we should try to document all the new functions we
add, Davide's rig
12 matches
Mail list logo
