jingham added a comment.

I agree with Greg, this is the sort of function that we'd pass a ConstString to 
on the lldb_private side.

We haven't documented all the API's we should.  This one is pretty 
self-explanatory, but still we should try to document all the new functions we 
add, Davide's right there.

Other than those nits, this seems fine.


https://reviews.llvm.org/D52247



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to