acoomans abandoned this revision.
acoomans added a comment.
@teemperor Nice. Looks like you're way ahead of me. I'll abandon this. Let me
know if you want help with your code!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50802
___
lldb-commi
clayborg marked 13 inline comments as done.
clayborg added inline comments.
Comment at: tools/lldb-vscode/JSONUtils.cpp:472
+char path[PATH_MAX] = "";
+file.GetPath(path, sizeof(path));
+if (path[0]) {
This is a SBFileSpec. We don't allow any STL to b
zturner added a comment.
I had a couple of other comments, but since I responded from email since I was
on the go and I guess they didn't show up inline. Sorry about that. If you
prefer I can resubmit them all as inline comments, or I guess you can just
respond to the email thread.
===
Inline comments really help if you don't mind.
> On Aug 16, 2018, at 9:23 AM, Zachary Turner via Phabricator
> wrote:
>
> zturner added a comment.
>
> I had a couple of other comments, but since I responded from email since I
> was on the go and I guess they didn't show up inline. Sorry abou
clayborg added a subscriber: davide.
clayborg added a comment.
Inline comments really help if you don't mind.
https://reviews.llvm.org/D50365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
zturner added inline comments.
Comment at: tools/lldb-vscode/SourceBreakpoint.h:24
+ // Set this breakpoint in LLDB as a new breakpoint
+ void SetBreakpoint(const char *source_path);
+};
clayborg wrote:
> zturner wrote:
> > clayborg wrote:
> > > zturner wrote:
clayborg marked 2 inline comments as done.
clayborg added inline comments.
Comment at: tools/lldb-vscode/lldb-vscode.cpp:2646
+g_vsc.out = fdopen(socket_fd, "w");
+if (g_vsc.in == nullptr || g_vsc.out == nullptr) {
+ if (g_vsc.log)
The mu
zturner added inline comments.
Comment at: tools/lldb-vscode/lldb-vscode.cpp:2646
+g_vsc.out = fdopen(socket_fd, "w");
+if (g_vsc.in == nullptr || g_vsc.out == nullptr) {
+ if (g_vsc.log)
clayborg wrote:
> The mutex isn't the problem, it
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Thanks for being patient. Looking forward to actually using this on my Linux
box.
https://reviews.llvm.org/D50365
___
lldb-commits mailing li
Author: rnk
Date: Thu Aug 16 10:51:58 2018
New Revision: 339910
URL: http://llvm.org/viewvc/llvm-project?rev=339910&view=rev
Log:
Update LLDB for LLVM CodeView API change in r339907
Modified:
lldb/trunk/source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.cpp
Modified:
lldb/trunk/sour
Author: vedantk
Date: Thu Aug 16 11:18:16 2018
New Revision: 339914
URL: http://llvm.org/viewvc/llvm-project?rev=339914&view=rev
Log:
Disable two flaky pexpect-backed tests on Darwin
These tests are sporadically timing out on our bots, e.g here:
https://ci.swift.org/job/swift-PR-Linux/6841
Mo
Author: rnk
Date: Thu Aug 16 11:24:59 2018
New Revision: 339920
URL: http://llvm.org/viewvc/llvm-project?rev=339920&view=rev
Log:
Fix lldb-vscode build on Windows
Include PosixAPI.h to get a PATH_MAX definition and replace CreateEvent
with CreateEventObject to avoid conflicts with the windows.h d
Author: vedantk
Date: Thu Aug 16 12:56:38 2018
New Revision: 339929
URL: http://llvm.org/viewvc/llvm-project?rev=339929&view=rev
Log:
[dotest] Make --test-subdir work with --no-multiprocess
The single-process test runner is invoked in a number of different
scenarios, including when multiple test
It would be interesting to have some sort of warning or static analyzer to
avoid platform specific name conflicts like CreateEvent. People always use "id"
as a variable name and that can cause problems when a header is included in
objective C.
Thanks for the windows fixes.
> On Aug 16, 2018,
That's a pretty good idea. clang-tidy could probably catch something like
this.
On Thu, Aug 16, 2018 at 1:13 PM Greg Clayton via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> It would be interesting to have some sort of warning or static analyzer to
> avoid platform specific name conflict
(I mean it can't right now, but we could probably make it)
On Thu, Aug 16, 2018 at 1:35 PM Zachary Turner wrote:
> That's a pretty good idea. clang-tidy could probably catch something like
> this.
>
> On Thu, Aug 16, 2018 at 1:13 PM Greg Clayton via lldb-commits <
> lldb-commits@lists.llvm.org>
shafik created this revision.
shafik added reviewers: jingham, davide.
Herald added a reviewer: EricWF.
Herald added a subscriber: christof.
Adding formatter summary for std::function.
- Added LibcxxFunctionSummaryProvider
- Removed LibcxxFunctionFrontEnd
- Modified data formatter tests
Author: gclayton
Date: Thu Aug 16 15:13:01 2018
New Revision: 339954
URL: http://llvm.org/viewvc/llvm-project?rev=339954&view=rev
Log:
Update the Core file loading instructions so they keep the process stopped
after attaching to a core file.
Modified:
lldb/trunk/tools/lldb-vscode/README.md
Author: xiaobai
Date: Thu Aug 16 15:48:46 2018
New Revision: 339959
URL: http://llvm.org/viewvc/llvm-project?rev=339959&view=rev
Log:
Remove outdated TODOs in RegisterValue
These TODOs were for setting m_type in RegisterValue::SetValueFromString
in the case where reg_info's encoding was eEncoding
teemperor added a comment.
@aleksandr.urakov Not sure if you are already working of this, but just FYI
this patch introduced a few compiler warnings:
/Users/teemperor/llvm/sidestuff/llvm/tools/lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:55:3:
warning: default label in switch which co
Author: xiaobai
Date: Thu Aug 16 16:23:18 2018
New Revision: 339965
URL: http://llvm.org/viewvc/llvm-project?rev=339965&view=rev
Log:
Remove commented out constructor from Scalar
This appears to have been commented out since the initial checkin of
lldb.
Modified:
lldb/trunk/source/Utility/Sc
Author: sas
Date: Thu Aug 16 17:35:47 2018
New Revision: 339974
URL: http://llvm.org/viewvc/llvm-project?rev=339974&view=rev
Log:
Add a relocation for R_AARCH64_ABS32 in ObjectFileELF
Summary:
.rela.debug_info relocations are being done via
ObjectFileELF::ApplyRelocations for aarch64. Currently,
22 matches
Mail list logo
