zturner added a comment.
I had a couple of other comments, but since I responded from email since I was
on the go and I guess they didn't show up inline. Sorry about that. If you
prefer I can resubmit them all as inline comments, or I guess you can just
respond to the email thread.
================
Comment at: tools/lldb-vscode/JSONUtils.cpp:472
+ char path[PATH_MAX] = "";
+ file.GetPath(path, sizeof(path));
+ if (path[0]) {
----------------
clayborg wrote:
> This is a SBFileSpec. We don't allow any STL to be used in API.
Ahh good point, my bad.
https://reviews.llvm.org/D50365
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
